NetBSD Problem Report #28685

From reed@rainier.reedmedia.net  Thu Dec 16 23:31:49 2004
Return-Path: <reed@rainier.reedmedia.net>
Received: from pilchuck.reedmedia.net (pilchuck.reedmedia.net [209.166.74.74])
	by narn.netbsd.org (Postfix) with ESMTP id 37E5B63B843
	for <gnats-bugs@gnats.netbsd.org>; Thu, 16 Dec 2004 23:31:40 +0000 (UTC)
Message-Id: <9197-1103239897@rainier.reedmedia.net>
Date: Thu, 16 Dec 2004 15:31:37 -0800
From: reed@reedmedia.net
Reply-To: reed@reedmedia.net
To: gnats-bugs@netbsd.org
Subject: pg_config should be installed with postgresql libs not the client
X-Send-Pr-Version: 3.95

>Number:         28685
>Category:       pkg
>Synopsis:       pg_config should be installed with postgresql libs not the client
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    darcy
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Dec 16 23:33:00 +0000 2004
>Closed-Date:    Sun Mar 20 18:16:01 +0000 2005
>Last-Modified:  Sun Mar 20 18:16:01 +0000 2005
>Originator:     reed@reedmedia.net
>Release:        NetBSD 1.6.2_STABLE
>Organization:
http://bsd.reedmedia.net/
>Environment:


System: NetBSD rainier.reedmedia.net 1.6.2_STABLE NetBSD 1.6.2_STABLE (MYKERNEL) #1: Tue Jun 1 12:16:43 PDT 2004 reed@rainier.reedmedia.net:/usr/src/sys/arch/i386/compile/MYKERNEL i386
Architecture: i386
Machine: i386
>Description:
py-postgresql uses pg_config at build time. If the postgresql74-client
is not installed it will fail.

>How-To-Repeat:
Try to build py-postgresql without the postgresql7x-client package installed.
>Fix:
darcy@ suggested "that pg_config is installed with the libraries,
not the client".

My workaround was add the BUILD_DEPENDS of postgresql74-client.
But since the package works with "73" also, this would not work
and pkgsrc has no public variable for knowing which is used.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->recht
Responsible-Changed-By: reed@netbsd.org
Responsible-Changed-When: Thu, 16 Dec 2004 23:34:59 +0000
Responsible-Changed-Why:
Assigned to maintainer of postgresql74-lib and postgresql74-client, recht.


From: "D'Arcy J.M. Cain" <darcy@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/28685 CVS commit: pkgsrc/databases
Date: Sat, 18 Dec 2004 14:26:15 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	darcy
 Date:		Sat Dec 18 14:26:15 UTC 2004

 Modified Files:
 	pkgsrc/databases/postgresql74-client: Makefile PLIST
 	pkgsrc/databases/postgresql74-lib: Makefile PLIST
 Added Files:
 	pkgsrc/databases/postgresql74/patches: patch-af

 Log Message:
 Move the pg_config binary from -client to -lib.  This fixes PR pkg/28685
 as well as the bulk build for py-postgresql.

 Note that the man page is still built and installed by -client.  That's
 a trickier problem.


 To generate a diff of this commit:
 cvs rdiff -r1.8 -r1.9 pkgsrc/databases/postgresql74-client/Makefile
 cvs rdiff -r1.2 -r1.3 pkgsrc/databases/postgresql74-client/PLIST
 cvs rdiff -r1.13 -r1.14 pkgsrc/databases/postgresql74-lib/Makefile
 cvs rdiff -r1.3 -r1.4 pkgsrc/databases/postgresql74-lib/PLIST
 cvs rdiff -r0 -r1.1 pkgsrc/databases/postgresql74/patches/patch-af

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: recht->darcy
Responsible-Changed-By: darcy@netbsd.org
Responsible-Changed-When: Sat, 18 Dec 2004 14:32:04 +0000
Responsible-Changed-Why:
I may as well take this since I committed the patch.


State-Changed-From-To: open->feedback
State-Changed-By: darcy@netbsd.org
State-Changed-When: Sat, 18 Dec 2004 14:32:04 +0000
State-Changed-Why:
I have moved the binary into the -lib package.  Please confirm that this
fixes the problem.


State-Changed-From-To: feedback->open
State-Changed-By: wiz@netbsd.org
State-Changed-When: Mon, 14 Mar 2005 12:19:46 +0000
State-Changed-Why:
Fixed for 7.4, but not for 7.3 or 8.0.


State-Changed-From-To: open->closed
State-Changed-By: darcy@netbsd.org
State-Changed-When: Sun, 20 Mar 2005 18:16:01 +0000
State-Changed-Why:
No response from submitter but I know that this works and fixes the
immediate problem in the PR.  There may be further things wanted but
they can be requested in a new PR.


>Unformatted:

 This works.  I'm not sure if it is the best way.  It also doesn't deal with
 the man page for pg_config.  I'm not sure how to move that over by itself.
 As it stands it the man page is still installed with the client.  The binary
 is also installed with the client over the one installed by the libs pkg.
 It isn't in the PLIST so the client can still be removed without affecting
 the one installed by libs.

 Index: postgresql74-client/PLIST
 ===================================================================
 RCS file: /cvsroot/pkgsrc/databases/postgresql74-client/PLIST,v
 retrieving revision 1.2
 diff -u -u -r1.2 PLIST
 --- postgresql74-client/PLIST   27 Jun 2004 16:38:32 -0000      1.2
 +++ postgresql74-client/PLIST   17 Dec 2004 17:13:38 -0000
 @@ -9,7 +9,6 @@
 bin/initdb
 bin/initlocation
 bin/ipcclean
 -bin/pg_config
 bin/pg_controldata
 bin/pg_ctl
 bin/pg_dump
 Index: postgresql74-lib/Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/databases/postgresql74-lib/Makefile,v
 retrieving revision 1.13
 diff -u -u -r1.13 Makefile
 --- postgresql74-lib/Makefile   28 Nov 2004 19:19:51 -0000      1.13
 +++ postgresql74-lib/Makefile   17 Dec 2004 17:13:38 -0000
 @@ -13,6 +13,7 @@

 BUILD_DIRS+=           ${WRKSRC}/src/include
 BUILD_DIRS+=           ${WRKSRC}/src/interfaces
 +BUILD_DIRS+=           ${WRKSRC}/src/bin/pg_config

 # without this the Darwin build fails
 # (-bundle_loader related)
 @@ -48,6 +49,8 @@
        cd ${WRKSRC} && ${SETENV} ${MAKE_ENV}           \
                ${MAKE_PROGRAM} -C src/interfaces install
        cd ${WRKSRC} && ${SETENV} ${MAKE_ENV}           \
 +               ${MAKE_PROGRAM} -C src/bin/pg_config install
 +       cd ${WRKSRC} && ${SETENV} ${MAKE_ENV}           \
                ${MAKE_PROGRAM} -C src/pl install
        cd ${WRKSRC}/src/include && ${SETENV} ${MAKE_ENV}       \
                ${MAKE_PROGRAM} install-all-headers
 Index: postgresql74-lib/PLIST
 ===================================================================
 RCS file: /cvsroot/pkgsrc/databases/postgresql74-lib/PLIST,v
 retrieving revision 1.3
 diff -u -u -r1.3 PLIST
 --- postgresql74-lib/PLIST      4 Nov 2004 20:10:13 -0000       1.3
 +++ postgresql74-lib/PLIST      17 Dec 2004 17:13:39 -0000
 @@ -1,5 +1,6 @@
 @comment $NetBSD: PLIST,v 1.3 2004/11/04 20:10:13 recht Exp $
 bin/ecpg
 +bin/pg_config
 include/ecpg_informix.h
 include/ecpgerrno.h
 include/ecpglib.h

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.