NetBSD Problem Report #28743
From jukka@himo.salmi.ch Wed Dec 22 00:01:13 2004
Return-Path: <jukka@himo.salmi.ch>
Received: from mx1.salmi.ch (mx1.salmi.ch [212.254.26.68])
by narn.netbsd.org (Postfix) with ESMTP id DE34663B844
for <gnats-bugs@gnats.NetBSD.org>; Wed, 22 Dec 2004 00:01:12 +0000 (UTC)
Message-Id: <20041222000057.B81F6FD33@himo.salmi.ch>
Date: Wed, 22 Dec 2004 01:00:57 +0100 (CET)
From: j+nbsd@2004.salmi.ch
Reply-To: j+nbsd@2004.salmi.ch
To: gnats-bugs@netbsd.org
Subject: make S/Key an option for security/sudo [patch supplied]
X-Send-Pr-Version: 3.95
>Number: 28743
>Category: pkg
>Synopsis: make S/Key an option for security/sudo
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: jlam
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Wed Dec 22 00:03:00 +0000 2004
>Closed-Date: Wed Dec 22 04:37:01 +0000 2004
>Last-Modified: Wed Dec 22 04:39:00 +0000 2004
>Originator: Jukka Salmi
>Release: NetBSD 2.99.11
>Organization:
>Environment:
System: NetBSD himo.salmi.ch 2.99.11 NetBSD 2.99.11 (GENERIC) #0: Sat Dec 18 12:09:08 CET 2004 build@himo.salmi.ch:/build/nbsd/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
security/sudo is always built with S/Key support (--with-skey)
on NetBSD, and always without (--without-skey) on SunOS. It would
be nice if there was an option to set this because it's possible
to run NetBSD without S/Key libraries ;-)
>How-To-Repeat:
n/a
>Fix:
I'll send the patch in a minute...
>Release-Note:
>Audit-Trail:
From: Jukka Salmi <j+nbsd@2004.salmi.ch>
To: pkgsrc-bugs@netbsd.org
Cc:
Subject: Re: pkg/28743: make S/Key an option for security/sudo [patch supplied]
Date: Wed, 22 Dec 2004 01:07:18 +0100
--GvXjxJ+pjyke8COw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
j+nbsd@2004.salmi.ch --> pkgsrc-bugs (2004-12-22 00:03:00 +0000):
> >Number: 28743
> >Category: pkg
> >Synopsis: make S/Key an option for security/sudo
[...]
> >Fix:
> I'll send the patch in a minute...
Here it is. Defaults remain the same as without this patch.
--
bashian roulette:
$ ((RANDOM%6)) || rm -rf ~
--GvXjxJ+pjyke8COw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="sudo.skey.patch"
diff -ru security/sudo.orig/Makefile security/sudo/Makefile
--- security/sudo.orig/Makefile 2004-11-30 01:54:11.000000000 +0100
+++ security/sudo/Makefile 2004-12-22 00:49:06.000000000 +0100
@@ -28,9 +28,7 @@
CONFIGURE_ARGS+= --disable-root-mailer --disable-setreuid
CONFIGURE_ARGS+= --sysconfdir=${PKG_SYSCONFDIR}
-.if ${OPSYS} == "NetBSD"
-CONFIGURE_ARGS+= --with-skey
-.elif ${OPSYS} == "SunOS"
+.if ${OPSYS} == "SunOS"
CONFIGURE_ARGS+= --without-skey
.endif
diff -ru security/sudo.orig/options.mk security/sudo/options.mk
--- security/sudo.orig/options.mk 2004-11-26 19:43:03.000000000 +0100
+++ security/sudo/options.mk 2004-12-22 00:48:44.000000000 +0100
@@ -2,7 +2,10 @@
#
PKG_OPTIONS_VAR= PKG_OPTIONS.sudo
-PKG_SUPPORTED_OPTIONS= kerberos ldap PAM
+PKG_SUPPORTED_OPTIONS= kerberos ldap PAM skey
+.if ${OPSYS} == "NetBSD"
+PKG_DEFAULT_OPTIONS+= skey
+.endif
.include "../../mk/bsd.options.mk"
.if !empty(PKG_OPTIONS:Mkerberos)
@@ -25,3 +28,7 @@
DL_AUTO_VARS= yes
CONFIGURE_ARGS+= --with-pam
.endif
+
+.if !empty(PKG_OPTIONS:Mskey)
+CONFIGURE_ARGS+= --with-skey
+.endif
--GvXjxJ+pjyke8COw--
Responsible-Changed-From-To: pkg-manager->kim
Responsible-Changed-By: ben@netbsd.org
Responsible-Changed-When: Wed, 22 Dec 2004 00:16:39 +0000
Responsible-Changed-Why:
Assigned to package maintainer, kim.
Responsible-Changed-From-To: kim->jlam
Responsible-Changed-By: jlam@netbsd.org
Responsible-Changed-When: Wed, 22 Dec 2004 01:02:44 +0000
Responsible-Changed-Why:
I'll take responsibility... it's a package options change.
State-Changed-From-To: open->closed
State-Changed-By: jlam@netbsd.org
State-Changed-When: Wed, 22 Dec 2004 04:37:01 +0000
State-Changed-Why:
Patch applied with minor changes by me. Thanks for the PR!
From: "Johnny C. Lam" <jlam@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/28743 CVS commit: pkgsrc/security/sudo
Date: Wed, 22 Dec 2004 04:36:33 +0000 (UTC)
Module Name: pkgsrc
Committed By: jlam
Date: Wed Dec 22 04:36:33 UTC 2004
Modified Files:
pkgsrc/security/sudo: Makefile options.mk
Log Message:
Allow building sudo without S/Key support on NetBSD. Patch from
PR pkg/28743 by Jukka Salmi with minor changes by me.
To generate a diff of this commit:
cvs rdiff -r1.75 -r1.76 pkgsrc/security/sudo/Makefile
cvs rdiff -r1.5 -r1.6 pkgsrc/security/sudo/options.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.