NetBSD Problem Report #29135

From hiramatu@boreas.dti.ne.jp  Thu Jan 27 15:11:20 2005
Return-Path: <hiramatu@boreas.dti.ne.jp>
Received: from smtp8.dti.ne.jp (smtp8.dti.ne.jp [202.216.228.43])
	by narn.netbsd.org (Postfix) with ESMTP id D817863B844
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 27 Jan 2005 15:11:19 +0000 (UTC)
Message-Id: <20050127151533.4D17CAB22@orinoco.my.domain>
Date: Fri, 28 Jan 2005 00:15:33 +0900 (JST)
From: hiramatu@boreas.dti.ne.jp
Reply-To: hiramatu@boreas.dti.ne.jp
To: gnats-bugs@netbsd.org
Subject: x11/xorg-libs build failure on OpenBSD
X-Send-Pr-Version: 3.95

>Number:         29135
>Category:       pkg
>Synopsis:       x11/xorg-libs build failure on OpenBSD
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    xtraeme
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 27 15:12:00 +0000 2005
>Closed-Date:    Mon Jan 31 20:15:39 +0000 2005
>Last-Modified:  Mon Jan 31 20:15:39 +0000 2005
>Originator:     Hiramatsu Yoshifumi
>Release:        NetBSD 2.99.11
>Organization:

>Environment:


System: NetBSD orinoco.my.domain 2.99.11 NetBSD 2.99.11 (Orinoco) #3: Fri Dec 31 23:34:14 JST 2004 root@orinoco.my.domain:/usr/src/sys/arch/i386/compile/Orinoco i386
Architecture: i386
Machine: i386
>Description:
meta-pkgs/xorg/Makefile.common tries to create OPSYS specific configuration
file in this loop:

.  for F in ${SYSTEMS}
	@${MV} ${WRKSRC}/config/cf/${F}.cf \
		${WRKSRC}/config/cf/${F}.cf.in
.  endfor

SYSTEMS contains "DragonFly" but DragonFly.cf is created only on DragonFlyBSD,
so "mv DragonFly.cf DragonFly.cf.in" would fail when building on OpenBSD.

>How-To-Repeat:

>Fix:
Always create DragonFly.cf even if the platform isn't DragonFly?

diff -b -u -r1.16 Makefile.common
--- Makefile.common     25 Jan 2005 17:49:57 -0000      1.16
+++ Makefile.common     27 Jan 2005 14:44:19 -0000
@@ -211,9 +211,9 @@
        @${LN} -sf ${X11ROOT}/lib/X11/config/version.def ${WRKSRC}/config/cf
        @${LN} -sf ${X11ROOT}/lib/X11/config/date.def ${WRKSRC}/config/cf

-.if ${OPSYS} == "DragonFly"
+#.if ${OPSYS} == "DragonFly"
        @${CP} ../../x11/xorg-libs/files/DragonFly.cf ${WRKSRC}/config/cf/
-.endif
+#.endif

 .  for F in ${SYSTEMS}
        @${MV} ${WRKSRC}/config/cf/${F}.cf \
~

>Release-Note:

>Audit-Trail:
From: Juan RP <juan@xtraeme.nopcode.org>
To: gnats-bugs@netbsd.org
Cc: hiramatu@boreas.dti.ne.jp, gnats-admin@netbsd.org,
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/29135: x11/xorg-libs build failure on OpenBSD
Date: Thu, 27 Jan 2005 16:17:15 +0100

 --Signature=_Thu__27_Jan_2005_16_17_15_+0100_9ESbB6H3mVAMTV2r
 Content-Type: text/plain; charset=US-ASCII
 Content-Disposition: inline
 Content-Transfer-Encoding: 7bit

 On Thu, 27 Jan 2005 15:12:00 +0000 (UTC)
 hiramatu@boreas.dti.ne.jp wrote:

 > >Number:         29135
 > >Category:       pkg
 > >Synopsis:       x11/xorg-libs build failure on OpenBSD

 Hi Hiramatsu, can you try the following patch?

 Index: Makefile.common
 ===================================================================
 RCS file: /cvsroot/pkgsrc/meta-pkgs/xorg/Makefile.common,v
 retrieving revision 1.16
 diff -b -u -u -r1.16 Makefile.common
 --- Makefile.common     25 Jan 2005 17:49:57 -0000      1.16
 +++ Makefile.common     27 Jan 2005 15:15:46 -0000
 @@ -216,8 +216,10 @@
  .endif

  .  for F in ${SYSTEMS}
 +.    if exists(${WRKSRC}/config/cf/${F}.cf)
         @${MV} ${WRKSRC}/config/cf/${F}.cf \
                 ${WRKSRC}/config/cf/${F}.cf.in
 +.    endif
  .  endfor
  .  undef F





 --Signature=_Thu__27_Jan_2005_16_17_15_+0100_9ESbB6H3mVAMTV2r
 Content-Type: application/pgp-signature

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.0 (NetBSD)

 iD8DBQFB+QX+ypkLYVDran0RAsSEAJ9K3EeQv1bMJpXub5mg+iNR8eTRagCgiHyp
 K69btUFnn4VECDJuSXk5mcU=
 =WZuW
 -----END PGP SIGNATURE-----

 --Signature=_Thu__27_Jan_2005_16_17_15_+0100_9ESbB6H3mVAMTV2r--

Responsible-Changed-From-To: pkg-manager->xtraeme
Responsible-Changed-By: ben@netbsd.org
Responsible-Changed-When: Fri, 28 Jan 2005 00:03:13 +0000
Responsible-Changed-Why:
Assigned to package maintainer, xtraeme.


From: Hiramatsu Yoshifumi <hiramatu@boreas.dti.ne.jp>
To: Juan RP <juan@xtraeme.nopcode.org>
Cc: gnats-bugs@netbsd.org, gnats-admin@netbsd.org,
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/29135: x11/xorg-libs build failure on OpenBSD
Date: Fri, 28 Jan 2005 22:13:34 +0900

 Hello,

 I tried your patch but it didn't work because makefile expressions are
 evaluated before make targets are executed.

 At Thu, 27 Jan 2005 16:17:15 +0100,
 Juan RP <juan@xtraeme.nopcode.org> wrote:
 > Index: Makefile.common
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/meta-pkgs/xorg/Makefile.common,v
 > retrieving revision 1.16
 > diff -b -u -u -r1.16 Makefile.common
 > --- Makefile.common     25 Jan 2005 17:49:57 -0000      1.16
 > +++ Makefile.common     27 Jan 2005 15:15:46 -0000
 > @@ -216,8 +216,10 @@
 >  .endif
 >  
 >  .  for F in ${SYSTEMS}
 > +.    if exists(${WRKSRC}/config/cf/${F}.cf)
 >         @${MV} ${WRKSRC}/config/cf/${F}.cf \
 >                 ${WRKSRC}/config/cf/${F}.cf.in
 > +.    endif
 >  .  endfor
 >  .  undef F

 . if exists(${WRKSRC}/config/cf/${F}.cf)

 becomes always false because this line is evaluated before xorg sources are
 extracted.

 Why don't you use /bin/sh builtin test command instead?

 Index: Makefile.common
 ===================================================================
 RCS file: /cvsroot/pkgsrc/meta-pkgs/xorg/Makefile.common,v
 retrieving revision 1.16
 diff -b -u -r1.16 Makefile.common
 --- Makefile.common     25 Jan 2005 17:49:57 -0000      1.16
 +++ Makefile.common     28 Jan 2005 12:58:42 -0000
 @@ -216,8 +216,10 @@
  .endif

  .  for F in ${SYSTEMS}
 -       @${MV} ${WRKSRC}/config/cf/${F}.cf \
 -               ${WRKSRC}/config/cf/${F}.cf.in
 +       @if ${TEST} -f ${WRKSRC}/config/cf/${F}.cf; then \
 +       ${MV} ${WRKSRC}/config/cf/${F}.cf \
 +               ${WRKSRC}/config/cf/${F}.cf.in ; \
 +       fi
  .  endfor
  .  undef F

 -- 
 // Hiramatsu Yoshifumi
 // hiramatu@boreas.dti.ne.jp

State-Changed-From-To: open->closed
State-Changed-By: xtraeme@netbsd.org
State-Changed-When: Mon, 31 Jan 2005 20:15:39 +0000
State-Changed-Why:
Fixed, thanks.


>Unformatted:

Home	PR Database Search