NetBSD Problem Report #29170
From salo@Xtrmntr.org Mon Jan 31 11:13:07 2005
Return-Path: <salo@Xtrmntr.org>
Received: from otaku.Xtrmntr.org (sauna.silcnet.org [147.175.66.205])
by narn.netbsd.org (Postfix) with ESMTP id EEF4C63B849
for <gnats-bugs@gnats.netbsd.org>; Mon, 31 Jan 2005 11:13:06 +0000 (UTC)
Message-Id: <20050131111245.AE74D1D102@otaku.Xtrmntr.org>
Date: Mon, 31 Jan 2005 12:12:45 +0100 (CET)
From: Lubomir Sedlacik <salo@Xtrmntr.org>
Reply-To: salo@Xtrmntr.org
To: gnats-bugs@netbsd.org
Subject: -current tools cross-build fails on FreeBSD in lib/libc/gen/pw_scan.c
X-Send-Pr-Version: 3.95
>Number: 29170
>Category: toolchain
>Synopsis: -current tools cross-build fails on FreeBSD in lib/libc/gen/pw_scan.c
>Confidential: no
>Severity: critical
>Priority: medium
>Responsible: toolchain-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Jan 31 11:14:00 +0000 2005
>Closed-Date: Tue Feb 01 05:26:46 +0000 2005
>Last-Modified: Tue Feb 01 05:27:00 +0000 2005
>Originator: Lubomir Sedlacik
>Release: FreeBSD 4.11-RELEASE
>Organization:
>Environment:
Architecture: i386
Machine: i386
>Description:
cross-compilation of -current (as of Mon Jan 31 12:11:02 CET 2005) fails on
FreeBSD 4.11-RELEASE machine in tools/compat:
# compile compat/pw_scan.lo
cc -O -I. -I./include -I/www/src/NetBSD/tools/compat -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D__DBINTERFACE_PRIVATE -c -o pw_scan.lo.o /www/src/NetBSD/tools/compat/../../lib/libc/gen/pw_scan.c
/www/src/NetBSD/tools/compat/../../lib/libc/gen/pw_scan.c: In function `__nbcompat_pw_scan':
/www/src/NetBSD/tools/compat/../../lib/libc/gen/pw_scan.c:155: `LOGIN_NAME_MAX' undeclared (first use in this function)
/www/src/NetBSD/tools/compat/../../lib/libc/gen/pw_scan.c:155: (Each undeclared identifier is reported only once
/www/src/NetBSD/tools/compat/../../lib/libc/gen/pw_scan.c:155: for each function it appears in.)
/www/src/NetBSD/tools/compat/../../lib/libc/gen/pw_scan.c:200: warning: passing arg 1 of `gettime' from incompatible pointer type
/www/src/NetBSD/tools/compat/../../lib/libc/gen/pw_scan.c:204: warning: passing arg 1 of `gettime' from incompatible pointer type
*** Failed target: pw_scan.lo
*** Failed command: cc -O -I. -I./include -I/www/src/NetBSD/tools/compat -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D__DBINTERFACE_PRIVATE -c -o pw_scan.lo.o /www/src/NetBSD/tools/compat/../../lib/libc/gen/pw_scan.c
*** Error code 1
Stop.
nbmake: stopped in /www/src/NetBSD/tools/compat
*** Failed target: dependall
*** Failed command: cd /www/src/NetBSD/tools/compat; /www/src/tools.i386/bin/nbmake realall
*** Error code 1
Stop.
nbmake: stopped in /www/src/NetBSD/tools/compat
*** Failed target: dependall-compat
*** Failed command: _makedirtarget() { dir="$1"; shift; target="$1"; shift; case "${dir}" in /*) this="${dir}/"; real="${dir}" ;; .) this=""; real="/www/src/NetBSD/tools" ;; *) this="${dir}/"; real="/www/src/NetBSD/tools/${dir}" ;; esac; show=${this:-.}; echo "${target} ===> ${show%/}${1:+ (with: $@)}"; cd "${real}" && /www/src/tools.i386/bin/nbmake _THISDIR_="${this}" "$@" ${target}; }; _makedirtarget compat dependall
*** Error code 1
Stop.
nbmake: stopped in /www/src/NetBSD/tools
ERROR: Failed to make tools
*** BUILD ABORTED ***
>How-To-Repeat:
on FreeBSD:
./build.sh -m i386 tools
>Fix:
n/a
>Release-Note:
>Audit-Trail:
From: Lubomir Sedlacik <salo@Xtrmntr.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: toolchain/29170: -current tools cross-build fails on FreeBSD in lib/libc/gen/pw_scan.c
Date: Mon, 31 Jan 2005 12:34:07 +0100
--dMyqICaxQaaUjrCL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
proposed fix:
Index: compat_defs.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/src/tools/compat/compat_defs.h,v
retrieving revision 1.45
diff -u -r1.45 compat_defs.h
--- compat_defs.h 11 Dec 2004 09:34:08 -0000 1.45
+++ compat_defs.h 31 Jan 2005 11:30:20 -0000
@@ -448,6 +448,13 @@
#ifndef GID_MAX
#define GID_MAX UID_MAX
#endif
+#ifndef LOGIN_NAME_MAX
+# if defined(_POSIX_LOGIN_NAME_MAX)
+# define LOGIN_NAME_MAX _POSIX_LOGIN_NAME_MAX
+# else
+# define LOGIN_NAME_MAX 9
+# endif
+#endif
=20
#ifndef UQUAD_MAX
#define UQUAD_MAX ((u_quad_t)-1)
--=20
-- Lubomir Sedlacik <salo@{NetBSD,Xtrmntr,silcnet}.org> --
--dMyqICaxQaaUjrCL
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)
iD8DBQFB/heviwjDDlS8cmMRAlKMAKCGF31S4eyDFqv0gPAFhSsMGybGBgCfd3Zz
Kn0iMYYHeJwSq4TSAdHYRXo=
=LDLf
-----END PGP SIGNATURE-----
--dMyqICaxQaaUjrCL--
From: James Chacon <jmc@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: toolchain-manager@NetBSD.org, gnats-admin@NetBSD.org,
netbsd-bugs@NetBSD.org
Subject: Re: toolchain/29170: -current tools cross-build fails on FreeBSD in lib/libc/gen/pw_scan.c
Date: Mon, 31 Jan 2005 12:06:32 -0600
On Mon, Jan 31, 2005 at 11:35:02AM +0000, Lubomir Sedlacik wrote:
> The following reply was made to PR toolchain/29170; it has been noted by GNATS.
>
> From: Lubomir Sedlacik <salo@Xtrmntr.org>
> To: gnats-bugs@netbsd.org
> Cc:
> Subject: Re: toolchain/29170: -current tools cross-build fails on FreeBSD in lib/libc/gen/pw_scan.c
> Date: Mon, 31 Jan 2005 12:34:07 +0100
>
> --dMyqICaxQaaUjrCL
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> proposed fix:
>
> Index: compat_defs.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/src/tools/compat/compat_defs.h,v
> retrieving revision 1.45
> diff -u -r1.45 compat_defs.h
> --- compat_defs.h 11 Dec 2004 09:34:08 -0000 1.45
> +++ compat_defs.h 31 Jan 2005 11:30:20 -0000
> @@ -448,6 +448,13 @@
> #ifndef GID_MAX
> #define GID_MAX UID_MAX
> #endif
> +#ifndef LOGIN_NAME_MAX
> +# if defined(_POSIX_LOGIN_NAME_MAX)
> +# define LOGIN_NAME_MAX _POSIX_LOGIN_NAME_MAX
> +# else
> +# define LOGIN_NAME_MAX 9
> +# endif
> +#endif
> =20
> #ifndef UQUAD_MAX
> #define UQUAD_MAX ((u_quad_t)-1)
1. Can you make sure any attachments/patches are always sent in some form of
ascii only? Gnats ate part of this.
2. I noticed this on a solaris cross build as well and most definitly
we don't want to pick up any local definition of this so I'll fix it a
different way to always force the in-tree definition to be used.
James
State-Changed-From-To: open->closed
State-Changed-By: jmc@netbsd.org
State-Changed-When: Tue, 01 Feb 2005 05:26:46 +0000
State-Changed-Why:
Committed fix.
From: James Chacon <jmc@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/29170 CVS commit: src/tools/compat
Date: Tue, 1 Feb 2005 05:26:03 +0000 (UTC)
Module Name: src
Committed By: jmc
Date: Tue Feb 1 05:26:03 UTC 2005
Modified Files:
src/tools/compat: compat_pwd.h
Log Message:
Define LOGIN_NAME_MAX explicitly here and override any system provided one
since the compat tools need to use the NetBSD limits, not the local system
ones (and some systems don't provide this yet anyways). Fixes PR#29170
To generate a diff of this commit:
cvs rdiff -r1.3 -r1.4 src/tools/compat/compat_pwd.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.