NetBSD Problem Report #29701
From srp@low.tworoads.net Wed Mar 16 00:37:14 2005
Return-Path: <srp@low.tworoads.net>
Received: from high.tworoads.net (high.tworoads.net [216.173.217.59])
by narn.netbsd.org (Postfix) with ESMTP id 4018A63B117
for <gnats-bugs@gnats.NetBSD.org>; Wed, 16 Mar 2005 00:37:14 +0000 (UTC)
Message-Id: <200503160037.j2G0b8wD002644@low.tworoads.net>
Date: Tue, 15 Mar 2005 16:37:08 -0800 (PST)
From: srp@tworoads.net
Reply-To: srp@tworoads.net
To: gnats-bugs@netbsd.org
Cc: shattered@users.sourceforge.net
Subject: smartmontools 5.32 uses wrong units for SCSI timeout in os_netbsd.
X-Send-Pr-Version: 3.95
>Number: 29701
>Category: pkg
>Synopsis: smartmontools 5.32 uses wrong units for SCSI timeout in os_netbsd.c
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Mar 16 00:38:00 +0000 2005
>Closed-Date: Thu Mar 17 16:34:07 +0000 2005
>Last-Modified: Thu Mar 17 16:36:00 +0000 2005
>Originator: Scott Presnell
>Release: NetBSD 2.0
>Organization:
Self
>Environment:
System: NetBSD low.tworoads.net 2.0 NetBSD 2.0 (YUKON) #9: Thu Dec 16 12:12:01 PST 2004 srp@saar.tworoads.net:/usr/src/sys/arch/i386/compile/YUKON i386
Architecture: i386
Machine: i386
>Description:
smartctl version 5.32 Copyright (C) 2002-4 Bruce Allen
Home page is http://smartmontools.sourceforge.net/
The package smartmontools version 5.32 uses wrong units for SCSI timeout in os_netbsd.c
the base code uses the expectation of a timeout in seconds, but
ioctl(fd, SCIOCCOMMAND, &sc) in os_netbsd.c
is expecting a timeout in microseconds.
>How-To-Repeat:
Attempt "smartctl -a /dev/sd0d" from an installed smartmontools package
installation. Note SCSI timeout :-(
>Fix:
--- os_netbsd.c.orig 2005-03-15 16:27:56.000000000 -0800
+++ os_netbsd.c 2005-03-14 11:13:34.000000000 -0800
@@ -381,7 +381,7 @@
sc.databuf = iop->dxferp;
sc.datalen = iop->dxfer_len;
sc.senselen = iop->max_sense_len;
- sc.timeout = iop->timeout == 0 ? 60000 : iop->timeout; /* XXX */
+ sc.timeout = iop->timeout == 0 ? 60000 : (iop->timeout * 1000);/* XXX */
sc.flags =
(iop->dxfer_dir == DXFER_NONE ? SCCMD_READ : /* XXX */
(iop->dxfer_dir == DXFER_FROM_DEVICE ? SCCMD_READ : SCCMD_WRITE));
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: wiz@netbsd.org
State-Changed-When: Thu, 17 Mar 2005 16:34:07 +0000
State-Changed-Why:
Added to the package, thanks!
From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/29701 CVS commit: pkgsrc/sysutils/smartmontools
Date: Thu, 17 Mar 2005 16:33:23 +0000 (UTC)
Module Name: pkgsrc
Committed By: wiz
Date: Thu Mar 17 16:33:23 UTC 2005
Modified Files:
pkgsrc/sysutils/smartmontools: Makefile distinfo
Added Files:
pkgsrc/sysutils/smartmontools/patches: patch-ab
Log Message:
Add patch from Scott Presnell in PR 29701:
The package smartmontools version 5.32 uses wrong units for SCSI
timeout in os_netbsd.c.
Double checked by thorpej.
Bump PKGREVISION.
To generate a diff of this commit:
cvs rdiff -r1.4 -r1.5 pkgsrc/sysutils/smartmontools/Makefile
cvs rdiff -r1.3 -r1.4 pkgsrc/sysutils/smartmontools/distinfo
cvs rdiff -r0 -r1.1 pkgsrc/sysutils/smartmontools/patches/patch-ab
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.