NetBSD Problem Report #29894

From roland@roland-illig.de  Tue Apr  5 16:02:06 2005
Return-Path: <roland@roland-illig.de>
Received: from baccf5ee.roland-illig.de (d042069.adsl.hansenet.de [80.171.42.69])
	by narn.netbsd.org (Postfix) with ESMTP id 8000F63B121
	for <gnats-bugs@gnats.netbsd.org>; Tue,  5 Apr 2005 16:02:01 +0000 (UTC)
Message-Id: <20050405160615.28AE6F418@baccf5ee.roland-illig.de>
Date: Tue,  5 Apr 2005 18:06:15 +0200 (CEST)
From: roland.illig@gmx.de
Reply-To: roland.illig@gmx.de
To: gnats-bugs@netbsd.org
Subject: pkg_create does not enough error checking
X-Send-Pr-Version: 3.95

>Number:         29894
>Category:       pkg
>Synopsis:       [*-*-*] pkg_create does not enough error checking
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    joerg
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 05 16:03:00 +0000 2005
>Closed-Date:    Sun Oct 05 08:01:30 +0000 2008
>Last-Modified:  Sun Oct 05 08:01:30 +0000 2008
>Originator:     roland.illig@gmx.de
>Release:        All
>Organization:

>Environment:


System: NetBSD baccf5ee.roland-illig.de 2.99.15 NetBSD 2.99.15 (GENERIC) #0: Wed Feb 9 20:19:30 CET 2005 build@baccf5ee.roland-illig.de:/home/build/objroot/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:

when creating the +CONTENTS file for a package, pkg_create calls the
fprintf() function various times without checking if the function
succeeded. This can lead to unnoticed package corruption. In my case,
editors/abiword could not be packaged, and the "make package" process
terminated without giving an error message.

>How-To-Repeat:

>Fix:

Add _complete_ error checking to the pkgtools/pkg_install program.
Enable lint(1) for it.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->joerg
Responsible-Changed-By: wiz@netbsd.org
Responsible-Changed-When: Sat, 07 Oct 2006 19:06:49 +0000
Responsible-Changed-Why:
pkg_install issue.


State-Changed-From-To: open->suspended
State-Changed-By: joerg@netbsd.org
State-Changed-When: Sun, 08 Oct 2006 12:00:59 +0000
State-Changed-Why:
Won't be fixed in the old incarnation.


From: Ben Collver <collver@peak.org>
To: pkg-bug-handler@NetBSD.org
Cc: 
Subject: Re: pkg/29894 ([*-*-*] pkg_create does not enough error checking)
Date: Sun, 8 Oct 2006 06:00:30 -0700

 On Sun, Oct 08, 2006 at 12:01:00PM +0000, joerg@NetBSD.org wrote:
 > Synopsis: [*-*-*] pkg_create does not enough error checking
 > 
 > State-Changed-From-To: open->suspended
 > State-Changed-By: joerg@netbsd.org
 > State-Changed-When: Sun, 08 Oct 2006 12:00:59 +0000
 > State-Changed-Why:
 > Won't be fixed in the old incarnation.


 Does this mean that a new incarnation is in the works?  How soon?

 Ben

From: Roland Illig <rillig@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/29894 ([*-*-*] pkg_create does not enough error checking)
Date: Sun, 08 Oct 2006 21:52:22 +0200

 Ben Collver wrote:
 >  On Sun, Oct 08, 2006 at 12:01:00PM +0000, joerg@NetBSD.org wrote:
 >  > Won't be fixed in the old incarnation.
 >  
 >  
 >  Does this mean that a new incarnation is in the works?  How soon?

 http://netbsd-soc.sourceforge.net/ (currently unreachable)

 Roland

State-Changed-From-To: suspended->feedback
State-Changed-By: joerg@NetBSD.org
State-Changed-When: Wed, 21 May 2008 21:53:46 +0000
State-Changed-Why:
I think pkg_create is no longer affected by such issues,
pkg_add and pkg_info are a lot stricter with the pkg_install-renovation
branch as well. pkg_admin has seen a lot of changes too.
Does this still apply?


From: Roland Illig <roland.illig@gmx.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/29894 ([*-*-*] pkg_create does not enough error checking)
Date: Thu, 22 May 2008 10:34:13 +0200

 joerg@NetBSD.org schrieb:
 > Does this still apply?

 I cannot tell since I'm not using pkgsrc at the moment. But since you 
 are well aware of the problem, you can close this PR.

 Roland

State-Changed-From-To: feedback->closed
State-Changed-By: rillig@NetBSD.org
State-Changed-When: Sun, 05 Oct 2008 08:01:30 +0000
State-Changed-Why:
The original reporter believes this to be fixed.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.