NetBSD Problem Report #30035

From plunky@rya-online.net  Fri Apr 22 19:42:59 2005
Return-Path: <plunky@rya-online.net>
Received: from post.rya-online.net (post.rya-online.net [195.26.225.220])
	by narn.netbsd.org (Postfix) with ESMTP id 96B2B63B11A
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 22 Apr 2005 19:42:58 +0000 (UTC)
Message-Id: <1114162534.331048.9575.nullmailer@galant.ukfsn.org>
Date: Fri, 22 Apr 2005 10:35:34 +0100
From: Iain Hibbert <plunky@rya-online.net>
Reply-To: plunky@rya-online.net
To: gnats-bugs@netbsd.org
Subject: net/ppp-lzs update (patch included)
X-Send-Pr-Version: 3.95

>Number:         30035
>Category:       pkg
>Synopsis:       net/ppp-lzs is not compiling
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 22 19:43:00 +0000 2005
>Closed-Date:    Fri Apr 22 21:26:03 +0000 2005
>Last-Modified:  Fri Apr 22 21:31:00 +0000 2005
>Originator:     Iain Hibbert
>Release:        NetBSD 2.0
>Organization:
none
>Environment:
System: NetBSD galant 2.0 NetBSD 2.0 (GALANT) #12: Tue Mar 15 22:08:38 GMT 2005 plunky@galant:/home/plunky/src/sys/arch/i386/compile/GALANT i386
Architecture: i386
Machine: i386
>Description:
	net/ppp-lzs is failing to build.  The problem seems to be in the wrapper,
	for cc in that it is filtering out an -I/usr/src/lib/libpcap from the
	C options (maybe because of absolute path?).  It needed this to get the
	pcap-int.h file which is only found there.
>How-To-Repeat:
	(cd net/ppp-lzs && make)
>Fix:
        Patch below changes the package Makefile to copy that file to the directory
	in question, along with all the other files it copies

	Patches also to fix some pkglint complaints regarding trailing whitespace
	and non-ordered PLIST file

--- Makefile.orig	2005-04-22 10:14:33.000000000 +0100
+++ Makefile	2005-04-22 10:15:27.000000000 +0100
@@ -2,4 +2,5 @@

 DISTNAME=	ppp-lzs-1.2
+PKGREVISION=	1
 CATEGORIES=	net
 MASTER_SITES=	http://homepages.rya-online.net/plunky/
@@ -31,4 +32,5 @@
 	@${CP} ${NETBSDSRCDIR}/usr.sbin/pppd/pppd/*.[ch8] ${WRKSRC}/pppd
 	@${CP} ${NETBSDSRCDIR}/usr.sbin/pppd/pppd/Makefile ${WRKSRC}/pppd
+	@${CP} ${NETBSDSRCDIR}/lib/libpcap/pcap-int.h ${WRKSRC}/pppd

 do-patch:
--- DESCR.orig	2005-04-22 10:15:52.000000000 +0100
+++ DESCR	2005-04-22 10:16:01.000000000 +0100
@@ -1,6 +1,6 @@
 This is a NetBSD decompressor for PPP compatible with the Stac LZS
 scheme as described in rfc1974.  The algorithm is apparently covered
-by patents held by Hifn in the USA and Europe though it was written 
+by patents held by Hifn in the USA and Europe though it was written
 independently with no help from Hifn or anybody associated with them,
 and with no reference to the patents.  You might want to consider this
 'example' code only if that makes you feel better.
--- PLIST.orig	2005-04-22 10:16:08.000000000 +0100
+++ PLIST	2005-04-22 10:16:49.000000000 +0100
@@ -2,3 +1,0 @@
-sbin/pppd
-man/man8/pppd.8
-man/cat8/pppd.0
@@ -5,0 +3,3 @@
+man/cat8/pppd.0
+man/man8/pppd.8
+sbin/pppd

>Release-Note:

>Audit-Trail:
From: "Jeremy C. Reed" <reed@reedmedia.net>
To: gnats-bugs@netbsd.org
Cc: plunky@rya-online.net
Subject: Re: pkg/30035: net/ppp-lzs update (patch included)
Date: Fri, 22 Apr 2005 12:54:54 -0700 (PDT)

 On Fri, 22 Apr 2005, Iain Hibbert wrote:

 > +PKGREVISION=	1

 This is not needed, unless some change in resulting package. But if
 couldn't package in first place, no PKGREVISION needed.

 > +	@${CP} ${NETBSDSRCDIR}/lib/libpcap/pcap-int.h ${WRKSRC}/pppd

 I think the problem was started because now the USE_BUILDLINK3
 buildlinking and wrapping is done by default.

 I'll wait to commit, I think wiz is doing it.

 By the way, does this always use or need the native libpcap? I guess it
 doesn't matter since this is using NETBSDSRCDIR anyways.

  Jeremy C. Reed

  	  	 	 Media Relations and Publishing Services
 	  	 	 http://www.reedmedia.net/




From: Thomas Klausner <wiz@NetBSD.org>
To: Iain Hibbert <plunky@rya-online.net>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/30035: net/ppp-lzs update (patch included)
Date: Fri, 22 Apr 2005 22:15:43 +0200

 On Fri, Apr 22, 2005 at 07:43:00PM +0000, Iain Hibbert wrote:
 > 	net/ppp-lzs is failing to build.  The problem seems to be in the wrapper,
 > 	for cc in that it is filtering out an -I/usr/src/lib/libpcap from the
 > 	C options (maybe because of absolute path?).  It needed this to get the
 > 	pcap-int.h file which is only found there.

 You can tell buildlink to pass through paths with the BUILDLINK_PASSTHRU_DIRS
 variable -- take a look at lang/guile14/buildlink3.mk. Please provide a patch
 that uses this instead of copying files around.

 Thanks,
  Thomas

From: Iain Hibbert <plunky@rya-online.net>
To: Thomas Klausner <wiz@netbsd.org>
Cc: "Jeremy C. Reed" <reed@reedmedia.net>, gnats-bugs@netbsd.org
Subject: Re: pkg/30035: net/ppp-lzs update (patch included)
Date: Fri, 22 Apr 2005 21:44:54 +0100 (BST)

 On Fri, 22 Apr 2005, Jeremy C. Reed wrote:

 > On Fri, 22 Apr 2005, Iain Hibbert wrote:
 >
 >> +PKGREVISION=	1
 >
 > This is not needed, unless some change in resulting package. But if
 > couldn't package in first place, no PKGREVISION needed.

 Ok, scrap that bit..

 > By the way, does this always use or need the native libpcap? I guess it
 > doesn't matter since this is using NETBSDSRCDIR anyways.

 thats much what I thought - its copying files from NETBSDSRCDIR and
 in fact is using the native pppd which uses the native libpcap in any 
 case.  I might look at the pkgsrc version of pppd now somebody has added 
 it in, but I'm working on something else right now.

 However, this patch for Makefile should be more to your liking (along with 
 the PLIST and DESCR patches originally sent), Thomas?

 --- Makefile.orig	2005-04-22 10:14:33.000000000 +0100
 +++ Makefile	2005-04-22 21:33:50.000000000 +0100
 @@ -17,6 +17,8 @@
   MAKE_ENV+=	S="${NETBSDSRCDIR}/sys"
   MESSAGE_SUBST+= PREFIX="${PREFIX}"

 +BUILDLINK_PASSTHRU_DIRS=	${NETBSDSRCDIR}/lib/libpcap
 +
   pre-extract:
   .if !exists(${NETBSDSRCDIR}/usr.sbin/pppd/Makefile)
   	@${ECHO} "This package requires the NetBSD source sets to be installed in"

State-Changed-From-To: open->closed
State-Changed-By: wiz@netbsd.org
State-Changed-When: Fri, 22 Apr 2005 21:26:03 +0000
State-Changed-Why:
Committed the patches -- thanks!


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/30035 CVS commit: pkgsrc/net/ppp-lzs
Date: Fri, 22 Apr 2005 21:25:45 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Fri Apr 22 21:25:45 UTC 2005

 Modified Files:
 	pkgsrc/net/ppp-lzs: Makefile

 Log Message:
 Add BUILDLINK_PASSTHRU_DIRS to make this build again.
 From Iain Hibbert in PR 30035.


 To generate a diff of this commit:
 cvs rdiff -r1.2 -r1.3 pkgsrc/net/ppp-lzs/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:
                 pkgsrc as of 18 April 2005

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.