NetBSD Problem Report #30154

From yamt@mwd.biglobe.ne.jp  Fri May  6 14:14:55 2005
Return-Path: <yamt@mwd.biglobe.ne.jp>
Received: from yamt.dyndns.org (FLA1Abz230.kng.mesh.ad.jp [218.227.188.230])
	by narn.netbsd.org (Postfix) with ESMTP id 614FC63B116
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  6 May 2005 14:14:55 +0000 (UTC)
Message-Id: <1115388886.860056.7609.nullmailer@yamt.dyndns.org>
Date: Fri, 06 May 2005 23:14:46 +0900
From: yamt@mwd.biglobe.ne.jp
Reply-To: yamt@mwd.biglobe.ne.jp
To: gnats-bugs@netbsd.org
Subject: tcp_close locking botch
X-Send-Pr-Version: 3.95

>Number:         30154
>Category:       kern
>Synopsis:       tcp_close locking botch
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    christos
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 06 14:15:00 +0000 2005
>Closed-Date:    Mon Sep 12 13:24:25 +0000 2005
>Last-Modified:  Mon Sep 12 13:24:25 +0000 2005
>Originator:     YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
>Release:        NetBSD 3.99.3
>Organization:

>Environment:


System: NetBSD kaeru 3.99.3 NetBSD 3.99.3 (build.kaeru.xen) #78: Wed May 4 23:21:47 JST 2005 takashi@kaeru:/home/takashi/work/kernel/build.kaeru.xen i386
Architecture: i386
Machine: i386
>Description:
	tcp_close can be called from interrupt context.
	however, it isn't safe.

	eg. tcp_input -> tcp_close -> in_pcbdetach
	    -> sofree -> chgsbsize -> uid_find
>How-To-Repeat:
	code inspection.
>Fix:


>Release-Note:

>Audit-Trail:
From: "Alexey G. Khramkov" <agkhram@mercdev.com>
To: gnats-bugs@netbsd.org
Cc: kern-bug-people@netbsd.org, gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org
Subject: Re: kern/30154: tcp_close locking botch
Date: Sat, 07 May 2005 15:17:05 +0500

 yamt@mwd.biglobe.ne.jp writes:

 >>Number:         30154
 >>Category:       kern
 >>Synopsis:       tcp_close locking botch
 >>Confidential:   no
 >>Severity:       serious
 >>Priority:       medium
 >>Responsible:    kern-bug-people
 >>State:          open
 >>Class:          sw-bug
 >>Submitter-Id:   net
 >>Arrival-Date:   Fri May 06 14:15:00 +0000 2005
 >>Originator:     YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
 >>Release:        NetBSD 3.99.3
 >>Organization:
 >
 >>Environment:
 > 	
 > 	
 > System: NetBSD kaeru 3.99.3 NetBSD 3.99.3 (build.kaeru.xen) #78: Wed May 4 23:21:47 JST 2005 takashi@kaeru:/home/takashi/work/kernel/build.kaeru.xen i386

 My system is GENERIC.MP, CVSed May 3 or 4.

 > Architecture: i386
 > Machine: i386
 >>Description:
 > 	tcp_close can be called from interrupt context.
 > 	however, it isn't safe.
 >
 > 	eg. tcp_input -> tcp_close -> in_pcbdetach
 > 	    -> sofree -> chgsbsize -> uid_find
 >>How-To-Repeat:
 > 	code inspection.

 Router, ftp, web, nat server.

 Just wait from 30 min till 2 days uptime. No panic, just hangs.
 It needs hard reset.

 Excerpt from ddb:
 simple_lock: locking against myself
 lock:0xc07ff628 currently at kern_resource.c:907 on CPU 1
 last locked: kern_resource.c:904
 last unlocked: kern_resource.c:907

 and backtrace is the same as mentioned above.

 >>Fix:
 > 	
 >
 >>Unformatted:
 >  	
 >  	
 >
 >

 -- 
 = Alexey G. Khramkov (agkhram) @ Infotech <agkhram{at}mercdev{dot}com> =
 = GPG fingerprint : 944D 0C8B 343B 6C8D 50A1  061A E2DA 3E11 7765 6B47 =

Responsible-Changed-From-To: kern-bug-people->christos
Responsible-Changed-By: christos@netbsd.org
Responsible-Changed-When: Sat, 07 May 2005 12:10:55 -0400
Responsible-Changed-Why:
mine


From: Christos Zoulas <christos@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/30154 CVS commit: src/sys
Date: Sat,  7 May 2005 17:42:09 +0000 (UTC)

 Module Name:	src
 Committed By:	christos
 Date:		Sat May  7 17:42:09 UTC 2005

 Modified Files:
 	src/sys/kern: kern_resource.c uipc_socket.c uipc_socket2.c
 	    uipc_usrreq.c vfs_lockf.c
 	src/sys/netinet: in_pcb.c tcp_usrreq.c
 	src/sys/netipsec: ipsec_osdep.h
 	src/sys/sys: resourcevar.h socketvar.h

 Log Message:
 PR/30154: YAMAMOTO Takashi: tcp_close locking botch
 chgsbsize() as mentioned in the PR can be called from an interrupt context
 via tcp_close(). Avoid calling uid_find() in chgsbsize().
 - Instead of storing so_uid in struct socketvar, store *so_uidinfo
 - Add a simple lock to struct uidinfo.


 To generate a diff of this commit:
 cvs rdiff -r1.93 -r1.94 src/sys/kern/kern_resource.c
 cvs rdiff -r1.109 -r1.110 src/sys/kern/uipc_socket.c
 cvs rdiff -r1.66 -r1.67 src/sys/kern/uipc_socket2.c
 cvs rdiff -r1.80 -r1.81 src/sys/kern/uipc_usrreq.c
 cvs rdiff -r1.39 -r1.40 src/sys/kern/vfs_lockf.c
 cvs rdiff -r1.98 -r1.99 src/sys/netinet/in_pcb.c
 cvs rdiff -r1.102 -r1.103 src/sys/netinet/tcp_usrreq.c
 cvs rdiff -r1.11 -r1.12 src/sys/netipsec/ipsec_osdep.h
 cvs rdiff -r1.25 -r1.26 src/sys/sys/resourcevar.h
 cvs rdiff -r1.81 -r1.82 src/sys/sys/socketvar.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Christos Zoulas <christos@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/30154 CVS commit: src/sys/netinet6
Date: Sat,  7 May 2005 17:44:11 +0000 (UTC)

 Module Name:	src
 Committed By:	christos
 Date:		Sat May  7 17:44:11 UTC 2005

 Modified Files:
 	src/sys/netinet6: ipsec.c

 Log Message:
 PR/30154: YAMAMOTO Takashi: tcp_close locking botch
 One more so_uid -> so_uidinfo change.


 To generate a diff of this commit:
 cvs rdiff -r1.101 -r1.102 src/sys/netinet6/ipsec.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: christos@netbsd.org
State-Changed-When: Sat, 07 May 2005 13:47:21 -0400
State-Changed-Why:
I fixed it by passing struct uidinfo directly to chgsbsize()


From: Markus W Kilbinger <mk@kilbi.de>
To: gnats-bugs@netbsd.org
Cc: christos@netbsd.org, gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org
Subject: Re: PR/30154 CVS commit: src/sys/netinet6
Date: Sat, 7 May 2005 20:43:35 +0200

 >>>>> "Christos" == Christos Zoulas <christos@netbsd.org> writes:

     Christos>  Modified Files:
     Christos>  	src/sys/netinet6: ipsec.c

     Christos>  Log Message: PR/30154: YAMAMOTO Takashi: tcp_close
     Christos>  locking botch One more so_uid -> so_uidinfo change.

 Is this

   /usr/toolchain-i386/bin/i386--netbsdelf-gcc -ffreestanding -pipe -march=athlon-mp -O2 -Werror -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wno-sign-compare -fno-zero-initialized-in-bss -Di386 -I. -I../../../../arch -I../../../.. -nostdinc -DDUMMY_NOPS -DUCONSOLE -DNMBCLUSTERS=8192 -DLKM -DUFS_DIRHASH -DDIAGNOSTIC -DIPSEC_NAT_T -DMAXUSERS=32 -D_KERNEL -D_KERNEL_OPT -I../../../../dist/pf -I../../../../dist/ipf -c ../../../../dist/pf/net/pf.c
   ../../../../dist/pf/net/pf.c: In function `pf_socket_lookup':
   ../../../../dist/pf/net/pf.c:2421: error: structure has no member named `so_uid'
   ../../../../dist/pf/net/pf.c:2426: error: structure has no member named `so_uid'

   *** Failed target:  pf.o

 another instance to apply this change?

 Markus.

From: christos@zoulas.com (Christos Zoulas)
To: mk@kilbi.de, gnats-bugs@netbsd.org
Cc: gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: PR/30154 CVS commit: src/sys/netinet6
Date: Sat, 7 May 2005 15:53:11 -0400

 On May 7,  8:43pm, mk@kilbi.de (Markus W Kilbinger) wrote:
 -- Subject: Re: PR/30154 CVS commit: src/sys/netinet6


 Yes, thanks! I will fix it.

 christos

 | Is this
 | 
 |   /usr/toolchain-i386/bin/i386--netbsdelf-gcc -ffreestanding -pipe -march=athlon-mp -O2 -Werror -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wno-sign-compare -fno-zero-initialized-in-bss -Di386 -I. -I../../../../arch -I../../../.. -nostdinc -DDUMMY_NOPS -DUCONSOLE -DNMBCLUSTERS=8192 -DLKM -DUFS_DIRHASH -DDIAGNOSTIC -DIPSEC_NAT_T -DMAXUSERS=32 -D_KERNEL -D_KERNEL_OPT -I../../../../dist/pf -I../../../../dist/ipf -c ../../../../dist/pf/net/pf.c
 |   ../../../../dist/pf/net/pf.c: In function `pf_socket_lookup':
 |   ../../../../dist/pf/net/pf.c:2421: error: structure has no member named `so_uid'
 |   ../../../../dist/pf/net/pf.c:2426: error: structure has no member named `so_uid'
 |   
 |   *** Failed target:  pf.o
 | 
 | another instance to apply this change?
 | 
 | Markus.
 -- End of excerpt from Markus W Kilbinger


State-Changed-From-To: feedback->closed
State-Changed-By: christos@netbsd.org
State-Changed-When: Mon, 12 Sep 2005 09:24:25 -0400
State-Changed-Why:
Reported verified that this has been fixed.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.