NetBSD Problem Report #30240

From sschroev@science.uva.nl  Mon May 16 10:05:59 2005
Return-Path: <sschroev@science.uva.nl>
Received: from smtp.science.uva.nl (smtp.science.uva.nl [146.50.4.84])
	by narn.netbsd.org (Postfix) with ESMTP id C99FC63B116
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 16 May 2005 10:05:57 +0000 (UTC)
Message-Id: <20050516100550.GA26602@ow129.science.uva.nl>
Date: Mon, 16 May 2005 12:05:50 +0200
From: Stephan Schroevers <sschroev@science.uva.nl>
Reply-To: Stephan Schroevers <sschroev@science.uva.nl>
To: gnats-bugs@netbsd.org
Subject: Syntax error in Makefile of print/teTeX-share
X-Send-Pr-Version: 3.95

>Number:         30240
>Category:       pkg
>Synopsis:       Syntax error in Makefile of print/teTeX-share
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    abs
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 16 10:06:00 +0000 2005
>Closed-Date:    Tue May 17 18:02:41 +0000 2005
>Last-Modified:  Tue May 17 18:54:02 +0000 2005
>Originator:     Stephan Schroevers
>Release:        NetBSD 2.0.2
>Organization:
	<organization of PR author (multiple lines)>
>Environment:
System: NetBSD disposition 2.0.2 NetBSD 2.0.2 (GENERIC) #0: Wed Mar 23 01:40:44 UTC 2005 builds@works.netbsd.org:/home/builds/ab/netbsd-2-0-2-RELEASE/sparc64/200503220140Z-obj/home/builds/ab/netbsd-2-0-2-RELEASE/src/sys/arch/sparc64/compile/GENERIC sparc64
Architecture: sparc64
Machine: sparc64
>Description:
When calling make with any parameter for print/teTeX-share:

  [stephan@disposition][/usr/pkgsrc/print/teTeX-share]$ make
  make: "/usr/pkgsrc/print/teTeX-share/Makefile" line 30: Malformed conditional (!empty(EXTRACT_USING:Mgtar))
  make: "/usr/pkgsrc/print/teTeX-share/Makefile" line 34: if-less else
  make: "/usr/pkgsrc/print/teTeX-share/Makefile" line 34: Need an operator
  make: "/usr/pkgsrc/print/teTeX-share/Makefile" line 38: if-less endif
  make: "/usr/pkgsrc/print/teTeX-share/Makefile" line 38: Need an operator
  make: Fatal errors encountered -- cannot continue

  make: stopped in /usr/pkgsrc/print/teTeX-share
>How-To-Repeat:
$ cd /usr/pkgsrc/print/teTeX-share
$ make
>Fix:

>Release-Note:

>Audit-Trail:
From: Roland Illig <rillig@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/30240 CVS commit: pkgsrc/print/teTeX-share
Date: Mon, 16 May 2005 10:38:53 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	rillig
 Date:		Mon May 16 10:38:53 UTC 2005

 Modified Files:
 	pkgsrc/print/teTeX-share: Makefile

 Log Message:
 Included bsd.prefs.mk to work around an undefined variable (EXTRACT_USING)
 in the rest of the Makefile. Fixes PR 30240.


 To generate a diff of this commit:
 cvs rdiff -r1.28 -r1.29 pkgsrc/print/teTeX-share/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: rillig@netbsd.org
State-Changed-When: Mon, 16 May 2005 10:39:31 +0000
State-Changed-Why:
I just fixed it.


From: Stephan Schroevers <sschroev@science.uva.nl>
To: rillig@netbsd.org
Cc: pkgsrc-bugs@netbsd.org
Subject: Re: pkg/30240
Date: Tue, 17 May 2005 00:28:28 +0200

 I updated pkgsrc and this indeed solves the problem for a regular `make`, but
 it still bugs pkg_chk:

 [stephan@disposition][/usr/pkgsrc]$ pkg_chk -is
 make: "/usr/pkgsrc/print/teTeX-sharesrc/Makefile" line 25: Malformed conditional (!empty(EXTRACT_USING:Mgtar))
 make: "/usr/pkgsrc/print/teTeX-sharesrc/Makefile" line 27: if-less else
 make: "/usr/pkgsrc/print/teTeX-sharesrc/Makefile" line 27: Need an operator
 make: "/usr/pkgsrc/print/teTeX-sharesrc/Makefile" line 29: if-less endif
 make: "/usr/pkgsrc/print/teTeX-sharesrc/Makefile" line 29: Need an operator
 make: Fatal errors encountered -- cannot continue
 eval:  make: stopped in /usr/pkgsrc/print/teTeX-sharesrc: not found

 Kind of odd...
 Should I file a new bug, or can you reopen the current report / fix it?

 On Mon, 16 May 2005 at 10:39:32 +0000, rillig@netbsd.org wrote:
 > Synopsis: Syntax error in Makefile of print/teTeX-share
 > 
 > State-Changed-From-To: open->closed
 > State-Changed-By: rillig@netbsd.org
 > State-Changed-When: Mon, 16 May 2005 10:39:31 +0000
 > State-Changed-Why:
 > I just fixed it.
 > 
 > 
 > 

State-Changed-From-To: closed->open
State-Changed-By: rillig@netbsd.org
State-Changed-When: Tue, 17 May 2005 16:04:45 +0000
State-Changed-Why:
There are still programs from pkgsrc that have problems.


Responsible-Changed-From-To: pkg-manager->abs
Responsible-Changed-By: rillig@netbsd.org
Responsible-Changed-When: Tue, 17 May 2005 16:07:17 +0000
Responsible-Changed-Why:
abs is the maintainer of pkg_chk, which uses the pkgsrc infrastructure
in an unintended way (see BSD_PKG_MK).


State-Changed-From-To: open->feedback
State-Changed-By: abs@netbsd.org
State-Changed-When: Tue, 17 May 2005 17:27:40 +0000
State-Changed-Why:
pkg_chk sets BSD_PKG_MK when parsing mk.conf to extract PKGSRCDIR
and PKG_DBDIR only. It does not set it when parsing any package
Makefiles.
I'm not seeing this error with teTeX-sharesrc installed when running
pkg_chk-1.57. Can you confirm what pkg_chk version you are using?


State-Changed-From-To: feedback->closed
State-Changed-By: abs@netbsd.org
State-Changed-When: Tue, 17 May 2005 18:02:41 +0000
State-Changed-Why:
Submitted confirmed all works after print/teTeX-sharesrc/Makefile update


From: Stephan Schroevers <sschroev@science.uva.nl>
To: abs@netbsd.org
Cc: pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, rillig@netbsd.org
Subject: Re: pkg/30240
Date: Tue, 17 May 2005 19:56:25 +0200

 I was using the latest version (1.57). I did another CVS update and now all
 seems to work fine.
 When I look at the cvs log, print/teTeX-sharesrc/Makefile has been updated
 twice (at the last cvs update and the one before that). I guess it didn't
 quite solve the problem the first time.

 So this case is closed as far as I'm concerned.
 (I wish I would have been more communicative today, but since my NetBSD box at
 home was offline, it was not possible to `cvs update -dP` earier.)

 On Tue, 17 May 2005 at 17:27:41 +0000, abs@netbsd.org wrote:
 > Synopsis: Syntax error in Makefile of print/teTeX-share
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: abs@netbsd.org
 > State-Changed-When: Tue, 17 May 2005 17:27:40 +0000
 > State-Changed-Why:
 > pkg_chk sets BSD_PKG_MK when parsing mk.conf to extract PKGSRCDIR
 > and PKG_DBDIR only. It does not set it when parsing any package
 > Makefiles.
 > I'm not seeing this error with teTeX-sharesrc installed when running
 > pkg_chk-1.57. Can you confirm what pkg_chk version you are using?
 > 
 > 
 > 

From: David Brownlee <abs@NetBSD.org>
To: Stephan Schroevers <sschroev@science.uva.nl>
Cc: pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, rillig@netbsd.org
Subject: Re: pkg/30240
Date: Tue, 17 May 2005 19:03:20 +0100 (BST)

  	Not a problem - just glad everything was fixed for you.
  	(Doubly glad it wasn't pkg_chk, and that someone else was able to
  	fix things so quickly :)

 On Tue, 17 May 2005, Stephan Schroevers wrote:

 > I was using the latest version (1.57). I did another CVS update and now all
 > seems to work fine.
 > When I look at the cvs log, print/teTeX-sharesrc/Makefile has been updated
 > twice (at the last cvs update and the one before that). I guess it didn't
 > quite solve the problem the first time.
 >
 > So this case is closed as far as I'm concerned.
 > (I wish I would have been more communicative today, but since my NetBSD box at
 > home was offline, it was not possible to `cvs update -dP` earier.)
 >
 > On Tue, 17 May 2005 at 17:27:41 +0000, abs@netbsd.org wrote:
 >> Synopsis: Syntax error in Makefile of print/teTeX-share
 >>
 >> State-Changed-From-To: open->feedback
 >> State-Changed-By: abs@netbsd.org
 >> State-Changed-When: Tue, 17 May 2005 17:27:40 +0000
 >> State-Changed-Why:
 >> pkg_chk sets BSD_PKG_MK when parsing mk.conf to extract PKGSRCDIR
 >> and PKG_DBDIR only. It does not set it when parsing any package
 >> Makefiles.
 >> I'm not seeing this error with teTeX-sharesrc installed when running
 >> pkg_chk-1.57. Can you confirm what pkg_chk version you are using?
 >>
 >>
 >>
 >

 -- 
  		David/absolute       -- www.NetBSD.org: No hype required --

>Unformatted:

Home	PR Database Search