NetBSD Problem Report #30438

From www@netbsd.org  Mon Jun  6 02:43:43 2005
Return-Path: <www@netbsd.org>
Received: by narn.netbsd.org (Postfix, from userid 31301)
	id 546C363B116; Mon,  6 Jun 2005 02:43:43 +0000 (UTC)
Message-Id: <20050606024343.546C363B116@narn.netbsd.org>
Date: Mon,  6 Jun 2005 02:43:43 +0000 (UTC)
From: b1ff@fr33.b33r.net
Reply-To: b1ff@fr33.b33r.net
To: gnats-bugs@netbsd.org
Subject: cdrdao not writing
X-Send-Pr-Version: www-1.0

>Number:         30438
>Category:       pkg
>Synopsis:       cdrdao not writing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    adrianp
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 06 02:44:00 +0000 2005
>Closed-Date:    Sat Aug 06 01:23:32 +0000 2005
>Last-Modified:  Sat Aug 06 01:23:32 +0000 2005
>Originator:     Mathieu
>Release:        
>Organization:
>Environment:
NetBSD sal.lan 2.0.2_STABLE NetBSD 2.0.2_STABLE (SPECIFIC) #0: Sun Apr 10 01:32:33 EDT 2005  mathieu@sal.lan:/src/src/sys/arch/i386/compile/obj/SPECIFIC i386

>Description:
That's with cdrdao-1.2.0nb1 from pkgsrc.

Most commands (including teh kinda important 'write' command) were just exiting with status 1 after parsing the toc-file.

Looks like function Track::resolveFilename in trackdb/Track.cc in exiting without returning a value when it should be returning non-zero. And looks like I'm not lucky... :p Adding an explicit 'return true' made it work on my system, too.

>How-To-Repeat:
Dunno. Maybe try to run it on full moon.
>Fix:
% diff -u trackdb/Track.cc.orig trackdb/Track.cc
--- trackdb/Track.cc.orig       2005-06-05 22:40:25.000000000 -0400
+++ trackdb/Track.cc    2005-06-05 22:40:25.000000000 -0400
@@ -596,6 +596,7 @@
       }
     }
   }
+  return true;
 }

 // Locates 'SubTrack' that contains specified sample.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->adrianp
Responsible-Changed-By: salo@netbsd.org
Responsible-Changed-When: Mon, 06 Jun 2005 10:27:49 +0000
Responsible-Changed-Why:
Adrian updated cdrdao.


From: Adrian Portelli <adrianp@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/30438 CVS commit: pkgsrc/sysutils/cdrdao
Date: Wed, 15 Jun 2005 21:45:13 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	adrianp
 Date:		Wed Jun 15 21:45:13 UTC 2005

 Modified Files:
 	pkgsrc/sysutils/cdrdao: Makefile.common
 Added Files:
 	pkgsrc/sysutils/cdrdao/patches: patch-ak

 Log Message:
 - Fix writing for cdrdao
 - Reported by Mathieu in PR# 30438, thanks for the PR and the patch.
 - Bump to nb2


 To generate a diff of this commit:
 cvs rdiff -r1.1 -r1.2 pkgsrc/sysutils/cdrdao/Makefile.common
 cvs rdiff -r0 -r1.1 pkgsrc/sysutils/cdrdao/patches/patch-ak

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: adrianp@netbsd.org
State-Changed-When: Sat, 06 Aug 2005 01:23:32 +0000
State-Changed-Why:
patch applied and tested and appears to fix the issue.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.