NetBSD Problem Report #30458
From www@netbsd.org Tue Jun 7 21:58:42 2005
Return-Path: <www@netbsd.org>
Received: by narn.netbsd.org (Postfix, from userid 31301)
id 00A4163B104; Tue, 7 Jun 2005 21:58:42 +0000 (UTC)
Message-Id: <20050607215842.00A4163B104@narn.netbsd.org>
Date: Tue, 7 Jun 2005 21:58:42 +0000 (UTC)
From: Rui Paulo <rpaulo@netbsd-pt.org>
Reply-To: Rui Paulo <rpaulo@netbsd-pt.org>
To: gnats-bugs@netbsd.org
Subject: tlp(4) whitespace cleaning
X-Send-Pr-Version: www-1.0
>Number: 30458
>Category: kern
>Synopsis: tlp(4) whitespace cleaning
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: rpaulo
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Jun 07 21:59:00 +0000 2005
>Closed-Date: Sun Jul 17 00:45:42 +0000 2005
>Last-Modified: Sun Jul 24 03:57:01 +0000 2005
>Originator: Rui Paulo
>Release: N/A
>Organization:
>Environment:
N/A
>Description:
a whitespace is added to sc_name field in tlp_pci_dec_quirks() [sys/dev/pci/if_tlp_pci.c], but if the model is unknown, the whitespace doesn't get deleted (please see the source, i'm not going to explain C code here).
>How-To-Repeat:
problem noticed on freeshell.org:
tlp0: DEC , Ethernet address xx:xx:xx:xx:xx:xx
...
tlp1: DEC , Ethernet address xx:xx:xx:xx:xx:xx
>Fix:
we could apply the following diff, but it only removes the whitespace, it doesn't add any new device:
Index: if_tlp_pci.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/if_tlp_pci.c,v
retrieving revision 1.78
diff -u -r1.78 if_tlp_pci.c
--- if_tlp_pci.c 27 Feb 2005 00:27:33 -0000 1.78
+++ if_tlp_pci.c 7 Jun 2005 21:55:39 -0000
@@ -1012,6 +1012,8 @@
if (memcmp(&sc->sc_srom[29], "DE500", 5) == 0 ||
memcmp(&sc->sc_srom[29], "DE450", 5) == 0)
memcpy(&sc->sc_name[4], &sc->sc_srom[29], 8);
+ else
+ sc->sc_name[3] = '\0';
}
static void
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: kern-bug-people->rpaulo
Responsible-Changed-By: rpaulo@netbsd.org
Responsible-Changed-When: Sun, 17 Jul 2005 00:45:42 +0000
Responsible-Changed-Why:
I'm the submitter
State-Changed-From-To: open->closed
State-Changed-By: rpaulo@netbsd.org
State-Changed-When: Sun, 17 Jul 2005 00:45:42 +0000
State-Changed-Why:
I've fixed it
From: Rui Paulo <rpaulo@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/30458 CVS commit: src/sys/dev/pci
Date: Sun, 17 Jul 2005 00:44:13 +0000 (UTC)
Module Name: src
Committed By: rpaulo
Date: Sun Jul 17 00:44:13 UTC 2005
Modified Files:
src/sys/dev/pci: if_tlp_pci.c
Log Message:
If the DEC board name is not known, remove the leading whitespace in
sc_name.
This closes PR#30458.
ok'ed Jason Thorpe.
To generate a diff of this commit:
cvs rdiff -r1.80 -r1.81 src/sys/dev/pci/if_tlp_pci.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Jeff Rizzo <riz@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/30458 CVS commit: [netbsd-3] src/sys/dev/pci
Date: Tue, 19 Jul 2005 22:00:36 +0000 (UTC)
Module Name: src
Committed By: riz
Date: Tue Jul 19 22:00:36 UTC 2005
Modified Files:
src/sys/dev/pci [netbsd-3]: if_tlp_pci.c
Log Message:
Pull up revision 1.81 (requested by rpaulo in ticket #600):
If the DEC board name is not known, remove the leading whitespace in
sc_name.
This closes PR#30458.
ok'ed Jason Thorpe.
To generate a diff of this commit:
cvs rdiff -r1.78.2.2 -r1.78.2.3 src/sys/dev/pci/if_tlp_pci.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Jeff Rizzo <riz@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/30458 CVS commit: [netbsd-2] src/sys/dev/pci
Date: Sun, 24 Jul 2005 03:56:24 +0000 (UTC)
Module Name: src
Committed By: riz
Date: Sun Jul 24 03:56:24 UTC 2005
Modified Files:
src/sys/dev/pci [netbsd-2]: if_tlp_pci.c
Log Message:
Pull up revision 1.81 (requested by rpaulo in ticket #5506):
If the DEC board name is not known, remove the leading whitespace in
sc_name.
This closes PR#30458.
ok'ed Jason Thorpe.
To generate a diff of this commit:
cvs rdiff -r1.76 -r1.76.4.1 src/sys/dev/pci/if_tlp_pci.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.