NetBSD Problem Report #30607

From ggm@apnic.net  Mon Jun 27 03:58:51 2005
Return-Path: <ggm@apnic.net>
Received: from apnic.net (cumin.apnic.net [202.12.29.59])
	by narn.netbsd.org (Postfix) with ESMTP id 4369B63B116
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 27 Jun 2005 03:58:50 +0000 (UTC)
Message-Id: <200506270357.j5R3vshE026186@garlic.apnic.net>
Date: Mon, 27 Jun 2005 13:57:54 +1000 (EST)
From: ggm@apnic.net
Reply-To: ggm@apnic.net
To: gnats-bugs@netbsd.org
Subject: lang/erlang needs --with-ssl to find the 'right' openssl
X-Send-Pr-Version: 3.95

>Number:         30607
>Category:       pkg
>Synopsis:       lang/erlang needs --with-ssl to find the 'right' openssl (patch included)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 27 03:59:00 +0000 2005
>Closed-Date:    Tue Jul 12 09:41:07 +0000 2005
>Last-Modified:  Tue Jul 12 09:46:01 +0000 2005
>Originator:     George Michaelson
>Release:        NetBSD 3.99.6
>Organization:
APNIC P/L
>Environment:
System: NetBSD garlic.apnic.net 3.99.6 NetBSD 3.99.6 (GGMSMALL) #29: Thu Jun 23 10:58:16 EST 2005 root@:/data/NetBSD/src/sys/arch/i386/compile/GGMSMALL i386
Architecture: i386
Machine: i386
>Description:
	lang/erlang relies on the configure state to find openssl. But
	this is not re-generated for all ports, and so can find the base
	openssl on non-NetBSD architectures like Redhat.

>How-To-Repeat:
	try installing pkgsrc on Redhat EL, install erlang.

>Fix:

This patch fixes it.

-George

--- Makefile.dist       2005-06-27 13:53:43.000000000 +1000
+++ Makefile    2005-06-27 13:45:55.000000000 +1000
@@ -17,6 +17,7 @@
 USE_TOOLS+=            gmake
 USE_JAVA=              yes
 USE_JAVA2=             yes
+CONFIGURE_ARGS+=       --with-ssl=${PREFIX}


 SUBST_CLASSES=         target

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: ggm@apnic.net
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/30607: lang/erlang needs --with-ssl to find the 'right' openssl
Date: Mon, 27 Jun 2005 16:25:16 +0200

 On Mon, Jun 27, 2005 at 03:59:01AM +0000, ggm@apnic.net wrote:
 > >Number:         30607
 > >Category:       pkg
 > >Synopsis:       lang/erlang needs --with-ssl to find the 'right' openssl (patch included)

 I grepped the lang/erlang/work*/erlang*/configure script, and it
 doesn't offer a --with-ssl option, nor does it even contain the
 word "ssl".

 Could you please explain how your patch works?
  Thomas

State-Changed-From-To: open->feedback
State-Changed-By: wiz@netbsd.org
State-Changed-When: Mon, 27 Jun 2005 14:27:05 +0000
State-Changed-Why:
Feedback requested.


From: George Michaelson <ggm@apnic.net>
To: Thomas Klausner <wiz@NetBSD.org>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/30607: lang/erlang needs --with-ssl to find the 'right'
 openssl
Date: Tue, 28 Jun 2005 09:00:00 +1000

 On Mon, 27 Jun 2005 16:25:16 +0200
 Thomas Klausner <wiz@NetBSD.org> wrote:

 > On Mon, Jun 27, 2005 at 03:59:01AM +0000, ggm@apnic.net wrote:
 > > >Number:         30607
 > > >Category:       pkg
 > > >Synopsis:       lang/erlang needs --with-ssl to find the 'right'
 > > >openssl (patch included)
 > 
 > I grepped the lang/erlang/work*/erlang*/configure script, and it
 > doesn't offer a --with-ssl option, nor does it even contain the
 > word "ssl".
 > 
 > Could you please explain how your patch works?
 >  Thomas
 > 

 [ggm@ginger erts]$ pwd
 /opt/pkgsrc/lang/erlang/work/otp_src_R9C-0/erts
 [ggm@ginger erts]$ grep -l with-ssl *
 config.status
 config.status.overridden
 configure
 configure.in
 [ggm@ginger erts]$

From: George Michaelson <ggm@apnic.net>
To: Thomas Klausner <wiz@NetBSD.org>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/30607: lang/erlang needs --with-ssl to find the 'right'
 openssl
Date: Tue, 28 Jun 2005 15:57:39 +1000

 sorry I realize my response was a bit terce.

 there isn't a direct dependency on the top-level ./configure in the
 package, but one of its subsidiary directories does in fact depend on
 detecting the path of openssl. It detects the base installation on non-
 NetBSD systems (probably on NetBSD too, although I suspect few people
 install openssl from pkgsrc because the base is up-to-date enough)

 adding --with-ssl to CONFIGURE_ARGS does seem to be passed down to the
 child directory of this package.

 -George

From: Lubomir Sedlacik <salo@Xtrmntr.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/30607: lang/erlang needs --with-ssl to find the 'right' openssl
Date: Tue, 28 Jun 2005 08:35:14 +0200

 --BeJB7u2HmcNo1GIz
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable

 On Mon, Jun 27, 2005 at 03:59:01AM +0000, ggm@apnic.net wrote:
 > This patch fixes it.
 >=20
 > --- Makefile.dist       2005-06-27 13:53:43.000000000 +1000
 > +++ Makefile    2005-06-27 13:45:55.000000000 +1000
 > @@ -17,6 +17,7 @@
 >  USE_TOOLS+=3D            gmake
 >  USE_JAVA=3D              yes
 >  USE_JAVA2=3D             yes
 > +CONFIGURE_ARGS+=3D       --with-ssl=3D${PREFIX}
 > =20
 > =20
 >  SUBST_CLASSES=3D         target

 the patch is wrong.  you should never use PREFIX to reference a file
 from another package.  you want to use BUILDLINK_PREFIX.openssl.


 regards,

 --=20
 -- Lubomir Sedlacik <salo@{NetBSD,Xtrmntr,silcnet}.org>   --

 --BeJB7u2HmcNo1GIz
 Content-Type: application/pgp-signature
 Content-Disposition: inline

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (NetBSD)

 iD8DBQFCwO+iiwjDDlS8cmMRAvf6AJ0eEYfCyj8paQCDpQFgFGRe98aDoQCfb2dS
 y5S7g2jnx55xhRoIXrqX/Cw=
 =r0ng
 -----END PGP SIGNATURE-----

 --BeJB7u2HmcNo1GIz--

From: George Michaelson <ggm@apnic.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/30607: lang/erlang needs --with-ssl to find the 'right'
 openssl
Date: Tue, 5 Jul 2005 15:18:11 +1000

 I've tested the change to BUILDLINK_PREFIX.openssl and it seems to
 work. So the modified patch below is better.

 Thanks for the pointer.

 -george

 --- Makefile.dist       2005-06-27 13:53:43.000000000 +1000
 +++ Makefile    2005-07-05 15:17:50.000000000 +1000
 @@ -17,6 +17,7 @@
  USE_TOOLS+=            gmake
  USE_JAVA=              yes
  USE_JAVA2=             yes
 +CONFIGURE_ARGS+=       --with-ssl=${BUILDLINK_PREFIX.openssl}


  SUBST_CLASSES=         target

State-Changed-From-To: feedback->closed
State-Changed-By: wiz@netbsd.org
State-Changed-When: Tue, 12 Jul 2005 09:41:07 +0000
State-Changed-Why:
Committed the latest version of your patch.
Thanks for the PR!


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/30607 CVS commit: pkgsrc/lang/erlang
Date: Tue, 12 Jul 2005 09:40:46 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Tue Jul 12 09:40:46 UTC 2005

 Modified Files:
 	pkgsrc/lang/erlang: Makefile

 Log Message:
 Pass openssl location to configure script. From George Michaelson
 in PR 30607.


 To generate a diff of this commit:
 cvs rdiff -r1.18 -r1.19 pkgsrc/lang/erlang/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search