NetBSD Problem Report #30658

From hubert@feyrer.de  Sun Jul  3 20:24:27 2005
Return-Path: <hubert@feyrer.de>
Received: from rfhs0023.fh-regensburg.de (rfhs0023.fh-regensburg.de [194.95.104.23])
	by narn.netbsd.org (Postfix) with SMTP id 77E8D63B104
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  3 Jul 2005 20:24:26 +0000 (UTC)
Message-Id: <200507032024.j63KOMNW009446@vulab.fh-regensburg.de>
Date: Sun, 3 Jul 2005 22:24:22 +0200 (CEST)
From: hubert@feyrer.de
Reply-To: hubert@feyrer.de
To: gnats-bugs@netbsd.org
Subject: 3.0_BETA: pkg_add broken for installing valid binary pkgs
X-Send-Pr-Version: 3.95

>Number:         30658
>Category:       bin
>Synopsis:       3.0_BETA: pkg_add broken for installing valid binary pkgs
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 03 20:25:00 +0000 2005
>Closed-Date:    Mon Jul 18 09:07:41 +0000 2005
>Last-Modified:  Sat Jul 30 17:39:05 +0000 2005
>Originator:     hubert@feyrer.de
>Release:        NetBSD 3.0_BETA
>Organization:
Hubert Feyrer <hubertf@channel.regensburg.org>
>Environment:


System: NetBSD miyu 3.0_BETA NetBSD 3.0_BETA (MIYU) #1: Sat Jul  2 17:00:22 MEST 2005  feyrer@miyu:/home/cvs/src-3/sys/arch/i386/compile/obj.i386/MIYU i386
Architecture: i386
Machine: i386
>Description:
	When building a binary pkg with "IGNORE_RECOMMENDED=yes" in 
 	/etc/mk.conf, pkg_add refuses to install that package again
	later:

pkg_comp:default.conf# pkg_add mc-4.6.1rc4.1.tgz 
pkg_add: Warning: package `/usr/pkgsrc/packages/i386/3.0/All/./mc-4.6.1rc4.1.tgz' was built for a different version of the OS:
pkg_add: NetBSD/i386 3.0_BETA (pkg) vs. NetBSD/i386 3.0 (this host)
pkg_add: Package `/usr/pkgsrc/packages/i386/3.0/All/./mc-4.6.1rc4.1.tgz' has
pkg_add: IGNORE_RECOMMENDED set: This package was built with
pkg_add: dependency recommendations ignored.  It may have been
pkg_add: built against a set of installed packages that is
pkg_add: different from the recommended set of pre-requisites.
pkg_add: As a consequence, this package may not work on this
pkg_add: or other systems with a different set of packages.
pkg_add: aborting.
pkg_add: 1 package addition failed
pkg_comp:default.conf# 


>How-To-Repeat:
	See above.
>Fix:
	Fix pkg_add to not care for IGNORE_RECOMMENDED.
	First creating a binary pkg and the not being able to install
	it is a waste of time, energy and cpu cycles, and does not
	follow the principe of having me the rope I want.

	The only way to get that package installed by using -f
	has too many negative side effects to be useful.

	While there, it would be nice if that warning about the OS
	version not matching would go away, as it can be expected that
	3.0 and 3.0_BETA are compatible.

>Release-Note:

>Audit-Trail:
From: "Jeremy C. Reed" <reed@reedmedia.net>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/30658: 3.0_BETA: pkg_add broken for installing valid binary
 pkgs
Date: Mon, 4 Jul 2005 10:03:11 -0700 (PDT)

 On Sun, 3 Jul 2005 hubert@feyrer.de wrote:

 This also hits me.

 Maybe we can make it if pkg_install is built with IGNORE_RECOMMENDED 
 defined, then this behaviour will be turned off.

 One problem is that IGNORE_RECOMMENDED may be set within BSD_PKG_MK  and 
 so building src/usr.sbin/pkg_install may ignore it.

 I think the warning when building the package is good enough.

 And so the check in pkg_add should be removed.


   Jeremy C. Reed

   	  	 	 BSD News, BSD tutorials, BSD links
  	  	 	 http://www.bsdnewsletter.com/

From: Hubert Feyrer <hubert@feyrer.de>
To: gnats-bugs@netbsd.org, rh@NetBSD.org, wiz@NetBSD.org
Cc: Hubert Feyrer <hubert@feyrer.de>
Subject: Re: bin/30658: 3.0_BETA: pkg_add broken for installing valid binary
 pkgs
Date: Wed, 13 Jul 2005 04:15:52 +0200 (CEST)

 After previous discussion with wiz@ on the matter in this PR, and PR 
 pkg/24712 which initially raised the problematic change, I'd like to 
 change the fatal error into a warning.

 Please review, I'll commit this by monday morning GMT if I hear no 
 objections.


   - Hubert


 Index: perform.c
 ===================================================================
 RCS file: /cvsroot/src/usr.sbin/pkg_install/add/perform.c,v
 retrieving revision 1.110
 diff -u -r1.110 perform.c
 --- perform.c	29 Jun 2005 01:40:42 -0000	1.110
 +++ perform.c	13 Jul 2005 02:09:57 -0000
 @@ -408,17 +408,8 @@

   	if (buildinfo[BI_IGNORE_RECOMMENDED] != NULL &&
   	    strcasecmp(buildinfo[BI_IGNORE_RECOMMENDED], "NO") != 0) {
 -		warnx("Package `%s' has", pkg);
 -		warnx("IGNORE_RECOMMENDED set: This package was built with");
 -		warnx("dependency recommendations ignored.  It may have been");
 -		warnx("built against a set of installed packages that is");
 -		warnx("different from the recommended set of pre-requisites.");
 -		warnx("As a consequence, this package may not work on this");
 -		warnx("or other systems with a different set of packages.");
 -		if (!Force && !getenv("PKG_IGNORE_RECOMMENDED")) {
 -			    warnx("aborting.");
 -			    goto bomb;
 -		}
 +		warnx("%s was built", pkg);
 +		warnx("\t to ignore recommended dependencies, this may cause problems!\n");
   	}

   	/*
 Index: pkg_add.1
 ===================================================================
 RCS file: /cvsroot/src/usr.sbin/pkg_install/add/pkg_add.1,v
 retrieving revision 1.59
 diff -u -r1.59 pkg_add.1
 --- pkg_add.1	6 May 2005 23:02:39 -0000	1.59
 +++ pkg_add.1	13 Jul 2005 02:09:57 -0000
 @@ -17,7 +17,7 @@
   .\"
   .\"     @(#)pkg_add.1
   .\"
 -.Dd May 7, 2005
 +.Dd July 13, 2005
   .Dt PKG_ADD 1
   .Os
   .Sh NAME
 @@ -401,12 +401,7 @@
   is then checked for
   .Ev IGNORE_RECOMMENDED .
   If the package was built with dependency recommendations ignored,
 -installation will be aborted.
 -This behavior is overridable with the
 -.Fl f
 -flag and the
 -.Ev PKG_IGNORE_RECOMMENDED
 -environment variable.
 +a warning will be issued.
   .It
   If the package contains a
   .Ar require

State-Changed-From-To: open->closed
State-Changed-By: hubertf@netbsd.org
State-Changed-When: Mon, 18 Jul 2005 09:07:41 +0000
State-Changed-Why:
fixed as proposed.
I'm concerned by the fact that I did not get a single response by who broke
the pkg_add command in the first place. :(


 - Hubert


From: Hubert Feyrer <hubertf@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/30658 CVS commit: src/usr.sbin/pkg_install/add
Date: Mon, 18 Jul 2005 09:06:49 +0000 (UTC)

 Module Name:	src
 Committed By:	hubertf
 Date:		Mon Jul 18 09:06:49 UTC 2005

 Modified Files:
 	src/usr.sbin/pkg_install/add: perform.c pkg_add.1

 Log Message:
 Fix PR pkg/30658: don't fail for pkgs that were built with IGNORE_RECOMMENDED,
 just issue a warning.

 Checked by wiz@, no reply from original author (rh@) after several weeks. :(


 To generate a diff of this commit:
 cvs rdiff -r1.110 -r1.111 src/usr.sbin/pkg_install/add/perform.c
 cvs rdiff -r1.59 -r1.60 src/usr.sbin/pkg_install/add/pkg_add.1

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Hubert Feyrer <hubertf@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/30658 CVS commit: pkgsrc/pkgtools/pkg_install/files
Date: Mon, 18 Jul 2005 09:14:04 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	hubertf
 Date:		Mon Jul 18 09:14:04 UTC 2005

 Modified Files:
 	pkgsrc/pkgtools/pkg_install/files/add: perform.c pkg_add.1
 	pkgsrc/pkgtools/pkg_install/files/lib: version.h

 Log Message:
 Sync over files from src/usr.sbin/pkg_install to fix PR pkg/30658:
 Warn, but don't error out on pkgs that were built with IGNORE_RECOMMENDED.

 Bump version to 20050718.


 To generate a diff of this commit:
 cvs rdiff -r1.31 -r1.32 pkgsrc/pkgtools/pkg_install/files/add/perform.c
 cvs rdiff -r1.14 -r1.15 pkgsrc/pkgtools/pkg_install/files/add/pkg_add.1
 cvs rdiff -r1.46 -r1.47 pkgsrc/pkgtools/pkg_install/files/lib/version.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Matthias Scheler <tron@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/30658 CVS commit: [netbsd-3] src/usr.sbin/pkg_install/add
Date: Sat, 30 Jul 2005 17:38:53 +0000 (UTC)

 Module Name:	src
 Committed By:	tron
 Date:		Sat Jul 30 17:38:53 UTC 2005

 Modified Files:
 	src/usr.sbin/pkg_install/add [netbsd-3]: pkg_add.1

 Log Message:
 Pull up revision 1.60 (requested by hubertf in ticket #623):
 Fix PR pkg/30658: don't fail for pkgs that were built with IGNORE_RECOMMENDED,
 just issue a warning.
 Checked by wiz@, no reply from original author (rh@) after several weeks. :(


 To generate a diff of this commit:
 cvs rdiff -r1.57.2.2 -r1.57.2.3 src/usr.sbin/pkg_install/add/pkg_add.1

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Matthias Scheler <tron@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/30658 CVS commit: [netbsd-3] src/usr.sbin/pkg_install/add
Date: Sat, 30 Jul 2005 17:39:00 +0000 (UTC)

 Module Name:	src
 Committed By:	tron
 Date:		Sat Jul 30 17:39:00 UTC 2005

 Modified Files:
 	src/usr.sbin/pkg_install/add [netbsd-3]: perform.c

 Log Message:
 Pull up revision 1.111 (requested by hubertf in ticket #623):
 Fix PR pkg/30658: don't fail for pkgs that were built with IGNORE_RECOMMENDED,
 just issue a warning.
 Checked by wiz@, no reply from original author (rh@) after several weeks. :(


 To generate a diff of this commit:
 cvs rdiff -r1.107.2.2 -r1.107.2.3 src/usr.sbin/pkg_install/add/perform.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.