NetBSD Problem Report #30677

From martin@aprisoft.de  Wed Jul  6 16:58:49 2005
Return-Path: <martin@aprisoft.de>
Received: from mail.duskware.de (mail.duskware.de [213.146.108.170])
	by narn.netbsd.org (Postfix) with ESMTP id E212763B104
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  6 Jul 2005 16:58:43 +0000 (UTC)
Message-Id: <200507061658.j66GwdUi017112@nelly.aprisoft.de>
Date: Wed, 6 Jul 2005 18:58:39 +0200 (CEST)
From: Martin Husemann <martin@aprisoft.de>
Reply-To: martin@aprisoft.de
To: gnats-bugs@netbsd.org
Subject: ogmtools has bogus alginment/packing assumptions
X-Send-Pr-Version: 3.95


>Number:         30677
>Category:       pkg
>Synopsis:       ogmtools has bogus alginment/packing assumptions
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 06 16:59:01 +0000 2005
>Last-Modified:  Mon Nov 01 00:07:49 +0000 2010
>Originator:     Martin Husemann
>Release:        NetBSD 3.99.7
>Organization:
>Environment:
System: NetBSD nelly.aprisoft.de 3.99.7 NetBSD 3.99.7 (NELLY) #12: Thu Jun 30 21:05:24 CEST 2005 martin@nelly.aprisoft.de:/usr/src/sys/arch/sparc64/compile/NELLY sparc64
Architecture: sparc64
Machine: sparc64
>Description:


On certain ogm files, the tool ogminfo from multimedia/ogmtools can not
identify streams. This happens, because the header size (as encoded in
the header) does not seem sufficient when compared to the 
sizeof(old_stream_header) - because the compiler might add alginment add
the end of the structure on somer archs. This probably is the reason that
the otherwise identical struct stream_header has grown an additional


  ogg_int16_t padding;


at the end.


In the case I looked at, this if did not hit (line 342 of ogminfo.c):


    } else if (((*pack.packet & PACKET_TYPE_BITS ) == PACKET_TYPE_HEADER) &&
               (pack.bytes >= (int)(sizeof(old_stream_header) + 1))) {


because pack.bytes was 53, but sizeof(old_stream_header) was 56.


I didn't look for other instances of this problem in the pkg, but there
likely are some:


fgrep old_stream_header * | fgrep sizeof | wc -l
    6


>How-To-Repeat:
Run ogminfo on strict alignement archs/code inspection.
>Fix:
Probably report to upstream maintainers?


>Release-Note:


>Audit-Trail:


Responsible-Changed-From-To: pkg-manager->cube
Responsible-Changed-By: recht@netbsd.org
Responsible-Changed-When: Sun, 10 Jul 2005 16:34:48 +0000
Responsible-Changed-Why:
over to maintainer




Responsible-Changed-From-To: cube->pkg-manager
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Mon, 01 Nov 2010 00:07:49 +0000
Responsible-Changed-Why:
back to role account.




>Unformatted:

 

Home	PR Database Search