NetBSD Problem Report #30715

From hauke@Espresso.Rhein-Neckar.DE  Sun Jul 10 18:57:12 2005
Return-Path: <hauke@Espresso.Rhein-Neckar.DE>
Received: from la3serv.rninet.de (la3serv.rninet.de [62.225.55.3])
	by narn.netbsd.org (Postfix) with ESMTP id 449DC63B116
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 10 Jul 2005 18:57:10 +0000 (UTC)
Message-Id: <200507101848.j6AImubw018382@pizza.causeuse.org>
Date: Sun, 10 Jul 2005 20:48:56 +0200 (CEST)
From: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
Reply-To: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
To: gnats-bugs@netbsd.org
Cc: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
Subject: Make openslp an option for Netatalk package(s)
X-Send-Pr-Version: 3.95

>Number:         30715
>Category:       pkg
>Synopsis:       Make openslp an option for Netatalk package(s)
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    markd
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 10 18:58:00 +0000 2005
>Closed-Date:    Sun Jul 31 19:43:16 +0000 2005
>Last-Modified:  Mon Oct 09 21:05:49 +0000 2023
>Originator:     Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
>Release:        NetBSD 3.0_BETA
>Organization:
Falling Raindrops
>Environment:


System: NetBSD pizza.causeuse.org 3.0_BETA NetBSD 3.0_BETA (PIZZA) #8: Sun Jul 10 00:16:52 CEST 2005 hf@heiligenberg:/var/obj/netbsd-builds/3_0/sparc/sys/arch/sparc/compile/PIZZA sparc
Architecture: sparc
Machine: sparc
>Description:

The net/netatalk package depends on net/openslp unconditionally. From
the Netatalk documentation:

  * OpenSLP

    SLP (Service Location Protocol) is an IETF standards track protocol that
    provides a framework to allow networking applications to discover the
    existence, location, and configuration of networked services in enterprise
    networks.

    Mac OS X uses it to locate AFP servers, even though newer version prefer
    Rendezvous.

In other words, slp is irrelevant for Macintosh System 6..9 clients,
and for MacOS X 10.3..4 clients -- enough reasons to make the
dependency on openslp an option.

>How-To-Repeat:

Build and install Netatalk 2.x package, find it installs
openslp. Observe that none of the clients you run actually makes use
of slp. Further, observe that openslp has the occasional security
issue.

>Fix:

Apply the following patch:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/net/netatalk/Makefile,v
retrieving revision 1.42
diff -u -u -r1.42 Makefile
--- Makefile	26 May 2005 05:47:40 -0000	1.42
+++ Makefile	10 Jul 2005 18:39:02 -0000
@@ -58,7 +58,7 @@
 SUBST_SED.paths+=	-e "s,\(NETBSD.*\)/etc/rc.d,\1${PREFIX}/${RCD_SCRIPTS_EXAMPLEDIR},"

 PKG_OPTIONS_VAR=        PKG_OPTIONS.netatalk
-PKG_SUPPORTED_OPTIONS=  cups kerberos
+PKG_SUPPORTED_OPTIONS=  cups slp kerberos

 .include "../../mk/bsd.options.mk"

@@ -69,6 +69,13 @@
 CONFIGURE_ARGS+=        --disable-cups
 .endif

+.if !empty(PKG_OPTIONS:Mslp)
+.include "../../net/openslp/buildlink3.mk"
+CONFIGURE_ARGS+=        --enable-srvloc
+.else
+CONFIGURE_ARGS+=        --disable-srvloc
+.endif
+
 .if !empty(PKG_OPTIONS:Mkerberos)
 .include "../../mk/krb5.buildlink3.mk"
 CONFIGURE_ARGS+=	--with-gssapi --enable-krbV-uam
@@ -83,7 +90,6 @@
 	${INSTALL_DATA_DIR} ${PREFIX}/libexec/psffilters

 .include "../../databases/db4/buildlink3.mk"
-.include "../../net/openslp/buildlink3.mk"
 .include "../../security/openssl/buildlink3.mk"
 .include "../../security/tcp_wrappers/buildlink3.mk"


>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->jlam
Responsible-Changed-By: recht@netbsd.org
Responsible-Changed-When: Tue, 12 Jul 2005 19:06:31 +0000
Responsible-Changed-Why:
over to maintainer


Responsible-Changed-From-To: jlam->markd
Responsible-Changed-By: markd@netbsd.org
Responsible-Changed-When: Tue, 12 Jul 2005 20:10:37 +0000
Responsible-Changed-Why:
I'm the maintainer, I'll look at it.


From: Mark Davies <markd@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/30715 CVS commit: pkgsrc/net/netatalk
Date: Sun, 31 Jul 2005 13:19:55 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	markd
 Date:		Sun Jul 31 13:19:55 UTC 2005

 Modified Files:
 	pkgsrc/net/netatalk: Makefile PLIST distinfo
 	pkgsrc/net/netatalk/patches: patch-aa
 Added Files:
 	pkgsrc/net/netatalk: MESSAGE.pam

 Log Message:
 Make openslp support optional (PR pkg/30715) and add an option for PAM.
 Bump PKGREVISION.


 To generate a diff of this commit:
 cvs rdiff -r0 -r1.1 pkgsrc/net/netatalk/MESSAGE.pam
 cvs rdiff -r1.44 -r1.45 pkgsrc/net/netatalk/Makefile
 cvs rdiff -r1.13 -r1.14 pkgsrc/net/netatalk/PLIST
 cvs rdiff -r1.18 -r1.19 pkgsrc/net/netatalk/distinfo
 cvs rdiff -r1.13 -r1.14 pkgsrc/net/netatalk/patches/patch-aa

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: markd@netbsd.org
State-Changed-When: Sun, 31 Jul 2005 19:43:16 +0000
State-Changed-Why:
option added.


>Unformatted:

Home	PR Database Search