NetBSD Problem Report #30837

From jukka+moray@salmi.ch  Tue Jul 26 11:17:56 2005
Return-Path: <jukka+moray@salmi.ch>
Received: from mx1.salmi.ch (mx1.salmi.ch [212.254.26.68])
	by narn.netbsd.org (Postfix) with ESMTP id 7439463B116
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 26 Jul 2005 11:17:55 +0000 (UTC)
Message-Id: <20050726111748.5FC591A4B6@moray.salmi.ch>
Date: Tue, 26 Jul 2005 13:17:48 +0200 (CEST)
From: j+nbsd@2005.salmi.ch
To: gnats-bugs@netbsd.org
Subject: add `nogui' option to net/jigdo (patch privided)
X-Send-Pr-Version: 3.95

>Number:         30837
>Category:       pkg
>Synopsis:       add `nogui' option to net/jigdo (patch privided)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 26 11:18:00 +0000 2005
>Last-Modified:  Tue Jul 26 17:00:02 +0000 2005
>Originator:     Jukka Salmi
>Release:        NetBSD 3.99.7
>Environment:
System: NetBSD moray.salmi.ch 3.99.7 NetBSD 3.99.7 (MORAY) #0: Mon Jul 25 19:41:58 CEST 2005 build@moray.salmi.ch:/build/nbsd/i386/sys/arch/i386/compile/MORAY i386
Architecture: i386
Machine: i386
>Description:
The attached patch adds a `nogui' option to net/jigdo to make it possible
to build the package without the GTK+ GUI. If built with `nogui', www/libwww
and x11/gtk2 are not needed anymore.
>How-To-Repeat:
N/a
>Fix:
Apply the attached patch which can be found at
http://salmi.ch/~jukka/patches/pkgsrc/net/jigdo/patch-nogui_option

diff -ruN pkgsrc/net/jigdo.bak/Makefile pkgsrc/net/jigdo/Makefile
--- pkgsrc/net/jigdo.bak/Makefile	2005-07-21 21:59:31.000000000 +0200
+++ pkgsrc/net/jigdo/Makefile	2005-07-26 12:56:56.000000000 +0200
@@ -9,6 +9,19 @@
 HOMEPAGE=		http://atterer.net/jigdo/
 COMMENT=		Tool to ease downloading of large files from the Internet

+PKG_OPTIONS_VAR=	PKG_OPTIONS.jigdo
+PKG_SUPPORTED_OPTIONS=	nogui
+
+.include "../../mk/bsd.options.mk"
+
+
+.if !empty(PKG_OPTIONS:Mnogui)
+CONFIGURE_ARGS+=	--without-gui
+.else
+CONFIGURE_ARGS+=	--with-gui
+PLIST_SRC=		${PKGDIR}/PLIST ${PKGDIR}/PLIST.gui
+.endif
+
 CONFIGURE_ARGS+=	--without-libdb
 GNU_CONFIGURE=		yes
 USE_LANGUAGES=		c c++
@@ -16,7 +29,10 @@
 #.include "../../databases/db3/buildlink3.mk"
 .include "../../devel/gettext-lib/buildlink3.mk"
 .include "../../devel/pkg-config/buildlink3.mk"
+
+.if empty(PKG_OPTIONS:Mnogui)
 .include "../../www/libwww/buildlink3.mk"
 .include "../../x11/gtk2/buildlink3.mk"
+.endif

 .include "../../mk/bsd.pkg.mk"
diff -ruN pkgsrc/net/jigdo.bak/PLIST pkgsrc/net/jigdo/PLIST
--- pkgsrc/net/jigdo.bak/PLIST	2004-02-26 23:55:18.000000000 +0100
+++ pkgsrc/net/jigdo/PLIST	2005-07-26 13:00:16.000000000 +0200
@@ -1,21 +1,10 @@
 @comment $NetBSD: PLIST,v 1.1.1.1 2004/02/26 22:55:18 agc Exp $
-bin/jigdo
 bin/jigdo-file
 bin/jigdo-lite
 bin/jigdo-mirror
 man/man1/jigdo-file.1
 man/man1/jigdo-lite.1
 man/man1/jigdo-mirror.1
-man/man1/jigdo.1
-share/jigdo/COPYING
 share/jigdo/debian-mirrors.jigdo
-share/jigdo/pixmaps/close.png
-share/jigdo/pixmaps/jigdo-logo.png
-share/jigdo/pixmaps/pause.png
-share/jigdo/pixmaps/progress-green.png
-share/jigdo/pixmaps/restart.png
-share/jigdo/pixmaps/start.png
-share/jigdo/pixmaps/stop.png
 ${PKGLOCALEDIR}/locale/de/LC_MESSAGES/jigdo.mo
-@dirrm share/jigdo/pixmaps
 @dirrm share/jigdo
diff -ruN pkgsrc/net/jigdo.bak/PLIST.gui pkgsrc/net/jigdo/PLIST.gui
--- pkgsrc/net/jigdo.bak/PLIST.gui	1970-01-01 01:00:00.000000000 +0100
+++ pkgsrc/net/jigdo/PLIST.gui	2005-07-26 13:00:22.000000000 +0200
@@ -0,0 +1,12 @@
+@comment $NetBSD$
+bin/jigdo
+man/man1/jigdo.1
+share/jigdo/COPYING
+share/jigdo/pixmaps/close.png
+share/jigdo/pixmaps/jigdo-logo.png
+share/jigdo/pixmaps/pause.png
+hare/jigdo/pixmaps/progress-green.png
+share/jigdo/pixmaps/restart.png
+share/jigdo/pixmaps/start.png
+share/jigdo/pixmaps/stop.png
+@dirrm share/jigdo/pixmaps

>Audit-Trail:
From: Lubomir Sedlacik <salo@Xtrmntr.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/30837: add `nogui' option to net/jigdo (patch privided)
Date: Tue, 26 Jul 2005 13:27:31 +0200

 --hNG1vEeyG8BCaHbQ
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable

 On Tue, Jul 26, 2005 at 11:18:00AM +0000, j+nbsd@2005.salmi.ch wrote:
 > The attached patch adds a `nogui' option to net/jigdo to make it
 > possible to build the package without the GTK+ GUI. If built with
 > `nogui', www/libwww and x11/gtk2 are not needed anymore.

 could you, please, change the semantics to option 'x11', default on?
 it makes more sense that way and it's also consistent with other
 packages.


 regards,

 --=20
 -- Lubomir Sedlacik <salo@{NetBSD,Xtrmntr,silcnet}.org>   --

 --hNG1vEeyG8BCaHbQ
 Content-Type: application/pgp-signature
 Content-Disposition: inline

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (NetBSD)

 iD8DBQFC5h4jiwjDDlS8cmMRAqAeAJ9nZb7FNV+hWxhpgsjXvHGQ/oLwkACgjmhW
 fwYCXD6jxvTiR1pM8WXGJBc=
 =6xdK
 -----END PGP SIGNATURE-----

 --hNG1vEeyG8BCaHbQ--

From: Jukka Salmi <j+nbsd@2005.salmi.ch>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/30837: add `nogui' option to net/jigdo (patch privided)
Date: Tue, 26 Jul 2005 14:20:05 +0200

 --eHhjakXzOLJAF9wJ
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline

 Lubomir Sedlacik --> pkgsrc-bugs (2005-07-26 11:28:03 +0000):
 >  could you, please, change the semantics to option 'x11', default on?
 >  it makes more sense that way and it's also consistent with other
 >  packages.

 Sure, the modified patch is attached and available from
 http://salmi.ch/~jukka/patches/pkgsrc/net/jigdo/patch-x11_option

 BTW, I choose `nogui' because I found this option in
 pkgsrc/mk/defaults/options.description. As for me, `x11' is fine.


 Cheers, Jukka

 -- 
 bashian roulette:
 $ ((RANDOM%6)) || rm -rf ~

 --eHhjakXzOLJAF9wJ
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch-x11_option

 diff -ruN pkgsrc/net/jigdo.bak/Makefile pkgsrc/net/jigdo/Makefile
 --- pkgsrc/net/jigdo.bak/Makefile	2005-07-21 21:59:31.000000000 +0200
 +++ pkgsrc/net/jigdo/Makefile	2005-07-26 14:11:19.000000000 +0200
 @@ -9,6 +9,20 @@
  HOMEPAGE=		http://atterer.net/jigdo/
  COMMENT=		Tool to ease downloading of large files from the Internet

 +PKG_OPTIONS_VAR=	PKG_OPTIONS.jigdo
 +PKG_SUPPORTED_OPTIONS=	x11
 +PKG_SUGGESTED_OPTIONS=	x11
 +
 +.include "../../mk/bsd.options.mk"
 +
 +
 +.if !empty(PKG_OPTIONS:Mx11)
 +CONFIGURE_ARGS+=	--with-gui
 +PLIST_SRC=		${PKGDIR}/PLIST ${PKGDIR}/PLIST.x11
 +.else
 +CONFIGURE_ARGS+=	--without-gui
 +.endif
 +
  CONFIGURE_ARGS+=	--without-libdb
  GNU_CONFIGURE=		yes
  USE_LANGUAGES=		c c++
 @@ -16,7 +30,10 @@
  #.include "../../databases/db3/buildlink3.mk"
  .include "../../devel/gettext-lib/buildlink3.mk"
  .include "../../devel/pkg-config/buildlink3.mk"
 +
 +.if !empty(PKG_OPTIONS:Mx11)
  .include "../../www/libwww/buildlink3.mk"
  .include "../../x11/gtk2/buildlink3.mk"
 +.endif

  .include "../../mk/bsd.pkg.mk"
 diff -ruN pkgsrc/net/jigdo.bak/PLIST pkgsrc/net/jigdo/PLIST
 --- pkgsrc/net/jigdo.bak/PLIST	2004-02-26 23:55:18.000000000 +0100
 +++ pkgsrc/net/jigdo/PLIST	2005-07-26 13:00:16.000000000 +0200
 @@ -1,21 +1,10 @@
  @comment $NetBSD: PLIST,v 1.1.1.1 2004/02/26 22:55:18 agc Exp $
 -bin/jigdo
  bin/jigdo-file
  bin/jigdo-lite
  bin/jigdo-mirror
  man/man1/jigdo-file.1
  man/man1/jigdo-lite.1
  man/man1/jigdo-mirror.1
 -man/man1/jigdo.1
 -share/jigdo/COPYING
  share/jigdo/debian-mirrors.jigdo
 -share/jigdo/pixmaps/close.png
 -share/jigdo/pixmaps/jigdo-logo.png
 -share/jigdo/pixmaps/pause.png
 -share/jigdo/pixmaps/progress-green.png
 -share/jigdo/pixmaps/restart.png
 -share/jigdo/pixmaps/start.png
 -share/jigdo/pixmaps/stop.png
  ${PKGLOCALEDIR}/locale/de/LC_MESSAGES/jigdo.mo
 -@dirrm share/jigdo/pixmaps
  @dirrm share/jigdo
 diff -ruN pkgsrc/net/jigdo.bak/PLIST.gui pkgsrc/net/jigdo/PLIST.gui
 --- pkgsrc/net/jigdo.bak/PLIST.gui	1970-01-01 01:00:00.000000000 +0100
 +++ pkgsrc/net/jigdo/PLIST.gui	2005-07-26 13:00:22.000000000 +0200
 @@ -0,0 +1,12 @@
 +@comment $NetBSD$
 +bin/jigdo
 +man/man1/jigdo.1
 +share/jigdo/COPYING
 +share/jigdo/pixmaps/close.png
 +share/jigdo/pixmaps/jigdo-logo.png
 +share/jigdo/pixmaps/pause.png
 +hare/jigdo/pixmaps/progress-green.png
 +share/jigdo/pixmaps/restart.png
 +share/jigdo/pixmaps/start.png
 +share/jigdo/pixmaps/stop.png
 +@dirrm share/jigdo/pixmaps

 --eHhjakXzOLJAF9wJ--

From: Jukka Salmi <j+nbsd@2005.salmi.ch>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/30837: add `nogui' option to net/jigdo (patch privided)
Date: Tue, 26 Jul 2005 18:35:39 +0200

 Both patches I sent contained typos. Corrected versions are available from
 http://salmi.ch/~jukka/patches/pkgsrc/net/jigdo/

 -- 
 bashian roulette:
 $ ((RANDOM%6)) || rm -rf ~

From: "Jeremy C. Reed" <reed@reedmedia.net>
To: gnats-bugs@netbsd.org
Cc: j+nbsd@2005.salmi.ch
Subject: Re: pkg/30837: add `nogui' option to net/jigdo (patch privided)
Date: Tue, 26 Jul 2005 09:59:46 -0700 (PDT)

 Maybe should just make a new second package. Examples: 
 editors/emacs-nox11, editors/xemacs-nox11, graphics/gnuplot-nox11, 
 graphics/plotutils-nox11, lang/pnetlib-nox11, net/irrtoolset-nox11, 
 print/ghostscript-esp-nox11, security/dsniff-nox11

 Or maybe jigdo and jigdo-gui since there are many examples like that.

 Or maybe jigdo and jigdo-x11 since there are several packages named like 
 that too.

   Jeremy C. Reed

   	  	 	 BSD News, BSD tutorials, BSD links
  	  	 	 http://www.bsdnewsletter.com/

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.