NetBSD Problem Report #31102

From smb@cs.columbia.edu  Tue Aug 30 18:34:35 2005
Return-Path: <smb@cs.columbia.edu>
Received: from machshav.com (machshav.com [147.28.0.16])
	by narn.netbsd.org (Postfix) with ESMTP id 8E94463B11E
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 30 Aug 2005 18:34:35 +0000 (UTC)
Message-Id: <20050830183427.1C9603C0702@berkshire.machshav.com>
Date: Tue, 30 Aug 2005 14:34:27 -0400 (EDT)
From: smb@cs.columbia.edu
Reply-To: smb@cs.columbia.edu
To: gnats-bugs@netbsd.org
Subject: print/mpage won't compile
X-Send-Pr-Version: 3.95

>Number:         31102
>Category:       pkg
>Synopsis:       print/mpage won't compile
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 30 18:35:00 +0000 2005
>Closed-Date:    Tue Sep 20 19:44:11 +0000 2005
>Last-Modified:  Tue Sep 20 19:49:00 +0000 2005
>Originator:     Steven M. Bellovin
>Release:        NetBSD 3.99.7
>Organization:
Department of Computer Science, Columbia University
>Environment:


System: NetBSD berkshire.machshav.com 3.99.7 NetBSD 3.99.7 (BERKSHIRE) #0: Fri Aug 12 01:48:51 EDT 2005 smb@berkshire.machshav.com:/usr/BUILD/obj/sys/arch/i386/compile/BERKSHIRE i386
Architecture: i386
Machine: i386
>Description:
	Using pkgsrc head, print/mpage won't compile:

	===> Building for mpage-2.5
	 cc -O2 -O2 -s -DPAGE_DEF= -DLIBDIR=\"/usr/pkg/share/mpage\" -DDEFAULT_ENCODING=1
	  -DDEFAULTSMARGIN=20 -DSPOOLER=BSD_SPOOLER -Wall  -c glob.c
	 glob.c:303: error: parse error before ';' token
	 glob.c:389:16: #if with no expression
	 glob.c:391:16: #if with no expression
	 glob.c:393:16: #if with no expression
	 *** Error code 1

	 Stop.
	 make: stopped in /usr/pkgsrc/print/mpage/work/mpage-2.5
	 *** Error code 1

>How-To-Repeat:
	cd /usr/pkgsrc/print/mpage && make
>Fix:
	The problem is that in Makefile, there is no uncommented
	definition for PAGESIZE.  Either PAGE_LETTER or PAGE_A4
	should be used.

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: smb@cs.columbia.edu
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/31102: print/mpage won't compile
Date: Mon, 5 Sep 2005 00:24:06 +0200

 On Tue, Aug 30, 2005 at 06:35:00PM +0000, smb@cs.columbia.edu wrote:
 > 	The problem is that in Makefile, there is no uncommented
 > 	definition for PAGESIZE.  Either PAGE_LETTER or PAGE_A4
 > 	should be used.

 What is your setting of PAPERSIZE?

 mk/defaults/mk.conf contains:
 PAPERSIZE?=  A4
 so it defaults to a sane value, and mpage/Makefile uses
 the PAPERSIZE variable to add a PAGESIZE value to MAKEFLAGS.

 mk/defaults/mk.conf claims support for "A4" and "Letter",
 and mpage compiles fine for me with either.

  Thomas

From: "Steven M. Bellovin" <smb@cs.columbia.edu>
To: Thomas Klausner <wiz@NetBSD.org>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/31102: print/mpage won't compile 
Date: Sun, 04 Sep 2005 19:22:57 -0400

 In message <20050904222406.GA7876@dmath5.geometrie.tuwien.ac.at>, Thomas Klausn
 er writes:
 >On Tue, Aug 30, 2005 at 06:35:00PM +0000, smb@cs.columbia.edu wrote:
 >> 	The problem is that in Makefile, there is no uncommented
 >> 	definition for PAGESIZE.  Either PAGE_LETTER or PAGE_A4
 >> 	should be used.
 >
 >What is your setting of PAPERSIZE?
 >
 >mk/defaults/mk.conf contains:
 >PAPERSIZE?=  A4
 >so it defaults to a sane value, and mpage/Makefile uses
 >the PAPERSIZE variable to add a PAGESIZE value to MAKEFLAGS.
 >
 >mk/defaults/mk.conf claims support for "A4" and "Letter",
 >and mpage compiles fine for me with either.
 >
 > Thomas
 >


 I have PAPERSIZE=Letter set, to keep LaTeX happy for the country I live 
 in...

 		--Steven M. Bellovin, http://www.cs.columbia.edu/~smb


From: Thomas Klausner <wiz@NetBSD.org>
To: "Steven M. Bellovin" <smb@cs.columbia.edu>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/31102: print/mpage won't compile
Date: Mon, 5 Sep 2005 02:56:53 +0200

 On Sun, Sep 04, 2005 at 07:22:57PM -0400, Steven M. Bellovin wrote:
 > I have PAPERSIZE=Letter set, to keep LaTeX happy for the country I live 
 > in...

 As I said, this setting works for me too, on 3.99.8/i386.
 What does
 	make show-var VARNAME=MAKEFLAGS
 report?
  Thomas

State-Changed-From-To: open->closed
State-Changed-By: wiz@netbsd.org
State-Changed-When: Mon, 05 Sep 2005 01:08:23 +0000
State-Changed-Why:
Problem mysteriously disappeared.
Works for me too, so I'll close the PR.


State-Changed-From-To: closed->open
State-Changed-By: reed@netbsd.org
State-Changed-When: Tue, 20 Sep 2005 19:37:33 +0000
State-Changed-Why:
I reopened this. I have the problem also.
When building direct in print/mpage it works.
But when building foomatic-filters which depends on mpage, I get:
-DPAGE_DEF=  without any value.



State-Changed-From-To: open->closed
State-Changed-By: reed@netbsd.org
State-Changed-When: Tue, 20 Sep 2005 19:44:11 +0000
State-Changed-Why:
I fixed this. using MAKE_ENV instead of MAKEFLAGS.
Thanks for your PR.


From: "Jeremy C. Reed" <reed@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/31102 CVS commit: pkgsrc/print/mpage
Date: Tue, 20 Sep 2005 19:43:03 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	reed
 Date:		Tue Sep 20 19:43:03 UTC 2005

 Modified Files:
 	pkgsrc/print/mpage: Makefile

 Log Message:
 Use MAKE_ENV instead of MAKEFLAGS for setting the papersize.
 This fixes PR #31102 which I just reopened.

 The problem could be seen when installing another package
 that depends on mpage. But couldn't be seen when directly
 building within pkgsrc/print/mpage.


 To generate a diff of this commit:
 cvs rdiff -r1.14 -r1.15 pkgsrc/print/mpage/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.