NetBSD Problem Report #31126
From dholland@eecs.harvard.edu Sat Sep 3 07:16:26 2005
Return-Path: <dholland@eecs.harvard.edu>
Received: from tanaqui.eecs.harvard.edu (tanaqui.eecs.harvard.edu [140.247.60.239])
by narn.netbsd.org (Postfix) with ESMTP id 5DB5563B11E
for <gnats-bugs@gnats.NetBSD.org>; Sat, 3 Sep 2005 07:16:26 +0000 (UTC)
Message-Id: <20050903071520.4EA6AF8C3@tanaqui.eecs.harvard.edu>
Date: Sat, 3 Sep 2005 03:15:20 -0400 (EDT)
From: dholland@eecs.harvard.edu
Reply-To: dholland@eecs.harvard.edu
To: gnats-bugs@netbsd.org
Subject: bad suser checks in serial drivers
X-Send-Pr-Version: 3.95
>Number: 31126
>Category: kern
>Synopsis: serial device drivers check cr_uid instead of calling suser
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: kleink
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sat Sep 03 07:17:00 +0000 2005
>Closed-Date: Tue Sep 06 21:48:30 +0000 2005
>Last-Modified: Tue Sep 06 21:48:30 +0000 2005
>Originator: David A. Holland <dholland@eecs.harvard.edu>
>Release: NetBSD 3.99.7 (-20050718)
>Organization:
Harvard EECS
>Environment:
System: NetBSD tanaqui 3.99.7 NetBSD 3.99.7 (TANAQUI) #1: Mon Jul 18 21:43:19 EDT 2005 dholland@tanaqui:/usr/src/sys/arch/i386/compile/TANAQUI i386
Architecture: i386
Machine: i386
>Description:
Tonight I was compiling the cyclades driver for a research OS
I happened to notice a glitch: where it checks TS_XCLUDE it
does an explicit check of p->p_ucred->cr_uid instead of making
a call to suser().
Some grep work shows that, unsurprisingly, the problem seems
to be shared among nearly all serial/tty drivers, of which
there are a lot.
This is not a crisis, but it is incorrect, as the ASU flag in
p_acflag won't get set... and any future auditing or logging
logic that someone might add to suser() won't be reached.
The following patches apply to sys/dev/ic/cy.c, where I first
found it, and sys/dev/ic/com.c, which is most likely to be the
cut and paste source for any new drivers that appear. I don't
have time to hunt and kill all the other instances tonight,
but maybe soon. :-/
(I haven't actually tested these patches, but they hardly
demand it. I hope I haven't stuffed up in some stupid way.)
>How-To-Repeat:
n/a
>Fix:
Index: cy.c
===================================================================
RCS file: /cvsroot/src/sys/dev/ic/cy.c,v
retrieving revision 1.37
diff -u -r1.37 cy.c
--- cy.c 27 Feb 2005 00:27:01 -0000 1.37
+++ cy.c 3 Sep 2005 06:35:51 -0000
@@ -369,7 +369,8 @@
SET(tp->t_state, TS_CARR_ON);
else
CLR(tp->t_state, TS_CARR_ON);
- } else if (ISSET(tp->t_state, TS_XCLUDE) && p->p_ucred->cr_uid != 0) {
+ } else if (ISSET(tp->t_state, TS_XCLUDE) &&
+ suser(p->p_ucred, &p->p_acflag) != 0) {
return EBUSY;
} else {
s = spltty();
Index: com.c
===================================================================
RCS file: /cvsroot/src/sys/dev/ic/com.c,v
retrieving revision 1.234
diff -u -r1.234 com.c
--- com.c 21 Jun 2005 14:01:11 -0000 1.234
+++ com.c 3 Sep 2005 07:03:31 -0000
@@ -838,7 +838,7 @@
if (ISSET(tp->t_state, TS_ISOPEN) &&
ISSET(tp->t_state, TS_XCLUDE) &&
- p->p_ucred->cr_uid != 0)
+ suser(p->p_ucred, &p->p_acflag) != 0)
return (EBUSY);
s = spltty();
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: kern-bug-people->kleink
Responsible-Changed-By: kleink@netbsd.org
Responsible-Changed-When: Tue, 06 Sep 2005 09:19:51 +0000
Responsible-Changed-Why:
I'll handle this.
From: Klaus Klein <kleink@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/31126 CVS commit: src/sys/arch/alpha/a12
Date: Tue, 6 Sep 2005 20:24:01 +0000 (UTC)
Module Name: src
Committed By: kleink
Date: Tue Sep 6 20:24:01 UTC 2005
Modified Files:
src/sys/arch/alpha/a12: a12dc.c
Log Message:
Change the driver open function's conditional for overriding exclusive tty
use from checking the proc's uid to suser(9), and account for the use of
privileges. Noted by David Holland in PR kern/31126.
Also, dispose of a redundant instance of that check.
To generate a diff of this commit:
cvs rdiff -r1.12 -r1.13 src/sys/arch/alpha/a12/a12dc.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Klaus Klein <kleink@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/31126 CVS commit: src/sys
Date: Tue, 6 Sep 2005 20:46:38 +0000 (UTC)
Module Name: src
Committed By: kleink
Date: Tue Sep 6 20:46:38 UTC 2005
Modified Files:
src/sys/arch/pmax/dev: dc.c dtop.c
src/sys/arch/pmax/tc: scc.c
src/sys/dev/qbus: dhu.c
Log Message:
Change the driver open function's conditional for overriding exclusive tty
use from checking the proc's uid to suser(9), and account for the use of
privileges. Noted by David Holland in PR kern/31126.
Also change this to use the proc argument instead of curproc.
To generate a diff of this commit:
cvs rdiff -r1.79 -r1.80 src/sys/arch/pmax/dev/dc.c
cvs rdiff -r1.68 -r1.69 src/sys/arch/pmax/dev/dtop.c
cvs rdiff -r1.86 -r1.87 src/sys/arch/pmax/tc/scc.c
cvs rdiff -r1.38 -r1.39 src/sys/dev/qbus/dhu.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Klaus Klein <kleink@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/31126 CVS commit: src/sys/dev/ic
Date: Tue, 6 Sep 2005 21:36:55 +0000 (UTC)
Module Name: src
Committed By: kleink
Date: Tue Sep 6 21:36:55 UTC 2005
Modified Files:
src/sys/dev/ic: clmpcc.c
Log Message:
Change the driver open function's conditional for overriding exclusive tty
use from checking the proc's uid to suser(9), and account for the use of
privileges. Noted by David Holland in PR kern/31126.
Also, dispose of a redundant (and unreachable) instance of that check.
To generate a diff of this commit:
cvs rdiff -r1.24 -r1.25 src/sys/dev/ic/clmpcc.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Klaus Klein <kleink@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/31126 CVS commit: src/sys
Date: Tue, 6 Sep 2005 21:40:45 +0000 (UTC)
Module Name: src
Committed By: kleink
Date: Tue Sep 6 21:40:45 UTC 2005
Modified Files:
src/sys/arch/alpha/alpha: promcons.c
src/sys/arch/amiga/dev: ite.c mfc.c msc.c ser.c
src/sys/arch/arc/dev: pccons.c
src/sys/arch/arm/ep93xx: epcom.c
src/sys/arch/arm/iomd/console: console.c
src/sys/arch/arm/ixp12x0: ixp12x0_com.c
src/sys/arch/arm/s3c2xx0: sscom.c
src/sys/arch/arm/sa11x0: sa11x0_com.c
src/sys/arch/atari/dev: ite.c ser.c zs.c
src/sys/arch/bebox/isa: pccons.c
src/sys/arch/evbarm/dev: plcom.c
src/sys/arch/hp300/dev: dcm.c ite.c
src/sys/arch/hpcmips/tx: txcom.c
src/sys/arch/i386/isa: pccons.c
src/sys/arch/luna68k/dev: siotty.c
src/sys/arch/macppc/dev: z8530tty.c
src/sys/arch/mips/alchemy/dev: aucom.c
src/sys/arch/mips/sibyte/dev: sbjcn.c sbscn.c
src/sys/arch/pc532/dev: scn.c
src/sys/arch/pmax/dev: rcons.c
src/sys/arch/sh3/dev: sci.c scif.c
src/sys/arch/shark/shark: pccons.c
src/sys/arch/sparc/dev: kd.c
src/sys/arch/sparc64/dev: kd.c
src/sys/arch/sun2/dev: kd.c
src/sys/arch/sun3/dev: kd.c
src/sys/arch/vax/vax: gencons.c
src/sys/arch/x68k/dev: com.c ite.c
src/sys/arch/xen/xen: xencons.c
src/sys/dev/arcbios: arcbios_tty.c
src/sys/dev/dec: dz.c
src/sys/dev/hpc: biconsdev.c
src/sys/dev/ic: cd18xx.c com.c cy.c z8530tty.c
src/sys/dev/marvell: gtmpsc.c
src/sys/dev/pci: cz.c
src/sys/dev/qbus: dl.c
src/sys/dev/sbus: magma.c spif.c
src/sys/dev/usb: ucom.c ucycom.c
src/sys/dev/wscons: wsdisplay.c
Log Message:
Change the driver open function's conditional for overriding exclusive tty
use from checking the proc's uid to suser(9), and account for the use of
privileges. Noted by David Holland in PR kern/31126.
To generate a diff of this commit:
cvs rdiff -r1.24 -r1.25 src/sys/arch/alpha/alpha/promcons.c
cvs rdiff -r1.70 -r1.71 src/sys/arch/amiga/dev/ite.c
cvs rdiff -r1.36 -r1.37 src/sys/arch/amiga/dev/mfc.c
cvs rdiff -r1.29 -r1.30 src/sys/arch/amiga/dev/msc.c
cvs rdiff -r1.69 -r1.70 src/sys/arch/amiga/dev/ser.c
cvs rdiff -r1.39 -r1.40 src/sys/arch/arc/dev/pccons.c
cvs rdiff -r1.3 -r1.4 src/sys/arch/arm/ep93xx/epcom.c
cvs rdiff -r1.12 -r1.13 src/sys/arch/arm/iomd/console/console.c
cvs rdiff -r1.20 -r1.21 src/sys/arch/arm/ixp12x0/ixp12x0_com.c
cvs rdiff -r1.12 -r1.13 src/sys/arch/arm/s3c2xx0/sscom.c
cvs rdiff -r1.20 -r1.21 src/sys/arch/arm/sa11x0/sa11x0_com.c
cvs rdiff -r1.46 -r1.47 src/sys/arch/atari/dev/ite.c
cvs rdiff -r1.25 -r1.26 src/sys/arch/atari/dev/ser.c
cvs rdiff -r1.43 -r1.44 src/sys/arch/atari/dev/zs.c
cvs rdiff -r1.34 -r1.35 src/sys/arch/bebox/isa/pccons.c
cvs rdiff -r1.10 -r1.11 src/sys/arch/evbarm/dev/plcom.c
cvs rdiff -r1.66 -r1.67 src/sys/arch/hp300/dev/dcm.c
cvs rdiff -r1.67 -r1.68 src/sys/arch/hp300/dev/ite.c
cvs rdiff -r1.24 -r1.25 src/sys/arch/hpcmips/tx/txcom.c
cvs rdiff -r1.172 -r1.173 src/sys/arch/i386/isa/pccons.c
cvs rdiff -r1.14 -r1.15 src/sys/arch/luna68k/dev/siotty.c
cvs rdiff -r1.22 -r1.23 src/sys/arch/macppc/dev/z8530tty.c
cvs rdiff -r1.14 -r1.15 src/sys/arch/mips/alchemy/dev/aucom.c
cvs rdiff -r1.8 -r1.9 src/sys/arch/mips/sibyte/dev/sbjcn.c
cvs rdiff -r1.13 -r1.14 src/sys/arch/mips/sibyte/dev/sbscn.c
cvs rdiff -r1.64 -r1.65 src/sys/arch/pc532/dev/scn.c
cvs rdiff -r1.60 -r1.61 src/sys/arch/pmax/dev/rcons.c
cvs rdiff -r1.37 -r1.38 src/sys/arch/sh3/dev/sci.c
cvs rdiff -r1.40 -r1.41 src/sys/arch/sh3/dev/scif.c
cvs rdiff -r1.21 -r1.22 src/sys/arch/shark/shark/pccons.c
cvs rdiff -r1.34 -r1.35 src/sys/arch/sparc/dev/kd.c
cvs rdiff -r1.33 -r1.34 src/sys/arch/sparc64/dev/kd.c
cvs rdiff -r1.9 -r1.10 src/sys/arch/sun2/dev/kd.c
cvs rdiff -r1.42 -r1.43 src/sys/arch/sun3/dev/kd.c
cvs rdiff -r1.40 -r1.41 src/sys/arch/vax/vax/gencons.c
cvs rdiff -r1.35 -r1.36 src/sys/arch/x68k/dev/com.c
cvs rdiff -r1.40 -r1.41 src/sys/arch/x68k/dev/ite.c
cvs rdiff -r1.8 -r1.9 src/sys/arch/xen/xen/xencons.c
cvs rdiff -r1.9 -r1.10 src/sys/dev/arcbios/arcbios_tty.c
cvs rdiff -r1.16 -r1.17 src/sys/dev/dec/dz.c
cvs rdiff -r1.10 -r1.11 src/sys/dev/hpc/biconsdev.c
cvs rdiff -r1.10 -r1.11 src/sys/dev/ic/cd18xx.c
cvs rdiff -r1.235 -r1.236 src/sys/dev/ic/com.c
cvs rdiff -r1.37 -r1.38 src/sys/dev/ic/cy.c
cvs rdiff -r1.99 -r1.100 src/sys/dev/ic/z8530tty.c
cvs rdiff -r1.11 -r1.12 src/sys/dev/marvell/gtmpsc.c
cvs rdiff -r1.32 -r1.33 src/sys/dev/pci/cz.c
cvs rdiff -r1.29 -r1.30 src/sys/dev/qbus/dl.c
cvs rdiff -r1.29 -r1.30 src/sys/dev/sbus/magma.c
cvs rdiff -r1.2 -r1.3 src/sys/dev/sbus/spif.c
cvs rdiff -r1.57 -r1.58 src/sys/dev/usb/ucom.c
cvs rdiff -r1.4 -r1.5 src/sys/dev/usb/ucycom.c
cvs rdiff -r1.84 -r1.85 src/sys/dev/wscons/wsdisplay.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: kleink@netbsd.org
State-Changed-When: Tue, 06 Sep 2005 21:48:30 +0000
State-Changed-Why:
Fixed, thanks for the pointer. (I think I got them all...)
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.