NetBSD Problem Report #31131

From fun@mail.fukaumi.org  Sat Sep  3 18:23:23 2005
Return-Path: <fun@mail.fukaumi.org>
Received: from mail.fukaumi.org (mail.fukaumi.org [221.186.40.204])
	by narn.netbsd.org (Postfix) with ESMTP id 7FADE63B84C
	for <gnats-bugs@gnats.NetBSD.org>; Sat,  3 Sep 2005 18:23:22 +0000 (UTC)
Message-Id: <200509031823.j83IN6p04131@mail.fukaumi.org>
Date: Sun, 4 Sep 2005 03:23:06 +0900 (JST)
From: fun@naobsd.org
Reply-To: fun@naobsd.org
To: gnats-bugs@netbsd.org
Subject: [PATCH] Set multicast filter in if_emac.c::emac_init()
X-Send-Pr-Version: 3.95

>Number:         31131
>Category:       port-evbppc
>Synopsis:       [PATCH] Set multicast filter in if_emac.c::emac_init()
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    port-evbppc-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Sep 03 18:24:00 +0000 2005
>Closed-Date:    Tue Aug 05 05:33:01 +0000 2014
>Last-Modified:  Tue Aug 05 05:33:01 +0000 2014
>Originator:     FUKAUMI Naoki
>Release:        NetBSD 3.99.7
>Organization:
	FUKAUMI Naoki
>Environment:
System: NetBSD turion64.naobsd.org 3.99.7 NetBSD 3.99.7 (TURION64) #2: Tue Aug 16 19:43:57 JST 2005 root@turion64.naobsd.org:/usr/obj/amd64/sys/arch/amd64/compile/TURION64 amd64
Architecture: x86_64
Machine: amd64
>Description:
	emac(4) does not set multicast filter in emac_init(). It causes
	multicast table inconsistency between in-kernel and real device.
	(e.g. rtsol(8) at system startup will fail)
>How-To-Repeat:
	# echo ip6mode=autohost >> /etc/rc.conf
	# echo rtsol=YES rtsol_flags="emac0" >> /etc/rc.conf
>Fix:
	I have no time to test this patch, but it should work.
	(I made (maybe) same patch and tested it. But I lost it...)

	Please pull up to release branch.

Index: sys/arch/powerpc/ibm4xx/dev/if_emac.c
===================================================================
RCS file: /home/fun/cvsroot/NetBSD/src/sys/arch/powerpc/ibm4xx/dev/if_emac.c,v
retrieving revision 1.22
diff -u -p -r1.22 if_emac.c
--- sys/arch/powerpc/ibm4xx/dev/if_emac.c	30 Jan 2005 19:03:23 -0000	1.22
+++ sys/arch/powerpc/ibm4xx/dev/if_emac.c	3 Sep 2005 17:51:56 -0000
@@ -809,6 +809,11 @@ emac_init(struct ifnet *ifp)
 	    (ifp->if_flags & IFF_BROADCAST ? RMR_BAE : 0));

 	/*
+	 * Set multicast filter.
+	 */
+	emac_set_filter(sc);
+
+	/*
 	 * Set low- and urgent-priority request thresholds.
 	 */
 	EMAC_WRITE(sc, EMAC_TMR1,

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: mrg@NetBSD.org
State-Changed-When: Tue, 05 Aug 2014 05:33:01 +0000
State-Changed-Why:
this seems to have been fixed with:

revision 1.27
date: 2006-10-16 11:14:35 -0700;  author: kiyohara;  state: Exp;  lines: +8 -3;
branches:  1.27.4;
do bus_space_map() to get bus space handle in emacs_attach()


>Unformatted:

Home	PR Database Search