NetBSD Problem Report #31141

From njoly@pasteur.fr  Sun Sep  4 08:15:25 2005
Return-Path: <njoly@pasteur.fr>
Received: from electre.pasteur.fr (electre.pasteur.fr [157.99.64.120])
	by narn.netbsd.org (Postfix) with ESMTP id F07AB63B84C
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  4 Sep 2005 08:15:24 +0000 (UTC)
Message-Id: <20050904082035.5E76C4202A@cixy.dial.pasteur.fr>
Date: Sun,  4 Sep 2005 10:20:35 +0200 (CEST)
From: njoly@pasteur.fr
Reply-To: njoly@pasteur.fr
To: gnats-bugs@netbsd.org
Subject: -current kernel compilation failure with COM_DEBUG
X-Send-Pr-Version: 3.95

>Number:         31141
>Category:       kern
>Synopsis:       -current kernel compilation failure with COM_DEBUG
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Sep 04 08:16:00 +0000 2005
>Closed-Date:    Sun Sep 04 12:07:54 +0000 2005
>Last-Modified:  Sun Sep 04 12:07:54 +0000 2005
>Originator:     Nicolas Joly
>Release:        NetBSD 3.99.8
>Organization:
Institut Pasteur, Paris.
>Environment:
System: NetBSD cixy.dial.pasteur.fr 3.99.8 NetBSD 3.99.8 (CIXY) #15: Fri Sep 2 08:10:50 CEST 2005 njoly@cixy.dial.pasteur.fr:/local/src/NetBSD/obj/i386/sys/arch/i386/compile/CIXY i386
Architecture: i386
Machine: i386
>Description:
I just noticed that a kernel with COM_DEBUG option set won't compile:

--- com.o ---
/local/src/NetBSD/src/sys/dev/ic/com.c: In function `comopen':
/local/src/NetBSD/src/sys/dev/ic/com.c:936: warning: passing arg 2 of `comstatus' discards qualifiers from pointer target type
/local/src/NetBSD/src/sys/dev/ic/com.c: In function `comioctl':
/local/src/NetBSD/src/sys/dev/ic/com.c:1225: warning: passing arg 2 of `comstatus' discards qualifiers from pointer target type
/local/src/NetBSD/src/sys/dev/ic/com.c: In function `comparam':
/local/src/NetBSD/src/sys/dev/ic/com.c:1564: warning: passing arg 2 of `comstatus' discards qualifiers from pointer target type
/local/src/NetBSD/src/sys/dev/ic/com.c: In function `com_stsoft':
/local/src/NetBSD/src/sys/dev/ic/com.c:1968: warning: passing arg 2 of `comstatus' discards qualifiers from pointer target type
/local/src/NetBSD/src/sys/dev/ic/com.c: In function `comintr':
/local/src/NetBSD/src/sys/dev/ic/com.c:2217: warning: passing arg 2 of `comstatus' discards qualifiers from pointer target type
*** [com.o] Error code 1
1 error
>How-To-Repeat:
Try to compile a kernel with COM_DEBUG
>Fix:
Index: sys/dev/ic/com.c
===================================================================
RCS file: /cvsroot/src/sys/dev/ic/com.c,v
retrieving revision 1.234
diff -u -r1.234 com.c
--- sys/dev/ic/com.c	21 Jun 2005 14:01:11 -0000	1.234
+++ sys/dev/ic/com.c	4 Sep 2005 08:09:02 -0000
@@ -297,9 +297,9 @@
 #ifdef COM_DEBUG
 int	com_debug = 0;

-void comstatus(struct com_softc *, char *);
+void comstatus(struct com_softc *, const char *);
 void
-comstatus(struct com_softc *sc, char *str)
+comstatus(struct com_softc *sc, const char *str)
 {
 	struct tty *tp = sc->sc_tty;


>Release-Note:

>Audit-Trail:
From: Klaus Klein <kleink@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/31141 CVS commit: src/sys/dev/ic
Date: Sun,  4 Sep 2005 09:48:53 +0000 (UTC)

 Module Name:	src
 Committed By:	kleink
 Date:		Sun Sep  4 09:48:53 UTC 2005

 Modified Files:
 	src/sys/dev/ic: com.c

 Log Message:
 Make COM_DEBUG compile again in the wake of -Wwrite-strings;
 from Nicolas Joly in PR kern/31141.


 To generate a diff of this commit:
 cvs rdiff -r1.234 -r1.235 src/sys/dev/ic/com.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: kleink@netbsd.org
State-Changed-When: Sun, 04 Sep 2005 12:07:54 +0000
State-Changed-Why:
Fixed as suggested, thanks!


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.