NetBSD Problem Report #31306

From neil@daikokuya.co.uk  Tue Sep 13 13:09:23 2005
Return-Path: <neil@daikokuya.co.uk>
Received: from duron.akihabara.co.uk (h219-110-249-253.catv02.itscom.jp [219.110.249.253])
	by narn.netbsd.org (Postfix) with ESMTP id 40F1463B877
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 13 Sep 2005 13:09:18 +0000 (UTC)
Message-Id: <20050913130916.700C082B84@duron.akihabara.co.uk>
Date: Tue, 13 Sep 2005 22:09:16 +0900 (JST)
From: neil@daikokuya.co.uk
Reply-To: neil@daikokuya.co.uk
To: gnats-bugs@netbsd.org
Subject: Incorrect definitions of UCHAR_MAX and USHRT_MAX
X-Send-Pr-Version: 3.95

>Number:         31306
>Category:       lib
>Synopsis:       Incorrect definitions of UCHAR_MAX and USHRT_MAX
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 13 13:10:00 +0000 2005
>Closed-Date:    Sat Apr 12 23:37:46 +0000 2008
>Last-Modified:  Sat Apr 12 23:37:46 +0000 2008
>Originator:     neil@daikokuya.co.uk
>Release:        NetBSD 3.99.7
>Organization:
none
>Environment:
System: NetBSD duron.akihabara.co.uk 3.99.7 NetBSD 3.99.7 (GENERIC) #0: Sat Jul 30 12:56:56 JST 2005 root@duron.akihabara.co.uk:/usr/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
  The definitions of UCHAR_MAX and USHRT_MAX in <limits.h> are U-suffixed
hexadecimal constants.  This does not conform to the C standard (C90 and C99).
The standard requires they have the same type as would have integer-
promoted objects of type "unsigned char" and "unsigned short", i.e. type
"int".  However with U suffixes the constants have type "unsigned int".
>How-To-Repeat:
>Fix:
  Redefine as unsuffixed hex constants, which are always correct for the
integer promotions, regardless of the relative sizes of char, short and
int.

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->feedback
State-Changed-By: drochner@netbsd.org
State-Changed-When: Fri, 31 Aug 2007 16:25:34 +0000
State-Changed-Why:
fix committed to -current


From: Matthias Drochner <drochner@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/31306 CVS commit: src/regress/include
Date: Fri, 31 Aug 2007 16:20:50 +0000 (UTC)

 Module Name:	src
 Committed By:	drochner
 Date:		Fri Aug 31 16:20:50 UTC 2007

 Modified Files:
 	src/regress/include: Makefile
 Added Files:
 	src/regress/include/stdint: Makefile stdint.c

 Log Message:
 Add a check for correct definition of UCHAR_MAX/USHRT_MAX and related
 types. C99 requires that these definitions promote to (signed/unsigned)
 integer the same way as the types the definition is for. And since
 unsigned char/short fit into an "int" on all our archs and thus promote
 to signed int, the definitions must not be unsigned.
 Addresses PR lib/31306 by Neil Booth.


 To generate a diff of this commit:
 cvs rdiff -r1.9 -r1.10 src/regress/include/Makefile
 cvs rdiff -r0 -r1.1 src/regress/include/stdint/Makefile \
     src/regress/include/stdint/stdint.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Matthias Drochner <drochner@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/31306 CVS commit: src/sys/arch
Date: Fri, 31 Aug 2007 16:24:27 +0000 (UTC)

 Module Name:	src
 Committed By:	drochner
 Date:		Fri Aug 31 16:24:27 UTC 2007

 Modified Files:
 	src/sys/arch/alpha/include: int_limits.h limits.h
 	src/sys/arch/amd64/include: int_limits.h limits.h
 	src/sys/arch/arm/include: int_limits.h limits.h
 	src/sys/arch/hppa/include: int_limits.h limits.h
 	src/sys/arch/i386/include: int_limits.h limits.h
 	src/sys/arch/ia64/include: int_limits.h limits.h
 	src/sys/arch/m68k/include: int_limits.h limits.h
 	src/sys/arch/mips/include: int_limits.h limits.h
 	src/sys/arch/pc532/include: int_limits.h limits.h
 	src/sys/arch/powerpc/include: int_limits.h limits.h
 	src/sys/arch/sh3/include: int_limits.h limits.h
 	src/sys/arch/sparc/include: int_limits.h limits.h
 	src/sys/arch/vax/include: int_limits.h limits.h

 Log Message:
 Fix definitions of UCHAR_MAX/USHRT_MAX and related
 types. C99 requires that these definitions promote to (signed/unsigned)
 integer the same way as the types the definition is for. And since
 unsigned char/short fit into an "int" on all our archs and thus promote
 to signed int, the definitions must not be unsigned.
 Fixes PR lib/31306 by Neil Booth.


 To generate a diff of this commit:
 cvs rdiff -r1.4 -r1.5 src/sys/arch/alpha/include/int_limits.h
 cvs rdiff -r1.10 -r1.11 src/sys/arch/alpha/include/limits.h
 cvs rdiff -r1.3 -r1.4 src/sys/arch/amd64/include/int_limits.h
 cvs rdiff -r1.7 -r1.8 src/sys/arch/amd64/include/limits.h
 cvs rdiff -r1.5 -r1.6 src/sys/arch/arm/include/int_limits.h
 cvs rdiff -r1.6 -r1.7 src/sys/arch/arm/include/limits.h
 cvs rdiff -r1.3 -r1.4 src/sys/arch/hppa/include/int_limits.h
 cvs rdiff -r1.6 -r1.7 src/sys/arch/hppa/include/limits.h
 cvs rdiff -r1.5 -r1.6 src/sys/arch/i386/include/int_limits.h
 cvs rdiff -r1.18 -r1.19 src/sys/arch/i386/include/limits.h
 cvs rdiff -r1.1 -r1.2 src/sys/arch/ia64/include/int_limits.h
 cvs rdiff -r1.2 -r1.3 src/sys/arch/ia64/include/limits.h
 cvs rdiff -r1.4 -r1.5 src/sys/arch/m68k/include/int_limits.h
 cvs rdiff -r1.17 -r1.18 src/sys/arch/m68k/include/limits.h
 cvs rdiff -r1.5 -r1.6 src/sys/arch/mips/include/int_limits.h
 cvs rdiff -r1.20 -r1.21 src/sys/arch/mips/include/limits.h
 cvs rdiff -r1.6 -r1.7 src/sys/arch/pc532/include/int_limits.h
 cvs rdiff -r1.16 -r1.17 src/sys/arch/pc532/include/limits.h
 cvs rdiff -r1.5 -r1.6 src/sys/arch/powerpc/include/int_limits.h
 cvs rdiff -r1.13 -r1.14 src/sys/arch/powerpc/include/limits.h
 cvs rdiff -r1.5 -r1.6 src/sys/arch/sh3/include/int_limits.h
 cvs rdiff -r1.8 -r1.9 src/sys/arch/sh3/include/limits.h
 cvs rdiff -r1.4 -r1.5 src/sys/arch/sparc/include/int_limits.h
 cvs rdiff -r1.16 -r1.17 src/sys/arch/sparc/include/limits.h
 cvs rdiff -r1.4 -r1.5 src/sys/arch/vax/include/int_limits.h
 cvs rdiff -r1.14 -r1.15 src/sys/arch/vax/include/limits.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Neil Booth <neil@daikokuya.co.uk>
To: gnats-bugs@gnats.netbsd.org
Cc: 
Subject: Re: lib/31306
Date: Wed, 5 Mar 2008 23:05:02 +0900

 Looks good, thanks.

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 12 Apr 2008 23:37:46 +0000
State-Changed-Why:
fixed, thanks


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.