NetBSD Problem Report #31443

From hira@po6.nsk.ne.jp  Sun Oct  2 06:13:10 2005
Return-Path: <hira@po6.nsk.ne.jp>
Received: from firefly.localdomain (adsl-2-8026.adsl.nsk.ne.jp [61.198.93.26])
	by narn.netbsd.org (Postfix) with ESMTP id C7CB163B8CC
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  2 Oct 2005 06:13:09 +0000 (UTC)
Message-Id: <20051002061308.0FC85A508@firefly.localdomain>
Date: Sun,  2 Oct 2005 15:13:08 +0900 (JST)
From: hira@po6.nsk.ne.jp
To: gnats-bugs@netbsd.org
Subject: audio/faad2 refers to nonexistent header
X-Send-Pr-Version: 3.95

>Number:         31443
>Category:       pkg
>Synopsis:       audio/faad2 refers to nonexistent header
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    ben
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Oct 02 06:14:00 +0000 2005
>Closed-Date:    Sun Oct 09 03:31:24 +0000 2005
>Last-Modified:  Sun Oct 09 09:09:00 +0000 2005
>Originator:     Kouichirou Hiratsuka
>Release:        NetBSD 3.99.9
>Organization:
>Environment:
System: NetBSD firefly.localdomain 3.99.9 NetBSD 3.99.9 (PBG4) #150: Sat Oct 1 16:13:39 JST 2005 root@firefly.localdomain:/usr/src/sys/arch/macppc/compile/PBG4 macppc
Architecture: powerpc
Machine: macppc
>Description:
	audio/faad2 installs ${PREFIX}/include/systems.h.  It includes
	config.h.  However config.h does not exist.

# cd /usr/pkgsrc/audio/faad2 && make && make install && exit
[snip]
% echo "#include \"mp4.h\"" > foo.c
% echo "int main() { return 0; }" >> foo.c
% cc -I/usr/pkg/include -o foo foo.c
In file included from /usr/pkg/include/mpeg4ip.h:28,
                 from /usr/pkg/include/mp4.h:27,
                 from foo.c:1:
/usr/pkg/include/systems.h:34:20: config.h: No such file or directory
/usr/pkg/include/systems.h:160:2: #error "Don't have stdint.h or inttypes.h - no way to get uint8_t"
In file included from /usr/pkg/include/mpeg4ip.h:28,
                 from /usr/pkg/include/mp4.h:27,
                 from foo.c:1:
/usr/pkg/include/systems.h:228: warning: redefinition of `__in_port_t'
/usr/include/sys/ansi.h:47: warning: `__in_port_t' previously declared here
/usr/pkg/include/systems.h:232: warning: redefinition of `__socklen_t'
/usr/include/sys/ansi.h:52: warning: `__socklen_t' previously declared here
%

>How-To-Repeat:
	see above

>Fix:
	Sorry, I don't know.

>Release-Note:

>Audit-Trail:
From: Antoine Reilles <Antoine.Reilles@loria.fr>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/31443: audio/faad2 refers to nonexistent header
Date: Wed, 5 Oct 2005 14:32:12 +0200

 --G4iJoqBmSsgzjUCe
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable

 I fixed it under netbsd by just removing the offending test, adding patch-aj

 The thing here was to make sure uint8_t is defined, and at least under Netb=
 sd,
 uint8_t is defined in sys/types.h, which is already included by systems.h


 $NetBSD$

 --- common/mp4v2/systems.h.orig	2003-06-29 23:41:00.000000000 +0200
 +++ common/mp4v2/systems.h
 @@ -157,9 +157,11 @@ int gettimeofday(struct timeval *t, void
  #ifdef HAVE_STDINT_H
  #include <stdint.h>
  #else
 +#if 0
  #error "Don't have stdint.h or inttypes.h - no way to get uint8_t"
  #endif
  #endif
 +#endif
 =20
  #include <unistd.h>
  #include <fcntl.h>

 --G4iJoqBmSsgzjUCe
 Content-Type: application/pgp-signature
 Content-Disposition: inline

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.2 (NetBSD)

 iD8DBQFDQ8fM4VqmoGDE/mwRAr5EAJ9o4tnx3sF3Cudh/MhNDW/IzYGJVwCeMC+J
 /5twb3HH2+2bjQaLLo7EPLo=
 =QL4/
 -----END PGP SIGNATURE-----

 --G4iJoqBmSsgzjUCe--

From: Ben Collver <collver@peak.org>
To: pkg-bug-handler@NetBSD.org
Cc: gnats-bugs@netbsd.org
Subject: Re: pkg/31443: audio/faad2 refers to nonexistent header
Date: Wed, 5 Oct 2005 21:36:37 -0700

 Hi Antoine,

 Removing that test does not address the original problem report,
 that config.h does not exist.

 Here is a patch that may fix the issue:

 http://terrorpin.net/~ben/docs/comp/unix/netbsd/pkgsrc/faad2.diff

 Cheers,

 Ben

From: Ben Collver <collver@peak.org>
To: pkg-bug-handler@NetBSD.org
Cc: gnats-bugs@netbsd.org
Subject: Re: pkg/31443: audio/faad2 refers to nonexistent header
Date: Wed, 5 Oct 2005 21:38:33 -0700

 I forgot to mention: after the patch, change the command line to:

 cc -I/usr/pkg/include/faad2 -o foo foo.c

 Ben

From: Ben Collver <collver@peak.org>
To: pkg-bug-handler@NetBSD.org
Cc: gnats-bugs@netbsd.org
Subject: Re: pkg/31443: audio/faad2 refers to nonexistent header
Date: Wed, 5 Oct 2005 21:45:27 -0700

 While I am at it, this also needs to be changed after the patch:

 Index: buildlink3.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/audio/faad2/buildlink3.mk,v
 retrieving revision 1.4
 diff -u -r1.4 buildlink3.mk
 --- buildlink3.mk       3 Oct 2004 00:13:05 -0000       1.4
 +++ buildlink3.mk       6 Oct 2005 04:43:53 -0000
 @@ -14,6 +14,7 @@
  BUILDLINK_DEPENDS.faad2+=      faad2>=2.0
  BUILDLINK_RECOMMENDED.faad2+=  faad2>=2.0nb1
  BUILDLINK_PKGSRCDIR.faad2?=    ../../audio/faad2
 +BUILDLINK_INCDIRS.faad2?=      include/faad2
  .endif # FAAD2_BUILDLINK3_MK

  BUILDLINK_DEPTH:=     ${BUILDLINK_DEPTH:S/+$//}

Responsible-Changed-From-To: pkg-manager->ben
Responsible-Changed-By: ben@netbsd.org
Responsible-Changed-When: Thu, 06 Oct 2005 13:10:13 +0000
Responsible-Changed-Why:
Assigned to self.


From: Ben Collver <ben@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/31443 CVS commit: pkgsrc/audio/faad2
Date: Thu,  6 Oct 2005 13:13:29 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	ben
 Date:		Thu Oct  6 13:13:29 UTC 2005

 Modified Files:
 	pkgsrc/audio/faad2: Makefile PLIST buildlink3.mk distinfo
 	pkgsrc/audio/faad2/patches: patch-aa patch-ac
 Added Files:
 	pkgsrc/audio/faad2/patches: patch-aj patch-ak

 Log Message:
 This change addresses PR#31443

 Install header files in include/faad2

 Install include/faad2/config.h

 Add include/faad2 to search path in buildlink3.mk

 Since software depending on mp4.h won't be able to build without this
 change, bump PKGREVISION and update BUILDLINK_DEPENDS.faad2 in
 buildlink3.mk


 To generate a diff of this commit:
 cvs rdiff -r1.26 -r1.27 pkgsrc/audio/faad2/Makefile
 cvs rdiff -r1.3 -r1.4 pkgsrc/audio/faad2/PLIST
 cvs rdiff -r1.4 -r1.5 pkgsrc/audio/faad2/buildlink3.mk
 cvs rdiff -r1.7 -r1.8 pkgsrc/audio/faad2/distinfo
 cvs rdiff -r1.2 -r1.3 pkgsrc/audio/faad2/patches/patch-aa \
     pkgsrc/audio/faad2/patches/patch-ac
 cvs rdiff -r0 -r1.1 pkgsrc/audio/faad2/patches/patch-aj \
     pkgsrc/audio/faad2/patches/patch-ak

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Ben Collver <collver@peak.org>
To: hira@po6.nsk.ne.jp, gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/31443
Date: Thu, 6 Oct 2005 06:18:28 -0700

 Good day Kouichirou Hiratsuka,

 I have committed a fix for pkg/31443 to cvs.  Would you update
 audio/faad2 to the latest version and verify that it solves the problem?

 Thank you for the bug report,

 Ben

From: Kouichirou Hiratsuka <hira@po6.nsk.ne.jp>
To: Ben Collver <collver@peak.org>
Cc: gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/31443
Date: Fri, 07 Oct 2005 01:09:58 +0900

 Hello,

 At Thu, 6 Oct 2005 06:18:28 -0700,
 Ben Collver wrote:
 > 
 > I have committed a fix for pkg/31443 to cvs.  Would you update
 > audio/faad2 to the latest version and verify that it solves the problem?
 > 
 Thanks.  I can compile the test program.  However, the other
 problems have appeared.

 I've added an inclusion of audio/faad2/buildlink3.mk to the
 audio/gtkpod/Makefile of my local tree.  But this package can't
 compile with the audio/faad2.

 # cd /usr/pkgsrc/audio/gtkpod
 # vi Makefile [add inclusion of audio/faad2/buildlink3.mk]
 # make
 [snip]
 In file included from /usr/pkgsrc/audio/gtkpod/work/.buildlink/include/faad2/mpeg4ip.h:28,
                  from /usr/pkgsrc/audio/gtkpod/work/.buildlink/include/faad2/mp4.h:27,
                  from mp4file.c:136:
 /usr/pkgsrc/audio/gtkpod/work/.buildlink/include/faad2/systems.h:228: warning: redefinition of `__in_port_t'
 /usr/include/sys/ansi.h:47: warning: `__in_port_t' previously declared here
 /usr/pkgsrc/audio/gtkpod/work/.buildlink/include/faad2/systems.h:232: warning: redefinition of `__socklen_t'
 /usr/include/sys/ansi.h:52: warning: `__socklen_t' previously declared here
 /usr/pkgsrc/audio/gtkpod/work/.buildlink/include/faad2/systems.h:273: error: redefinition of `gchar'
 /usr/pkgsrc/audio/gtkpod/work/.buildlink/include/glib/glib-2.0/glib/gtypes.h:41: error: `gchar' previously declared here
 /usr/pkgsrc/audio/gtkpod/work/.buildlink/include/faad2/systems.h:274: error: redefinition of `guchar'
 /usr/pkgsrc/audio/gtkpod/work/.buildlink/include/glib/glib-2.0/glib/gtypes.h:47: error: `guchar' previously declared here
 [snip]
 *** Error code 1

 Stop.
 make: stopped in /usr/pkgsrc/audio/gtkpod
 # 

 If a package generates config.h by configure, the faad2/config.h
 is not included.  It is defining HAVE_IN_PORT_T and HAVE_SOCKLEN_T.
 If it is read, the top two errors do not happen.

 And the faad2/systems.h has definitions of glib's types (gchar,
 etc.).  These definitions exist in ifdef HAVE_GLIB_H.  But I can't
 find definition of HAVE_GLIB_H anywhere.

 best regards.
 --
  Kouichirou Hiratsuka
    hira@po6.nsk.ne.jp

From: Ben Collver <ben@NetBSD.org>
To: Kouichirou Hiratsuka <hira@po6.nsk.ne.jp>
Cc: gnats-bugs@netbsd.org
Subject: Re: pkg/31443
Date: Sat, 8 Oct 2005 09:34:03 -0700

 Hello,

 Would you try the following patch and let me know whether it solves the
 issue with gtkpod?

 http://terrorpin.net/~ben/docs/comp/unix/netbsd/pkgsrc/faad2-2.diff

 I made this after reading the following posts:

 http://lists.gnu.org/archive/html/automake/2000-10/msg00108.html
 http://lists.gnu.org/archive/html/automake/2000-10/msg00114.html

 Thank you,

 Ben

From: Ben Collver <ben@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/31443 CVS commit: pkgsrc/audio/faad2
Date: Sun,  9 Oct 2005 03:23:11 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	ben
 Date:		Sun Oct  9 03:23:11 UTC 2005

 Modified Files:
 	pkgsrc/audio/faad2: Makefile PLIST buildlink3.mk distinfo
 	pkgsrc/audio/faad2/patches: patch-ac patch-ak
 Added Files:
 	pkgsrc/audio/faad2/patches: patch-al

 Log Message:
 This change addresses PR#31443

 Copy config.h to faad2-config.h.  Modify systems.h to refer to
 faad2-config.h, and install faad2-config.h.  This situation is
 discussed here:
 http://lists.gnu.org/archive/html/automake/2000-10/msg00114.html

 Remove the undef of PACKAGE and VERSION, and add a 3rd non-empty
 argument to AM_INIT_AUTOMAKE.  This situation is discussed here:
 http://lists.gnu.org/archive/html/automake/2000-10/msg00108.html

 Modify the condition from HAVE_GLIB_H to __G_LIB_H__, which was
 easier because faad2 doesn't depend on glib.

 Bump pkgrevision.


 To generate a diff of this commit:
 cvs rdiff -r1.27 -r1.28 pkgsrc/audio/faad2/Makefile
 cvs rdiff -r1.4 -r1.5 pkgsrc/audio/faad2/PLIST
 cvs rdiff -r1.5 -r1.6 pkgsrc/audio/faad2/buildlink3.mk
 cvs rdiff -r1.8 -r1.9 pkgsrc/audio/faad2/distinfo
 cvs rdiff -r1.3 -r1.4 pkgsrc/audio/faad2/patches/patch-ac
 cvs rdiff -r1.1 -r1.2 pkgsrc/audio/faad2/patches/patch-ak
 cvs rdiff -r0 -r1.1 pkgsrc/audio/faad2/patches/patch-al

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: ben@netbsd.org
State-Changed-When: Sun, 09 Oct 2005 03:31:24 +0000
State-Changed-Why:
Kouichirou Hiratsuka verified that the problem is resolved.
Thanks again for the report!


From: Kouichirou Hiratsuka <hira@po6.nsk.ne.jp>
To: Ben Collver <ben@NetBSD.org>
Cc: gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org
Subject: Re: pkg/31443
Date: Sun, 09 Oct 2005 11:45:33 +0900

 Hello,

 At Sat, 8 Oct 2005 09:34:03 -0700,
 Ben Collver wrote:
 > 
 > Would you try the following patch and let me know whether it solves the
 > issue with gtkpod?
 > 
 > http://terrorpin.net/~ben/docs/comp/unix/netbsd/pkgsrc/faad2-2.diff
 > 
 It works fine with gtkpod and faac.  Please commit.
 Thanks a lot!
 -- 
  Kouichirou Hiratsuka
    hira@po6.nsk.ne.jp

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.