NetBSD Problem Report #31570

From ghen@telenet.be  Wed Oct 12 19:30:00 2005
Return-Path: <ghen@telenet.be>
Received: from asia.telenet-ops.be (asia.telenet-ops.be [195.130.137.74])
	by narn.netbsd.org (Postfix) with ESMTP id EE51B63B878
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 12 Oct 2005 19:29:59 +0000 (UTC)
Message-Id: <200510121929.j9CJTwsf011053@localhost.>
Date: Wed, 12 Oct 2005 21:29:58 +0200 (CEST)
From: Geert Hendrickx <ghen@telenet.be>
To: gnats-bugs@netbsd.org
Subject: sysutils/bacula update to 1.36.3
X-Send-Pr-Version: 3.95

>Number:         31570
>Category:       pkg
>Synopsis:       sysutils/bacula update to 1.36.3
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 12 19:30:00 +0000 2005
>Closed-Date:    Fri Oct 14 20:42:57 +0000 2005
>Last-Modified:  Sun Oct 16 22:33:00 +0000 2005
>Originator:     Geert Hendrickx
>Release:        NetBSD 2.1_RC5
>Organization:

>Environment:


System: NetBSD mantis 2.1_RC5 NetBSD 2.1_RC5 (MANTIS) #0: Tue Sep 20 13:08:45 CEST 2005 geert@mantis:/cvs/obj/sys/arch/i386/compile/MANTIS i386
Architecture: i386
Machine: i386
>Description:

This is an update for sysutils/bacula version to version 1.36.3, the
latest version on its stable branch.  

One patch was added (patch-ag), because this version uses statvfs(2),
which NetBSD 2.0.x doesn't have.  Simply replacing it with statfs(2)
works nicely.  

I also moved the .include "../../mk/bsd.pkg.mk" line from
Makefile.common to Makefile, as is more common (and necessary once this
package will be split in -server and -client parts).  

Please note that this version still is vulnerable to
http://secunia.com/advisories/16866/
This issue has been fixed in CVS, but no new release on the 1.36.x
branch has been made yet.  I'll try to pullup the changes into patches/.  
>How-To-Repeat:

>Fix:

Here's the diff: 

? patches/patch-ag
Index: Makefile
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/sysutils/bacula/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- Makefile	16 Jan 2005 19:34:45 -0000	1.3
+++ Makefile	12 Oct 2005 19:22:57 -0000
@@ -1,5 +1,5 @@
 # $NetBSD: Makefile,v 1.3 2005/01/16 19:34:45 kristerw Exp $

-PKGREVISION=	1
-
 .include "Makefile.common"
+
+.include "../../mk/bsd.pkg.mk"
Index: Makefile.common
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/sysutils/bacula/Makefile.common,v
retrieving revision 1.10
diff -u -r1.10 Makefile.common
--- Makefile.common	10 Oct 2005 17:04:15 -0000	1.10
+++ Makefile.common	12 Oct 2005 19:22:57 -0000
@@ -1,7 +1,7 @@
 # $NetBSD: Makefile.common,v 1.10 2005/10/10 17:04:15 hira Exp $
 #

-DISTNAME=		bacula-1.36.0
+DISTNAME=		bacula-1.36.3
 CATEGORIES=		sysutils
 MASTER_SITES=		${MASTER_SITE_SOURCEFORGE:=bacula/}

@@ -80,4 +80,3 @@
 .include "../../devel/zlib/buildlink3.mk"
 .include "../../security/tcp_wrappers/buildlink3.mk"
 .include "../../mk/pthread.buildlink3.mk"
-.include "../../mk/bsd.pkg.mk"
Index: distinfo
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/sysutils/bacula/distinfo,v
retrieving revision 1.2
diff -u -r1.2 distinfo
--- distinfo	24 Feb 2005 13:40:50 -0000	1.2
+++ distinfo	12 Oct 2005 19:22:57 -0000
@@ -1,9 +1,10 @@
 $NetBSD: distinfo,v 1.2 2005/02/24 13:40:50 agc Exp $

-SHA1 (bacula-1.36.0.tar.gz) = 022606a36bb5c094a8e212c57c0f41d83b458172
-RMD160 (bacula-1.36.0.tar.gz) = a005ad833f006bd5f074f973d6e2f6ef69964d62
-Size (bacula-1.36.0.tar.gz) = 6806740 bytes
+SHA1 (bacula-1.36.3.tar.gz) = 4b3366e43fd4a8b6cbdc23e86ea20da6933d0f75
+RMD160 (bacula-1.36.3.tar.gz) = e8fb6eee221e261ac5b927019f9e69256cfb1732
+Size (bacula-1.36.3.tar.gz) = 11153154 bytes
 SHA1 (patch-aa) = 3369d0c37108f05828ea7c33b7aabc287e0213fd
 SHA1 (patch-ac) = 295dbf7fc6d1f5104b13d37a8ff32ea8580d4019
 SHA1 (patch-ae) = ad4b7d5cb83f021235c11504a034def897fffcac
 SHA1 (patch-af) = 926e74b83a09f4620672ffb8419d9ea22983d231
+SHA1 (patch-ag) = 62a982073fea267bc87c4dbb5691cf4d8c26c204


and here's the new patches/patch-ag file:

$NetBSD$

--- src/findlib/fstype.c.orig	2005-04-05 19:23:56.000000000 +0200
+++ src/findlib/fstype.c
@@ -82,8 +82,8 @@ bool fstype(const char *fname, char *fs,

 bool fstype(const char *fname, char *fs, int fslen)
 {
-   struct statvfs st;
-   if (statvfs(fname, &st) == 0) {
+   struct statfs st;
+   if (statfs(fname, &st) == 0) {
       bstrncpy(fs, st.f_fstypename, fslen);
       return true;
    }

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: Geert Hendrickx <ghen@telenet.be>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/31570: sysutils/bacula update to 1.36.3
Date: Wed, 12 Oct 2005 21:39:03 +0200

 On Wed, Oct 12, 2005 at 07:30:00PM +0000, Geert Hendrickx wrote:
 > One patch was added (patch-ag), because this version uses statvfs(2),
 > which NetBSD 2.0.x doesn't have.  Simply replacing it with statfs(2)
 > works nicely.  

 But, sadly, is the wrong solution, since this will break the build
 on 3.x. It should be a configure test and an appropriate #ifdef in
 the code... Does the bacula configure script already check for it?
 If not, plan b (actually, a hack) is to add #ifdefs for older NetBSD
 versions which only support statfs; see for example
 sysutils/coreutils/patches/patch-ab.

 Cheers,
  Thomas

From: Geert Hendrickx <ghen@telenet.be>
To: Thomas Klausner <wiz@NetBSD.org>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/31570: sysutils/bacula update to 1.36.3
Date: Thu, 13 Oct 2005 10:09:00 +0200

 On Wed, Oct 12, 2005 at 09:39:03PM +0200, Thomas Klausner wrote:
 > On Wed, Oct 12, 2005 at 07:30:00PM +0000, Geert Hendrickx wrote:
 > > One patch was added (patch-ag), because this version uses statvfs(2),
 > > which NetBSD 2.0.x doesn't have.  Simply replacing it with statfs(2)
 > > works nicely.  
 > 
 > But, sadly, is the wrong solution, since this will break the build on
 > 3.x. It should be a configure test and an appropriate #ifdef in the
 > code... Does the bacula configure script already check for it?  If not,
 > plan b (actually, a hack) is to add #ifdefs for older NetBSD versions
 > which only support statfs; see for example
 > sysutils/coreutils/patches/patch-ab.

 No, the configure script doesn't test for it.  But your hack worked (I
 tested on both 2.x and 3.x this time).  I wanted to do it this way first:
 http://sprg.ssl.berkeley.edu/~fastops/ITOS/portable/statfs_vs_statvfs.html
 but NetBSD doesn't have such defines.  Anyway, here's a new patch-ag:

 ===>
 $NetBSD$

 --- src/findlib/fstype.c.orig	2005-04-05 19:23:56.000000000 +0200
 +++ src/findlib/fstype.c
 @@ -80,10 +80,14 @@ bool fstype(const char *fname, char *fs,
  #include <sys/param.h>
  #include <sys/mount.h>

 +#if (__NetBSD_Version__ > 299000000)
 +#define statfs statvfs
 +#endif
 +
  bool fstype(const char *fname, char *fs, int fslen)
  {
 -   struct statvfs st;
 -   if (statvfs(fname, &st) == 0) {
 +   struct statfs st;
 +   if (statfs(fname, &st) == 0) {
        bstrncpy(fs, st.f_fstypename, fslen);
        return true;
     }
 <===

 	Geert

From: Geert Hendrickx <ghen@telenet.be>
To: gnats-bugs@netbsd.org
Cc: wiz@netbsd.org
Subject: Re: pkg/31570: additional: fix for security issue with bacula =< 1.37.39
Date: Thu, 13 Oct 2005 10:59:45 +0200

 This security vulnerability: http://www.zataz.net/adviso/bacula-09192005.txt
 has been fixed in the latest 1.37.x release of bacula.  Since this is their
 -beta branch, and we decided to stay on the stable (1.36.x) branch (amongst
 other changes, 1.37.x seems to use an incompatible database format), I have
 taken the security-relevant part of the diffs on the trunk and applied them
 to 1.36.3.  The resulting patch is to be included as patches/patch-ah: 

 ===>
 $NetBSD$

 --- autoconf/randpass.orig	2002-11-09 16:55:22.000000000 +0100
 +++ autoconf/randpass
 @@ -8,7 +8,14 @@ if test "x$1" = "x" ; then
  else
     PWL=$1
  fi 
 -tmp=/tmp/p.tmp.$$    
 +tmp=`mktemp randpass.XXXXXXXXXX`
 +if test x$tmp = x; then
 +   tmp=/tmp/p.tmp.$$    
 +   if test -f $tmp; then
 +      echo "Temp file security problem on: $tmp"
 +      exit 1
 +   fi
 +fi
  cp autoconf/randpass.bc $tmp
  ps | sum | tr -d ':[:alpha:] ' | sed 's/^/k=/' >>$tmp
  date | tr -d ':[:alpha:] ' | sed 's/^/k=k*/' >>$tmp
 <===

 --- distinfo.orig	2005-10-13 10:53:40.000000000 +0200
 +++ distinfo		2005-10-13 10:53:41.000000000 +0200
 @@ -8,3 +8,4 @@
  SHA1 (patch-ae) = ad4b7d5cb83f021235c11504a034def897fffcac
  SHA1 (patch-af) = 926e74b83a09f4620672ffb8419d9ea22983d231
  SHA1 (patch-ag) = d955ad9fb3772471580518c6528c898263333521
 +SHA1 (patch-ah) = 40ef8d3719e8ad2ba5c24de8d5661b3bfbbb5806

 (this diff is to be applied after my earlier update to 1.36.3 with the
 latest patches/patch-ag)

 For unambigious versioning (with and without the vulnerability), I propose
 we immediatly bump the PKGREVISION to 1 and do: 

 --- pkg-vulnerabilities.orig	2005-10-13 10:56:50.000000000 +0200
 +++ pkg-vulnerabilities		2005-10-13 10:57:09.000000000 +0200
 @@ -1458,7 +1458,7 @@
  nss_ldap<240		information-disclosure		http://cve.mitre.org/cgi-bin/cvename.cgi?name=CAN-2005-2069
  opera<8.50		cross-site-scripting		http://secunia.com/advisories/16645/
  opera<8.50		file-spoofing			http://secunia.com/advisories/16645/
 -bacula<1.37.39		insecure-temp-files		http://secunia.com/advisories/16866/
 +bacula<1.36.3nb1	insecure-temp-files		http://secunia.com/advisories/16866/
  firefox{,-bin,-gtk1,-gtk2,-gtk2-bin}<1.0.7	remote-command-execution	http://www.frsirt.com/english/advisories/2005/1794
  ruby16-base<1.6.8nb2	access-validation-bypass	http://jvn.jp/jp/JVN%2362914675/index.html
  ruby18-base<1.8.2nb4	access-validation-bypass	http://jvn.jp/jp/JVN%2362914675/index.html

 	Geert

From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@netbsd.org, pkg-manager@netbsd.org,
	gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Cc: 
Subject: Re: pkg/31570: sysutils/bacula update to 1.36.3
Date: Thu, 13 Oct 2005 08:01:09 -0400

 On Oct 13,  8:14am, ghen@telenet.be (Geert Hendrickx) wrote:
 -- Subject: Re: pkg/31570: sysutils/bacula update to 1.36.3

 |  No, the configure script doesn't test for it.  But your hack worked (I
 |  tested on both 2.x and 3.x this time).  I wanted to do it this way first:
 |  http://sprg.ssl.berkeley.edu/~fastops/ITOS/portable/statfs_vs_statvfs.html
 |  but NetBSD doesn't have such defines.  Anyway, here's a new patch-ag:

 "NetBSD does not have such defines"? Nobody has those defines, they are
 defined in config.h by autoconf. The proper fix is to add in configure.in
 AC_CHECK_HEADER(sys/statvfs.h) like it is suggested in that URL for solaris
 and not use the __NetBSD_Version__ macro.

 christos

From: Geert Hendrickx <ghen@telenet.be>
To: gnats-bugs@netbsd.org
Cc: wiz@netbsd.org, christos@zoulas.com
Subject: Re: pkg/31570: additional: fix for security issue with bacula =< 1.37.39
Date: Thu, 13 Oct 2005 19:07:36 +0200

 > "NetBSD does not have such defines"? Nobody has those defines, they are
 > defined in config.h by autoconf. The proper fix is to add in configure.in
 > AC_CHECK_HEADER(sys/statvfs.h) like it is suggested in that URL for
 > solaris and not use the __NetBSD_Version__ macro.

 Sorry, I didn't know that.  I'm not at all familiar with autoconf, but I
 looked into it, and fixed it on autoconf-level.  

 Here is a tarball containing all diffs and new files for the update and the
 security fix: 

 http://lori.mine.nu:5190/pkgsrc/bacula.tar.gz

 	Geert


 PS: please keep me CC'ed, thanks.  

From: christos@zoulas.com (Christos Zoulas)
To: Geert Hendrickx <ghen@telenet.be>, gnats-bugs@netbsd.org
Cc: wiz@netbsd.org
Subject: Re: pkg/31570: additional: fix for security issue with bacula =< 1.37.39
Date: Thu, 13 Oct 2005 15:08:19 -0400

 On Oct 13,  7:07pm, ghen@telenet.be (Geert Hendrickx) wrote:
 -- Subject: Re: pkg/31570: additional: fix for security issue with bacula =< 

 | > "NetBSD does not have such defines"? Nobody has those defines, they are
 | > defined in config.h by autoconf. The proper fix is to add in configure.in
 | > AC_CHECK_HEADER(sys/statvfs.h) like it is suggested in that URL for
 | > solaris and not use the __NetBSD_Version__ macro.
 | 
 | Sorry, I didn't know that.  I'm not at all familiar with autoconf, but I
 | looked into it, and fixed it on autoconf-level.  

 No need to apologize (I think noone can claim familiarity with that beast),
 and thank you for doing all the work!

 | Here is a tarball containing all diffs and new files for the update and the
 | security fix: 
 | 
 | http://lori.mine.nu:5190/pkgsrc/bacula.tar.gz
 | 
 | 	Geert
 | 
 | 
 | PS: please keep me CC'ed, thanks.  

 Will do.

 christos

From: Geert Hendrickx <ghen@telenet.be>
To: christos@zoulas.com
Cc: gnats-bugs@netbsd.org, wiz@netbsd.org
Subject: Re: pkg/31570: additional: fix for security issue with bacula =< 1.37.39
Date: Fri, 14 Oct 2005 11:00:12 +0200

 On Thu, Oct 13, 2005 at 07:07:36PM +0200, Geert Hendrickx wrote:
 > > "NetBSD does not have such defines"? Nobody has those defines, they are
 > > defined in config.h by autoconf. The proper fix is to add in configure.in
 > > AC_CHECK_HEADER(sys/statvfs.h) like it is suggested in that URL for
 > > solaris and not use the __NetBSD_Version__ macro.
 > 
 > Sorry, I didn't know that.  I'm not at all familiar with autoconf, but I
 > looked into it, and fixed it on autoconf-level.  
 > 
 > Here is a tarball containing all diffs and new files for the update and the
 > security fix: 
 > 
 > http://lori.mine.nu:5190/pkgsrc/bacula.tar.gz

 FYI, I sent the autoconf fix to the bacula people too, and it's in bacula
 1.37.41. :-)  

 	Geert

From: christos@zoulas.com (Christos Zoulas)
To: Geert Hendrickx <ghen@telenet.be>
Cc: gnats-bugs@netbsd.org, wiz@netbsd.org
Subject: Re: pkg/31570: additional: fix for security issue with bacula =< 1.37.39
Date: Fri, 14 Oct 2005 09:04:56 -0400

 On Oct 14, 11:00am, ghen@telenet.be (Geert Hendrickx) wrote:
 -- Subject: Re: pkg/31570: additional: fix for security issue with bacula =< 

 | FYI, I sent the autoconf fix to the bacula people too, and it's in bacula
 | 1.37.41. :-)  

 This is excellent :-) We can just upgrade to that then!

 christos

From: Geert Hendrickx <ghen@telenet.be>
To: Christos Zoulas <christos@zoulas.com>
Cc: gnats-bugs@netbsd.org, wiz@netbsd.org
Subject: Re: pkg/31570: additional: fix for security issue with bacula =< 1.37.39
Date: Fri, 14 Oct 2005 15:19:19 +0200

 On Fri, Oct 14, 2005 at 09:04:56AM -0400, Christos Zoulas wrote:
 > On Oct 14, 11:00am, ghen@telenet.be (Geert Hendrickx) wrote:
 > -- Subject: Re: pkg/31570: additional: fix for security issue with bacula =< 
 > 
 > | FYI, I sent the autoconf fix to the bacula people too, and it's in bacula
 > | 1.37.41. :-)  
 > 
 > This is excellent :-) We can just upgrade to that then!

 I discussed this with Thomas.  1.37.x is their beta-branch, and we decided
 to stick to 1.36.x for now (amongst other changes, 1.37 has an
 incompatible database format).  

 1.38 will be released in the beginning of November though, so then we can
 upgrade to that.  

 	Geert

State-Changed-From-To: open->closed
State-Changed-By: wiz@netbsd.org
State-Changed-When: Fri, 14 Oct 2005 20:42:57 +0000
State-Changed-Why:
Committed, thank you!


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/31570 CVS commit: pkgsrc/sysutils/bacula
Date: Fri, 14 Oct 2005 15:44:51 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Fri Oct 14 15:44:51 UTC 2005

 Modified Files:
 	pkgsrc/sysutils/bacula: Makefile Makefile.common distinfo
 Added Files:
 	pkgsrc/sysutils/bacula/patches: patch-ag patch-ah patch-ai patch-aj

 Log Message:
 Update to 1.36.3nb1, provided by Geert Hendrickx in PR 31570.
 This contains the update to 1.36.3 and an additional security fix,
 thus the nb1.

 Changes since 1.36.0:

 Changes to 1.36.3 released 23Apr05:
 22Apr05
 - Correct return type of ftello to avoid overflow --
   thanks to Peter Eriksson.
 13Apr05
 - Fix seg fault if Name directive missing in Job resource.
 12Apr05
 - Add new LaTeX doc to 1.36.2 branch.
 - Fix SuSE autostart routines to use /etc/init.d instead
   of /etc/rc.d/init.d.
 - Increase index size on File table Name and Path table Path
   to improve performance.
 - Second fix for not zeroing SD pointers on restarted job.
 - Turn off old style Include/Excludes.
 01Apr05
 - Use fseeko and ftello so that attributes can exceed 4GB
 - Flush console output after every line.
 - Turn off Multiple Connections in catalog resource, which
   causes corruped databases.  It is silently ignored.
 - Drop support for old style Include/Exclude.  There is a
   perl script that will convert them.
 - Inhibit trying to reset attributes on a Win32 drive.
 18Mar05 1.36.2-store.patch
 - This patch fails a job if no Storage resource is specified and
   the job attempts to call the SD.
 18Mar05 1.36.2-reschedule.patch
 - This patch should fix a Segfault bug when a job is rescheduled.
   The storage pointers were being released when they should not
   have been.
 17Mar05 1.36.2-restore-speed.patch
 - This patch will fix a subtle bug that was introduced in 1.36.2
   which causes Bacula to be very slow restoring a few files. This
   is because it reads completely to the end of the Volume rather
   than stopping when all the files on the Volume are loaded. The
   introduction of the bug was caused by a patch that fixed
   Bacula truncating tapes after a restore.
   Note that all source files will be rebuilt during the make.
 16Mar05 1.36.2-console.patch
 - This patch causes the output directed to a file to be
   flushed after every line. This is a bit overkill, IMO, but
   a user complained about it.
 15Mar05 1.36.2-netbsd.patch
 - This patch corrects a compile problem because of no statfs()
   on NetBSD. The patch was submitted by kardel with bug 258.
 09Mar05 1.36.2-win32-drive.patch
 - This patch will prevent the Win32 FD from printing an error message
   when it attempts to restore the permissions for a drive (which Win32
   doesn't permit). The error is harmless in any case.
 04Mar05 1.36.2-level.patch
 - This patch should fix a problem with th %l editing in the
   client (FD) where it edited nothing. With this fix, it should
   edit "since".
 04Mar05 1.36.2-pool.patch
 - This patch corrects a problem preventing multiple
   simultaneous jobs from different pools.

 Changes to 1.36.2 released 28Feb05:
 27Feb05
 - Fix pointer to stack variable in Verify jobs.
 - Change reference to DEV_BSIZE to B_DEV_BSIZE to
   avoid colision with some OSes.
 - Release storage[i] in job.c if allocated when
   starting/restarting a job. Avoids orpahanned buffers.
 24Feb05
 - Add awk check to configure.in
 - Bring over a few files from 1.37.
 18Feb05
 - Fix some lower case character problems in sql_cmds.c reported
   by Debian.
 - Fix seg fault if debug level 900 set in SD.
 - Truncate Win32 child return code to 8 bits.
 15Feb05
 - Fix deadlock in multiple simultaneous jobs.
 - Fix tape "truncation"/"number of files" after restore bug.
 - Merge a few minor things from the 1.37 stream.
 14Feb05
 - Add a number of new features from 1.37, and apply fixes
   for all known bugs. See ReleaseNotes for details.
 - Apply Tim's patch for ACLs.

 Version 1.36.1 released 26Nov04:
 24Nov04
 - Take Dan's fix to the fix_postgresql_tables (thanks Dan)
 - Increase Maximum Concurrent Jobs to 20 in SD and FD!
 - Fix improper handling of autochanger Volumes that are not
   marked InChanger.
 22Nov04
 - Update authentication failure message to indicate possible
   problem with Maximum Concurrent Jobs. Add to doc too.
 - Commit PostgreSQL BIGINT fix -- apparently some people didn't
   get it.
 - Do not use a slot unless it is InChanger in the autochanger
   code, otherwise autochanger gets upset not finding the Volume.
 21Nov04
 - Make authentication timeout compile time configurable.
   The value is set in src/baconfig.h
 - Fix removing items from watchdog queue, which apparently
   screwed up if there was more than one item.
 - Rework mediaformat part of manual to separate out old
   tape format for easier reading.
 - Add a lot of debug code to the authentication code.
 - Add seconds to the start/end times printed in the job report.
 19Nov04
 - Fix mutex deadlock in dequeue of messages.
 - Add debug code to FD authorization.
 18Nov04
 - Increase authentication timeouts to 10 minutes.
 15Nov04
 - Fix cancel bug in FD on /lib/tls with zero pid in
   pthread_kill.
 - Add date/time to all messages.
 - Make Qmsg use time message was queued rather than time
   printed.
 - Indent job output two spaces.
 13Nov04
 - Fix web page links for new manual.
 - Grant postgresql permission to cdimages.
 - Correct crash after "list nextvol" "list media" bug 160
 12Nov04
 - Fix scripts/Makefile.in missing ;\  -- thanks Martin
 - A bit of work on btape to keep if from going into infinite
   loops when things do not work well, and to print a bit
   better info.
 11Nov04
 - JobDefs Storage resource completely overrode anything
   specified in Job resource -- bug 159 -- fixed.
 - Fix syntax of renaming postgresql per Dan.
 - Add working_directory to be /tmp for wx_console.
 10Nov04
 - Allow both a JobId and a filename or list of files to be
   specified on a restore command line.
 - Save old mtx-changer before installing new one: bug 156
 - Fix errors in CDROM file pointed out by Scott.
 09Nov04
 - Fix exepath when Bacula executed without path.
 - Move test for socket libraries for Solaris in configure.in
   before tcp wrapper tests so that linking works.
 - Add "make copy-static-fd" to makefile in CDROM file to
   copy existing static fd to CDROM rather than building it.
 08Nov04
 - More doc updates
 - Fix ps command for OpenBSD
 - Rework the creation of indexes for SQL -- fall back
   to the old code, but document what can be added.
 06Nov04
 - Add new Daemon message handler in default DIR conf.
 05Nov04
 - Fix Seg Fault with -D100 in bpipe.c.
 - Fix Seg Fault in run specifying a JobId.
 - Make mail from daemon with a Messages Resource use
   the MailCommand with editing rather than the default
   sendmail.
 - Replace Jmsg in dispatch_message() with Qmsg.
 - Make edit_job_codes handle NULL jcr.
 04Nov04
 - Add M_ALERT class and put tape alerts into it.
 - Fix Verify count vs found by not double counting files
   that are split across files/Volumes.
 30Oct04
 - Fix count returned from write_bsr_file() to handle multiple
   volumes. This fixes most cases of the Verify VolumeToCatalog.
 - Cleanup a bit the make clean for the rescue cdrom and remove
   unneeded files from the CVS.
 28Oct04
 - Fixed acquiring a tape so that it does not block all acquires
   when operator intervention is needed.
 - Platform build script updates from Scott
 - Doc updates
 - Add patch to force Linux LD_ASSUME_KERNEL to avoid using the
   new /lib/tls. This is done in the startup scripts.
 - Modify mtx-changer so that it checks for ONLINE while
   waiting.
 - Modify make_postgresql_tables.in so that EndBlock is stored
   as a bigint. Prevents job failures when a disk volume is
   larger than 2GB.
 24Oct04
 - Add grep ONLINE to wait_for_drive() in mtx-changer.in
 - More doc.
 - Rebuild Scott's new configure


 To generate a diff of this commit:
 cvs rdiff -r1.3 -r1.4 pkgsrc/sysutils/bacula/Makefile
 cvs rdiff -r1.10 -r1.11 pkgsrc/sysutils/bacula/Makefile.common
 cvs rdiff -r1.2 -r1.3 pkgsrc/sysutils/bacula/distinfo
 cvs rdiff -r0 -r1.1 pkgsrc/sysutils/bacula/patches/patch-ag \
     pkgsrc/sysutils/bacula/patches/patch-ah \
     pkgsrc/sysutils/bacula/patches/patch-ai \
     pkgsrc/sysutils/bacula/patches/patch-aj

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Stoned Elipot <seb@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/31570 CVS commit: [pkgsrc-2005Q3] pkgsrc/sysutils/bacula
Date: Sun, 16 Oct 2005 22:32:57 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	seb
 Date:		Sun Oct 16 22:32:57 UTC 2005

 Modified Files:
 	pkgsrc/sysutils/bacula [pkgsrc-2005Q3]: Makefile Makefile.common
 	    distinfo
 Added Files:
 	pkgsrc/sysutils/bacula [pkgsrc-2005Q3]: options.mk
 	pkgsrc/sysutils/bacula/patches [pkgsrc-2005Q3]: patch-ag patch-ah
 	    patch-ai patch-aj
 Removed Files:
 	pkgsrc/sysutils/bacula [pkgsrc-2005Q3]: Makefile.options

 Log Message:
 Pullup ticket 837 - requested by Thomas Klausner
 sync bacula with HEAD, including a security update

 Revision pulled up:
 - pkgsrc/sysutils/bacula/Makefile		1.4
 - pkgsrc/sysutils/bacula/Makefile.common	1.7, 1.8, 1.9, 1.10, 1.11, 1.12
 - pkgsrc/sysutils/bacula/Makefile.options	removed
 - pkgsrc/sysutils/bacula/distinfo		1.3
 - pkgsrc/sysutils/bacula/options.mk		1.1, 1.2, 1.3
 - pkgsrc/sysutils/bacula/patches/patch-ag	1.1
 - pkgsrc/sysutils/bacula/patches/patch-ah	1.1
 - pkgsrc/sysutils/bacula/patches/patch-ai	1.1
 - pkgsrc/sysutils/bacula/patches/patch-aj	1.1

    Module Name:    pkgsrc
    Committed By:   mjl
    Date:           Tue Sep 27 22:37:25 UTC 2005

    Modified Files:
            pkgsrc/news/slrn: Makefile
            pkgsrc/security/pgp5: Makefile
            pkgsrc/sysutils/adjustkernel: Makefile
            pkgsrc/sysutils/bacula: Makefile.common

    Log Message:
    Relinquish maintainership
 ---
    Module Name:    pkgsrc
    Committed By:   wiz
    Date:           Fri Oct  7 11:30:35 UTC 2005

    Modified Files:
            pkgsrc/sysutils/bacula: Makefile.common
    Added Files:
            pkgsrc/sysutils/bacula: options.mk
    Removed Files:
            pkgsrc/sysutils/bacula: Makefile.options

    Log Message:
    Rename Makefile.options to options.mk (standardized name).
 ---
    Module Name:    pkgsrc
    Committed By:   wiz
    Date:           Fri Oct  7 11:33:28 UTC 2005

    Modified Files:
            pkgsrc/sysutils/bacula: options.mk

    Log Message:
    Use PKG_OPTIONS_REQUIRED_GROUPS for making sure only one option
    from a group is selected, instead of handling it manually.
    >From Geert Hendrickx on tech-pkg.
 ---
    Module Name:    pkgsrc
    Committed By:   wiz
    Date:           Mon Oct 10 15:27:45 UTC 2005

    Modified Files:
            pkgsrc/sysutils/bacula: Makefile.common options.mk

    Log Message:
    Add catalog-mysql option, from Geert Hendrickx on tech-pkg.
 ---
    Modified Files:
            pkgsrc/sysutils/bacula: Makefile.common

    Log Message:
    s/netbsd.org/NetBSD.org/
 ---
    Module Name:    pkgsrc
    Committed By:   wiz
    Date:           Fri Oct 14 15:44:51 UTC 2005

    Modified Files:
            pkgsrc/sysutils/bacula: Makefile Makefile.common distinfo
    Added Files:
            pkgsrc/sysutils/bacula/patches: patch-ag patch-ah patch-ai patch-aj

    Log Message:
    Update to 1.36.3nb1, provided by Geert Hendrickx in PR 31570.
    This contains the update to 1.36.3 and an additional security fix,
    thus the nb1.

    Changes since 1.36.0:

    Changes to 1.36.3 released 23Apr05:
    22Apr05
    - Correct return type of ftello to avoid overflow --
      thanks to Peter Eriksson.
    13Apr05
    - Fix seg fault if Name directive missing in Job resource.
    12Apr05
    - Add new LaTeX doc to 1.36.2 branch.
    - Fix SuSE autostart routines to use /etc/init.d instead
      of /etc/rc.d/init.d.
    - Increase index size on File table Name and Path table Path
      to improve performance.
    - Second fix for not zeroing SD pointers on restarted job.
    - Turn off old style Include/Excludes.
    01Apr05
    - Use fseeko and ftello so that attributes can exceed 4GB
    - Flush console output after every line.
    - Turn off Multiple Connections in catalog resource, which
      causes corruped databases.  It is silently ignored.
    - Drop support for old style Include/Exclude.  There is a
      perl script that will convert them.
    - Inhibit trying to reset attributes on a Win32 drive.
    18Mar05 1.36.2-store.patch
    - This patch fails a job if no Storage resource is specified and
      the job attempts to call the SD.
    18Mar05 1.36.2-reschedule.patch
    - This patch should fix a Segfault bug when a job is rescheduled.
      The storage pointers were being released when they should not
      have been.
    17Mar05 1.36.2-restore-speed.patch
    - This patch will fix a subtle bug that was introduced in 1.36.2
      which causes Bacula to be very slow restoring a few files. This
      is because it reads completely to the end of the Volume rather
      than stopping when all the files on the Volume are loaded. The
      introduction of the bug was caused by a patch that fixed
      Bacula truncating tapes after a restore.
      Note that all source files will be rebuilt during the make.
    16Mar05 1.36.2-console.patch
    - This patch causes the output directed to a file to be
      flushed after every line. This is a bit overkill, IMO, but
      a user complained about it.
    15Mar05 1.36.2-netbsd.patch
    - This patch corrects a compile problem because of no statfs()
      on NetBSD. The patch was submitted by kardel with bug 258.
    09Mar05 1.36.2-win32-drive.patch
    - This patch will prevent the Win32 FD from printing an error message
      when it attempts to restore the permissions for a drive (which Win32
      doesn't permit). The error is harmless in any case.
    04Mar05 1.36.2-level.patch
    - This patch should fix a problem with th %l editing in the
      client (FD) where it edited nothing. With this fix, it should
      edit "since".
    04Mar05 1.36.2-pool.patch
    - This patch corrects a problem preventing multiple
      simultaneous jobs from different pools.

    Changes to 1.36.2 released 28Feb05:
    27Feb05
    - Fix pointer to stack variable in Verify jobs.
    - Change reference to DEV_BSIZE to B_DEV_BSIZE to
      avoid colision with some OSes.
    - Release storage[i] in job.c if allocated when
      starting/restarting a job. Avoids orpahanned buffers.
    24Feb05
    - Add awk check to configure.in
    - Bring over a few files from 1.37.
    18Feb05
    - Fix some lower case character problems in sql_cmds.c reported
      by Debian.
    - Fix seg fault if debug level 900 set in SD.
    - Truncate Win32 child return code to 8 bits.
    15Feb05
    - Fix deadlock in multiple simultaneous jobs.
    - Fix tape "truncation"/"number of files" after restore bug.
    - Merge a few minor things from the 1.37 stream.
    14Feb05
    - Add a number of new features from 1.37, and apply fixes
      for all known bugs. See ReleaseNotes for details.
    - Apply Tim's patch for ACLs.

    Version 1.36.1 released 26Nov04:
    24Nov04
    - Take Dan's fix to the fix_postgresql_tables (thanks Dan)
    - Increase Maximum Concurrent Jobs to 20 in SD and FD!
    - Fix improper handling of autochanger Volumes that are not
      marked InChanger.
    22Nov04
    - Update authentication failure message to indicate possible
      problem with Maximum Concurrent Jobs. Add to doc too.
    - Commit PostgreSQL BIGINT fix -- apparently some people didn't
      get it.
    - Do not use a slot unless it is InChanger in the autochanger
      code, otherwise autochanger gets upset not finding the Volume.
    21Nov04
    - Make authentication timeout compile time configurable.
      The value is set in src/baconfig.h
    - Fix removing items from watchdog queue, which apparently
      screwed up if there was more than one item.
    - Rework mediaformat part of manual to separate out old
      tape format for easier reading.
    - Add a lot of debug code to the authentication code.
    - Add seconds to the start/end times printed in the job report.
    19Nov04
    - Fix mutex deadlock in dequeue of messages.
    - Add debug code to FD authorization.
    18Nov04
    - Increase authentication timeouts to 10 minutes.
    15Nov04
    - Fix cancel bug in FD on /lib/tls with zero pid in
      pthread_kill.
    - Add date/time to all messages.
    - Make Qmsg use time message was queued rather than time
      printed.
    - Indent job output two spaces.
    13Nov04
    - Fix web page links for new manual.
    - Grant postgresql permission to cdimages.
    - Correct crash after "list nextvol" "list media" bug 160
    12Nov04
    - Fix scripts/Makefile.in missing ;\  -- thanks Martin
    - A bit of work on btape to keep if from going into infinite
      loops when things do not work well, and to print a bit
      better info.
    11Nov04
    - JobDefs Storage resource completely overrode anything
      specified in Job resource -- bug 159 -- fixed.
    - Fix syntax of renaming postgresql per Dan.
    - Add working_directory to be /tmp for wx_console.
    10Nov04
    - Allow both a JobId and a filename or list of files to be
      specified on a restore command line.
    - Save old mtx-changer before installing new one: bug 156
    - Fix errors in CDROM file pointed out by Scott.
    09Nov04
    - Fix exepath when Bacula executed without path.
    - Move test for socket libraries for Solaris in configure.in
      before tcp wrapper tests so that linking works.
    - Add "make copy-static-fd" to makefile in CDROM file to
      copy existing static fd to CDROM rather than building it.
    08Nov04
    - More doc updates
    - Fix ps command for OpenBSD
    - Rework the creation of indexes for SQL -- fall back
      to the old code, but document what can be added.
    06Nov04
    - Add new Daemon message handler in default DIR conf.
    05Nov04
    - Fix Seg Fault with -D100 in bpipe.c.
    - Fix Seg Fault in run specifying a JobId.
    - Make mail from daemon with a Messages Resource use
      the MailCommand with editing rather than the default
      sendmail.
    - Replace Jmsg in dispatch_message() with Qmsg.
    - Make edit_job_codes handle NULL jcr.
    04Nov04
    - Add M_ALERT class and put tape alerts into it.
    - Fix Verify count vs found by not double counting files
      that are split across files/Volumes.
    30Oct04
    - Fix count returned from write_bsr_file() to handle multiple
      volumes. This fixes most cases of the Verify VolumeToCatalog.
    - Cleanup a bit the make clean for the rescue cdrom and remove
      unneeded files from the CVS.
    28Oct04
    - Fixed acquiring a tape so that it does not block all acquires
      when operator intervention is needed.
    - Platform build script updates from Scott
    - Doc updates
    - Add patch to force Linux LD_ASSUME_KERNEL to avoid using the
      new /lib/tls. This is done in the startup scripts.
    - Modify mtx-changer so that it checks for ONLINE while
      waiting.
    - Modify make_postgresql_tables.in so that EndBlock is stored
      as a bigint. Prevents job failures when a disk volume is
      larger than 2GB.
    24Oct04
    - Add grep ONLINE to wait_for_drive() in mtx-changer.in
    - More doc.
    - Rebuild Scott's new configure
 ---
    Module Name:    pkgsrc
    Committed By:   wiz
    Date:           Sun Oct 16 11:59:36 UTC 2005

    Modified Files:
            pkgsrc/sysutils/bacula: Makefile.common

    Log Message:
    Use INSTALL_DATA_DIR instead of MKDIR.


 To generate a diff of this commit:
 cvs rdiff -r1.3 -r1.3.6.1 pkgsrc/sysutils/bacula/Makefile
 cvs rdiff -r1.6 -r1.6.4.1 pkgsrc/sysutils/bacula/Makefile.common
 cvs rdiff -r1.2 -r0 pkgsrc/sysutils/bacula/Makefile.options
 cvs rdiff -r1.2 -r1.2.6.1 pkgsrc/sysutils/bacula/distinfo
 cvs rdiff -r0 -r1.3.2.1 pkgsrc/sysutils/bacula/options.mk
 cvs rdiff -r0 -r1.1.2.1 pkgsrc/sysutils/bacula/patches/patch-ag \
     pkgsrc/sysutils/bacula/patches/patch-ah \
     pkgsrc/sysutils/bacula/patches/patch-ai \
     pkgsrc/sysutils/bacula/patches/patch-aj

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.