NetBSD Problem Report #3179
Received: (qmail-queue invoked from smtpd); 2 Feb 1997 05:38:19 -0000
Message-Id: <199702012128.VAA28834@miyu.feyrer.net>
Date: Sat, 1 Feb 1997 21:28:59 GMT
From: Hubert Feyrer <feyrer@rfhs8012.fh-regensburg.de>
Reply-To: hubert.feyrer@rz.uni-regensburg.de
To: gnats-bugs@gnats.netbsd.org
Subject: tar doesn't check if conversion from to_oct was ok
X-Send-Pr-Version: 3.95
>Number: 3179
>Category: bin
>Synopsis: tar doesn't check if conversion from to_oct was ok
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: bin-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sat Feb 01 21:50:03 +0000 1997
>Closed-Date: Sat Jan 04 16:25:42 +0000 2003
>Last-Modified: Sat Jan 04 16:25:42 +0000 2003
>Originator: Hubert Feyrer
>Release: 1.2
>Organization:
Hubert Feyrer <hubert.feyrer@rz.uni-regensburg.de>
>Environment:
System: NetBSD miyu 1.2 NetBSD 1.2 (MIYU) #8: Sun Jan 26 20:34:03 MET 1997 feyrer@miyu:/usr/disk1/src12/sys/arch/i386/compile/MIYU i386
>Description:
When dumping a filesystem, tar invokes to_oct to convert major-
and minor-number, but doesn't check if there was an overflow in
the conversion. This could lead to incomplete dumps when doing
backups of device nodes.
This bug was found when comparing the tar command from NetBSD
V1.2 and FreeBSD-current (as of Feb 1st, 1997).
>How-To-Repeat:
ugh... :-}
>Fix:
diff -crNb /usr/src/gnu/usr.bin/tar/create.c /usr/homes/feyrer/work/FreeBSD/root/usr.src/tar/create.c
*** /usr/src/gnu/usr.bin/tar/create.c Sun Mar 27 09:26:59 1994
--- /usr/homes/feyrer/work/FreeBSD/root/usr.src/tar/create.c Tue Nov 12 22:44:00 1996
***************
*** 880,889 ****
#if defined(S_IFBLK) || defined(S_IFCHR)
if (type != LF_FIFO)
{
! to_oct ((long) major (hstat.st_rdev), 8,
! header->header.devmajor);
! to_oct ((long) minor (hstat.st_rdev), 8,
! header->header.devminor);
}
#endif
--- 875,894 ----
#if defined(S_IFBLK) || defined(S_IFCHR)
if (type != LF_FIFO)
{
! if (checked_to_oct ((long) major (hstat.st_rdev), 8,
! header->header.devmajor))
! {
! msg ("%s: major number too large; not dumped", p);
! critical_error = 1;
! goto badfile;
! }
! if (checked_to_oct ((long) minor (hstat.st_rdev), 8,
! header->header.devminor))
! {
! msg ("%s: minor number too large; not dumped", p);
! critical_error = 1;
! goto badfile;
! }
}
#endif
***************
*** 1398,1403 ****
--- 1403,1424 ----
while (digs > 0)
where[--digs] = ' ';
+ }
+
+
+ /*
+ * Call to_oct (), then return nonzero iff the conversion failed.
+ */
+ int
+ checked_to_oct (value, digs, where)
+ register long value;
+ register int digs;
+ register char *where;
+ {
+ long from_oct ();
+
+ to_oct (value, digs, where);
+ return from_oct (digs, where) != value;
}
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: jrf
State-Changed-When: Sat Jan 4 08:23:41 PST 2003
State-Changed-Why:
This PR is no longer relevant. I contacted the originator and he requested that it be closed.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.