NetBSD Problem Report #32268

From parag@codegen.com  Thu Dec  8 04:43:07 2005
Return-Path: <parag@codegen.com>
Received: from hammerhead.parag.codegen.com (64-142-13-79.dsl.static.sonic.net [64.142.13.79])
	by narn.netbsd.org (Postfix) with ESMTP id 6F1DA63B850
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  8 Dec 2005 04:43:07 +0000 (UTC)
Message-Id: <20051208044304.708FD2985@hammerhead.parag.codegen.com>
Date: Wed,  7 Dec 2005 20:43:04 -0800 (PST)
From: parag@codegen.com
Reply-To: parag@codegen.com
To: gnats-bugs@netbsd.org
Subject: pkg audio/faad2 bugfix for stdout
X-Send-Pr-Version: 3.95

>Number:         32268
>Category:       pkg
>Synopsis:       supurious newline char on stdout from faad screws up audio
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Dec 08 04:45:00 +0000 2005
>Closed-Date:    Thu Dec 08 16:55:26 +0000 2005
>Last-Modified:  Thu Dec 08 16:55:26 +0000 2005
>Originator:     Parag Patel
>Release:        NetBSD 2.1.0_STABLE
>Organization:
CodeGen, Inc.
>Environment:
System: NetBSD hammer.parag.codegen.com 2.1.0_STABLE NetBSD 2.1.0_STABLE (HAMMER) #0: Sun Nov 20 14:42:52 PST 2005 parag@hammerhead.parag.codegen.com:/usr/src/sys/arch/amd64/compile/HAMMER amd64
Architecture: x86_64
Machine: amd64
>Description:
	faad (pkgsrc/audio/faad2) can generate a bogus newline character on
	stdout if there are ID tags in an AAC (M4A) file.  This can mess up
	audio if that is also redirected to stdout, as it is by slimserver
	(for instance) before sending to a Squeezbox.

>How-To-Repeat:
	run "faad -w infile.m4a > out.wav" and "faad infile.m4a", then compare
	the generated files infile.wav and out.wav.

>Fix:
	The attached patch to main.c puts the newline character on stderr,
	where it should have been all along.

--- frontend/main.c.orig	2005-12-07 20:34:20.000000000 -0800
+++ frontend/main.c	2005-12-07 20:34:28.000000000 -0800
@@ -832,7 +832,7 @@
                 }
             }
         }
-        if (j > 0) printf("\n");
+        if (j > 0) fprintf(stderr, "\n");
 #endif
     }


>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->feedback
State-Changed-By: wiz@netbsd.org
State-Changed-When: Thu, 08 Dec 2005 10:07:12 +0000
State-Changed-Why:
Committed, thanks.
Did you send this patch upstream to the authors too?


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/32268 CVS commit: pkgsrc/audio/faad2
Date: Thu,  8 Dec 2005 10:06:32 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Thu Dec  8 10:06:32 UTC 2005

 Modified Files:
 	pkgsrc/audio/faad2: Makefile PLIST distinfo
 Added Files:
 	pkgsrc/audio/faad2/patches: patch-am

 Log Message:
 Write newline character to stderr instead of stdout, to avoid
 polluting the output stream when -w is used. From Parag Patel in PR 32268.
 While here, add missing directory to PLIST. Bump PKGREVISION.


 To generate a diff of this commit:
 cvs rdiff -r1.29 -r1.30 pkgsrc/audio/faad2/Makefile
 cvs rdiff -r1.5 -r1.6 pkgsrc/audio/faad2/PLIST
 cvs rdiff -r1.9 -r1.10 pkgsrc/audio/faad2/distinfo
 cvs rdiff -r0 -r1.1 pkgsrc/audio/faad2/patches/patch-am

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Parag Patel <parag@codegen.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org,
	gnats-admin@netbsd.org, wiz@netbsd.org
Subject: Re: pkg/32268 (supurious newline char on stdout from faad screws up audio) 
Date: Thu, 08 Dec 2005 08:02:30 -0800

 wiz@netbsd.org wrote:
 >Committed, thanks.
 >Did you send this patch upstream to the authors too?

 Thanks, and yes, I just sent it off.  Sure hope it's the right spot
 (sourceforge).
 -- 
   __
  /__)_ _ _ _    "Cleveland?  Yes, I spent a week there one day."
 /   (// (/(/
          _/

State-Changed-From-To: feedback->closed
State-Changed-By: wiz@netbsd.org
State-Changed-When: Thu, 08 Dec 2005 16:55:26 +0000
State-Changed-Why:
Fixed, and sent upstream. Thanks!


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.