NetBSD Problem Report #32441
From www@netbsd.org Tue Jan 3 01:35:56 2006
Return-Path: <www@netbsd.org>
Received: by narn.netbsd.org (Postfix, from userid 31301)
id 834CE63B9F4; Tue, 3 Jan 2006 01:35:56 +0000 (UTC)
Message-Id: <20060103013556.834CE63B9F4@narn.netbsd.org>
Date: Tue, 3 Jan 2006 01:35:56 +0000 (UTC)
From: nbgnats@anastigmatix.net
Reply-To: nbgnats@anastigmatix.net
To: gnats-bugs@netbsd.org
Subject: umidi input dropped data fix, plus quirks for Midiman Midisport 2x4
X-Send-Pr-Version: www-1.0
>Number: 32441
>Category: kern
>Synopsis: umidi input dropped data fix, plus quirks for Midiman Midisport 2x4
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: chap
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Tue Jan 03 01:40:00 +0000 2006
>Closed-Date: Thu Sep 14 16:59:51 +0000 2006
>Last-Modified: Thu Sep 14 16:59:51 +0000 2006
>Originator: Chapman Flack
>Release: 2.0
>Organization:
>Environment:
NetBSD lundestad.anastigmatix.net 2.0 NetBSD 2.0 (lundestad) #30: Mon Jan 2 19:13:25 EST 2006 xxx@xxx:/usr/src/sys/arch/i386/compile/lundestad i386
>Description:
Some time ago I added umidi quirks for the Midiman Midisport 2x4, a fairly
inexpensive (some places) 2 in / 4 out USB to MIDI adapter, and never got
around to submitting the patch. Here it is (link below) with respect to
2.0 sources, but I see in webcvs there's been so little activity on the
affected files it should be a breeze to apply.
Once I got the thing to work, I noticed that MIDI output was pretty
reliable but input wasn't; just playing a simple chord on the keyboard was
enough to get data dropped (very annoying in MIDI, because it might lose
the message for a key release, or get stuck reading velocities as notes
and vice versa). That turned out to be because umidi was doing input in
transfers of size 4 rather than wMaxPacketSize; after fixing that today, I
haven't been able to see a single dropped byte, even sending memory dumps
from the keyboard and such. This should improve input performance for
any umidi device, not just the Midiman.
>How-To-Repeat:
>Fix:
http://www.anastigmatix.net/cvsweb.cgi/NetBSD/midiman.pat
>Release-Note:
>Audit-Trail:
From: Chapman Flack <chap@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: PR/32441 CVS commit: src
Date: Fri, 30 Jun 2006 13:56:26 +0000 (UTC)
Module Name: src
Committed By: chap
Date: Fri Jun 30 13:56:26 UTC 2006
Modified Files:
src/share/man/man4: midi.4 umidi.4
src/sys/conf: files
src/sys/dev: midi.c midi_if.h midisyn.c midisynvar.h midivar.h
sequencer.c sequencervar.h
src/sys/dev/ic: opl.c oplvar.h
src/sys/dev/isa: cms.c midi_pcppi.c
src/sys/dev/isapnp: isapnpdevs isapnpdevs.c sb_isapnp.c
src/sys/dev/pci: eap.c eapreg.h
src/sys/dev/usb: umidi.c umidi_quirks.c umidi_quirks.h umidivar.h
usbdevs usbdevs.h usbdevs_data.h
src/sys/sys: midiio.h
Added Files:
src/sys/dev: midictl.c midictl.h
Log Message:
Ankh-Morpork, we have a MIDI driver....
Merge from chap-midi branch, after
~month for review
Comments by thorpej@ drochner@ and Alexandre Ratchov
Incorporated: points by thorpej@ drochner@; preliminary support for
a stats-collecting ioctl suggested by martin@ from comments by A.R.
PR kern/32441 kern/32442 kern/32567 kern/32588 kern/32694 kern/33590
kern/33614 and one instance of kern/32651
ok martin@
To generate a diff of this commit:
cvs rdiff -r1.24 -r1.25 src/share/man/man4/midi.4
cvs rdiff -r1.6 -r1.7 src/share/man/man4/umidi.4
cvs rdiff -r1.784 -r1.785 src/sys/conf/files
cvs rdiff -r1.43 -r1.44 src/sys/dev/midi.c
cvs rdiff -r1.17 -r1.18 src/sys/dev/midi_if.h src/sys/dev/midisyn.c
cvs rdiff -r0 -r1.2 src/sys/dev/midictl.c src/sys/dev/midictl.h
cvs rdiff -r1.9 -r1.10 src/sys/dev/midisynvar.h
cvs rdiff -r1.11 -r1.12 src/sys/dev/midivar.h
cvs rdiff -r1.31 -r1.32 src/sys/dev/sequencer.c
cvs rdiff -r1.10 -r1.11 src/sys/dev/sequencervar.h
cvs rdiff -r1.25 -r1.26 src/sys/dev/ic/opl.c
cvs rdiff -r1.12 -r1.13 src/sys/dev/ic/oplvar.h
cvs rdiff -r1.11 -r1.12 src/sys/dev/isa/cms.c
cvs rdiff -r1.12 -r1.13 src/sys/dev/isa/midi_pcppi.c
cvs rdiff -r1.60 -r1.61 src/sys/dev/isapnp/isapnpdevs
cvs rdiff -r1.64 -r1.65 src/sys/dev/isapnp/isapnpdevs.c
cvs rdiff -r1.47 -r1.48 src/sys/dev/isapnp/sb_isapnp.c
cvs rdiff -r1.83 -r1.84 src/sys/dev/pci/eap.c
cvs rdiff -r1.11 -r1.12 src/sys/dev/pci/eapreg.h
cvs rdiff -r1.25 -r1.26 src/sys/dev/usb/umidi.c
cvs rdiff -r1.10 -r1.11 src/sys/dev/usb/umidi_quirks.c
cvs rdiff -r1.4 -r1.5 src/sys/dev/usb/umidi_quirks.h
cvs rdiff -r1.8 -r1.9 src/sys/dev/usb/umidivar.h
cvs rdiff -r1.432 -r1.433 src/sys/dev/usb/usbdevs
cvs rdiff -r1.435 -r1.436 src/sys/dev/usb/usbdevs.h
cvs rdiff -r1.436 -r1.437 src/sys/dev/usb/usbdevs_data.h
cvs rdiff -r1.13 -r1.14 src/sys/sys/midiio.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Responsible-Changed-From-To: kern-bug-people->chap
Responsible-Changed-By: chap@netbsd.org
Responsible-Changed-When: Thu, 14 Sep 2006 16:59:51 +0000
Responsible-Changed-Why:
Made the changes.
State-Changed-From-To: open->closed
State-Changed-By: chap@netbsd.org
State-Changed-When: Thu, 14 Sep 2006 16:59:51 +0000
State-Changed-Why:
Addressed in chap-midi branch merged in June.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.