NetBSD Problem Report #3255

Received: (qmail-queue invoked from smtpd); 25 Feb 1997 09:51:16 -0000
Message-Id: <199702250946.KAA00858@lyssa.owl.de>
Date: Tue, 25 Feb 1997 10:46:58 +0100 (MET)
From: Matthias Scheler <tron@lyssa.owl.de>
Reply-To: tron@lyssa.owl.de
To: gnats-bugs@gnats.netbsd.org
Subject: uucpd should accept leading "\r" during chat
X-Send-Pr-Version: 3.95

>Number:         3255
>Category:       bin
>Synopsis:       uucpd should accept leading "\r" during chat
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 25 02:05:02 +0000 1997
>Closed-Date:    Fri Feb 13 23:15:36 +0000 1998
>Last-Modified:  Fri Feb 13 23:39:20 +0000 1998
>Originator:     Matthias Scheler
>Release:        970207
>Organization:
Matthias Scheler                                http://home.pages.de/~tron/
>Environment:
System: NetBSD lyssa 1.2C NetBSD 1.2C (LYSSA) #2: Wed Feb 19 18:23:15 MET 1997 tron@lyssa:/usr/src/sys/arch/i386/compile/LYSSA i386

>Description:
When I tried to setup an UUCP link for a Linux system using an old
Taylor UUCP 1.05 with an even older configuration style I got into
trouble because it always sends two carriage returns before the
login name. "uucpd" isn't very smart about this and terminates with
an "unknown user" message.

>How-To-Repeat:
telnet machine-with-uucpd-enabled uucp
enter <RETURN>

>Fix:
*** src/libexec/uucpd/uucpd.c.orig	Sun Dec  1 13:13:48 1996
--- src/libexec/uucpd/uucpd.c	Tue Feb 25 10:44:23 1997
*************** struct sockaddr_in *sinp;
*** 162,172 ****
  	struct passwd *pw, *getpwnam();

  	alarm(60);
! 	printf("login: "); fflush(stdout);
! 	if (readline(user, sizeof user) < 0) {
! 		fprintf(stderr, "user read\n");
! 		return;
! 	}
  	/* truncate username to 8 characters */
  	user[8] = '\0';
  	pw = getpwnam(user);
--- 162,174 ----
  	struct passwd *pw, *getpwnam();

  	alarm(60);
! 	do {
! 		printf("login: "); fflush(stdout);
! 		if (readline(user, sizeof user) < 0) {
! 			fprintf(stderr, "user read\n");
! 			return;
! 		}
! 	} while (user[0] == '\0');
  	/* truncate username to 8 characters */
  	user[8] = '\0';
  	pw = getpwnam(user);
>Release-Note:
>Audit-Trail:

From: Matthias Scheler <tron@lyssa.owl.de>
To: gnats-bugs@gnats.netbsd.org, gnats-admin@NetBSD.ORG
Cc:  Subject: Re: bin/3255: uucpd should accept leading "\r" during chat
Date: Tue, 3 Jun 1997 11:12:23 +0200

 On Tue, Feb 25, 1997 at 10:05:03AM -0000, gnats-bugs@gnats.netbsd.org wrote:
 > >Category:       bin
 > >Responsible:    bin-bug-people
 > >Synopsis:       uucpd should accept leading "\r" during chat
 > >Arrival-Date:   Tue Feb 25 02:05:02 1997

 Somehow the first patch got screwed up. Here's a working one:

 *** uucpd.c.orig	Tue Sep 17 20:57:02 1996
 --- uucpd.c	Wed May 14 19:48:04 1997
 *************** struct sockaddr_in *sinp;
 *** 161,173 ****
   	char *xpasswd, *crypt();
   	struct passwd *pw, *getpwnam();

 ! 	alarm(60);
 ! 	printf("login: "); fflush(stdout);
 ! 	if (readline(user, sizeof user) < 0) {
 ! 		fprintf(stderr, "user read\n");
 ! 		return;
 ! 	}
 ! 	/* truncate username to 8 characters */
   	user[8] = '\0';
   	pw = getpwnam(user);
   	if (pw == NULL) {
 --- 161,175 ----
   	char *xpasswd, *crypt();
   	struct passwd *pw, *getpwnam();

 !         alarm(60);
 !         do {
 !                 printf("login: "); fflush(stdout);
 !                 if (readline(user, sizeof user) < 0) {
 !                         fprintf(stderr, "user read\n");
 !                         return;
 !                 }
 !         } while (user[0] == '\0');
 !         /* truncate username to 8 characters */
   	user[8] = '\0';
   	pw = getpwnam(user);
   	if (pw == NULL) {

 -- 
 Matthias Scheler                                http://home.pages.de/~tron/
State-Changed-From-To: open->closed 
State-Changed-By: tron 
State-Changed-When: Fri Feb 13 15:15:36 PST 1998 
State-Changed-Why:  
Patch applied. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.