NetBSD Problem Report #32637
From www@netbsd.org Thu Jan 26 07:15:45 2006
Return-Path: <www@netbsd.org>
Received: by narn.netbsd.org (Postfix, from userid 31301)
id 961A663B879; Thu, 26 Jan 2006 07:15:45 +0000 (UTC)
Message-Id: <20060126071545.961A663B879@narn.netbsd.org>
Date: Thu, 26 Jan 2006 07:15:45 +0000 (UTC)
From: g.mcgarry@ieee.org
Reply-To: g.mcgarry@ieee.org
To: gnats-bugs@netbsd.org
Subject: tspc doesn't install correctly
X-Send-Pr-Version: www-1.0
>Number: 32637
>Category: pkg
>Synopsis: tspc doesn't install correctly
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: ghen
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Thu Jan 26 07:20:00 +0000 2006
>Closed-Date: Thu Feb 23 10:19:56 +0000 2006
>Last-Modified: Thu Feb 23 10:20:02 +0000 2006
>Originator: Gregory McGarry
>Release: NetBSD-current
>Organization:
>Environment:
>Description:
net/tspc package was recently updated, so PR#32093 looks like it can be closed.
However, the pkg doesn't install the necessary template files and the configuration file contains the following entry:
tsp_dir=/usr/pkgsrc/net/tspc/work/tspc2
When you do a make clean in the pkgsrc directory to clean up, the configuration files are also blown away.
>How-To-Repeat:
cd net/tspc && make install
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: pkg-manager->ghen
Responsible-Changed-By: ghen@netbsd.org
Responsible-Changed-When: Thu, 26 Jan 2006 08:58:25 +0000
Responsible-Changed-Why:
I'll take it.
From: Geert Hendrickx <ghen@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/32637 (tspc doesn't install correctly)
Date: Mon, 30 Jan 2006 13:11:49 +0100
--x+6KMIRAuhnl3hBn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Good point. The attached patch should fix it. Please let me know if it
works for you.
Geert
--x+6KMIRAuhnl3hBn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="tspc.diff"
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/net/tspc/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- Makefile 15 Jan 2006 11:36:50 -0000 1.13
+++ Makefile 30 Jan 2006 12:07:58 -0000
@@ -26,6 +26,7 @@
.endif
MAKE_ENV+= target=${TARGET:Q}
+MAKE_ENV+= configdir=${PREFIX}/share/tspc
WRKSRC= ${WRKDIR}/tspc2
@@ -34,11 +35,18 @@
RCD_SCRIPTS= tspc
+PLIST_SUBST+= TARGET=${TARGET}
+
do-install:
${INSTALL_PROGRAM} ${WRKSRC}/bin/tspc ${PREFIX}/sbin/
${INSTALL_MAN} ${WRKSRC}/man/man5/tspc.conf.5 ${PREFIX}/${PKGMANDIR}/man5/
${INSTALL_MAN} ${WRKSRC}/man/man8/tspc.8 ${PREFIX}/${PKGMANDIR}/man8/
${INSTALL_DATA_DIR} ${PREFIX}/share/examples/tspc/
${INSTALL_DATA} ${WRKSRC}/bin/tspc.conf.sample ${PREFIX}/share/examples/tspc/tspc.conf
+ ${INSTALL_DATA_DIR} ${PREFIX}/share/tspc/ ${PREFIX}/share/tspc/template/
+ ${INSTALL_SCRIPT} ${WRKSRC}/template/${TARGET}.sh ${PREFIX}/share/tspc/template/
+ ${INSTALL_SCRIPT} ${WRKSRC}/template/checktunnel.sh ${PREFIX}/share/tspc/template/
+ ${INSTALL_DATA} ${WRKSRC}/template/README ${PREFIX}/share/tspc/template/
+ ${INSTALL_DATA} ${WRKSRC}/template/variables_environ ${PREFIX}/share/tspc/template/
.include "../../mk/bsd.pkg.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/net/tspc/PLIST,v
retrieving revision 1.4
diff -u -r1.4 PLIST
--- PLIST 28 Dec 2005 12:10:44 -0000 1.4
+++ PLIST 30 Jan 2006 12:07:58 -0000
@@ -1,7 +1,13 @@
-@comment $NetBSD: PLIST,v 1.4 2005/12/28 12:10:44 ghen Exp $
+@comment $NetBSD$
man/man5/tspc.conf.5
man/man8/tspc.8
sbin/tspc
share/examples/rc.d/tspc
share/examples/tspc/tspc.conf
+share/tspc/template/README
+share/tspc/template/checktunnel.sh
+share/tspc/template/${TARGET}.sh
+share/tspc/template/variables_environ
+@dirrm share/tspc/template
+@dirrm share/tspc
@dirrm share/examples/tspc
--x+6KMIRAuhnl3hBn--
State-Changed-From-To: open->feedback
State-Changed-By: ghen@netbsd.org
State-Changed-When: Mon, 30 Jan 2006 17:01:43 +0000
State-Changed-Why:
Patch supplied, please let me know whether it works for you.
State-Changed-From-To: feedback->closed
State-Changed-By: ghen@netbsd.org
State-Changed-When: Thu, 23 Feb 2006 10:19:56 +0000
State-Changed-Why:
Feedback timeout. I committed the patch anyway. Thanks for the PR.
From: Geert Hendrickx <ghen@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/32637 CVS commit: pkgsrc/net/tspc
Date: Thu, 23 Feb 2006 10:18:02 +0000 (UTC)
Module Name: pkgsrc
Committed By: ghen
Date: Thu Feb 23 10:18:02 UTC 2006
Modified Files:
pkgsrc/net/tspc: Makefile PLIST
Log Message:
Install the relevant template files and point the configuration file to their
location, as pointed out by PR pkg/32637. Bump PKGREVISION.
To generate a diff of this commit:
cvs rdiff -r1.13 -r1.14 pkgsrc/net/tspc/Makefile
cvs rdiff -r1.4 -r1.5 pkgsrc/net/tspc/PLIST
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.