NetBSD Problem Report #3272
Received: (qmail-queue invoked from smtpd); 2 Mar 1997 03:05:30 -0000
Message-Id: <199703020300.TAA03909@gabriella.abattoir.com>
Date: Sat, 1 Mar 1997 19:00:37 -0800 (PST)
From: Wailer <banshee@gabriella.abattoir.com>
Reply-To: banshee@gabriella.abattoir.com
To: gnats-bugs@gnats.netbsd.org
Subject: pppd lcp-echos should not be sent on a disconnected line
X-Send-Pr-Version: 3.95
>Number: 3272
>Category: bin
>Synopsis: pppd should not send lcp echos on a disconnected line.
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: christos
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sat Mar 01 19:20:01 +0000 1997
>Closed-Date: Tue Apr 01 15:16:14 +0000 2003
>Last-Modified: Tue Apr 01 15:16:14 +0000 2003
>Originator: Wailer
>Release: 2/28/97
>Organization:
The Wailer at the Gates of Dawn / banshee@resort.com |
Just who ARE you calling a FROOFROO Head? / |
DoD#0667 "Just a friend of the beast." | http://www.resort.com/~banshee/ |
2,3,5,7,13,17,19,31,61,89,107,127,521,607....\ Port and Absinthe |
>Environment:
System: NetBSD gabriella.abattoir.com 1.2C NetBSD 1.2C (GABRIELLA2) #0: Fri Feb 28 14:30:06 PST 1997 banshee@gabriella.abattoir.com:/usr/src/sys/arch/i386/compile/GABRIELLA2 i386
>Description:
When pppd is set to request lcp echo to determine the line state,
it doesn't check the line state before incrementing its failed
echo counter. As a consequence, a low setting of lcp-echo-failure
causes the line to never be brought up because pppd checks for
echos while chat is dialing.
>How-To-Repeat:
In your options file:
lcp-echo-interval 10
lcp-echo-failure 3
>Fix:
The check of line state in LcpLinkFailure() is superfluous
and perhaps should be removed if this patch is accepted.
--- lcp.old Sat Mar 1 18:46:18 1997
+++ lcp.c Sat Mar 1 18:47:52 1997
@@ -1677,20 +1677,20 @@
u_int32_t lcp_magic;
u_char pkt[4], *pktp;
- /*
- * Detect the failure of the peer at this point.
- */
- if (lcp_echo_fails != 0) {
- if (lcp_echos_pending++ >= lcp_echo_fails) {
- LcpLinkFailure(f);
- lcp_echos_pending = 0;
- }
- }
-
- /*
- * Make and send the echo request frame.
- */
if (f->state == OPENED) {
+ /*
+ * Detect the failure of the peer at this point.
+ */
+ if (lcp_echo_fails != 0) {
+ if (lcp_echos_pending++ >= lcp_echo_fails) {
+ LcpLinkFailure(f);
+ lcp_echos_pending = 0;
+ }
+ }
+
+ /*
+ * Make and send the echo request frame.
+ */
lcp_magic = lcp_gotoptions[f->unit].magicnumber;
pktp = pkt;
PUTLONG(lcp_magic, pktp);
--end--
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: bin-bug-people->christos
Responsible-Changed-By: perry
Responsible-Changed-When: Mon Mar 31 18:59:35 PST 2003
Responsible-Changed-Why:
Christos is the PPP maintainer.
Maybe after six years(!) we might finally get this closed --
it has patches and everything after all.
From: Christos Zoulas <christos@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:
Subject: pr/3272 CVS commit: src/usr.sbin/pppd/pppd
Date: Tue, 1 Apr 2003 18:12:13 +0300 (EEST)
Module Name: src
Committed By: christos
Date: Tue Apr 1 15:12:12 UTC 2003
Modified Files:
src/usr.sbin/pppd/pppd: lcp.c
Log Message:
PR/3272: Wailer: Don't send lcp echo's if we are not opened.
To generate a diff of this commit:
cvs rdiff -r1.24 -r1.25 src/usr.sbin/pppd/pppd/lcp.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: christos
State-Changed-When: Tue Apr 1 10:16:07 EST 2003
State-Changed-Why:
fixed, thanks
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.