NetBSD Problem Report #32807

From www@netbsd.org  Sun Feb 12 17:01:58 2006
Return-Path: <www@netbsd.org>
Received: by narn.netbsd.org (Postfix, from userid 31301)
	id 95F7F63B879; Sun, 12 Feb 2006 17:01:58 +0000 (UTC)
Message-Id: <20060212170158.95F7F63B879@narn.netbsd.org>
Date: Sun, 12 Feb 2006 17:01:58 +0000 (UTC)
From: multix79@yahoo.com
Reply-To: multix79@yahoo.com
To: gnats-bugs@netbsd.org
Subject: tkdesk segfaults on startup
X-Send-Pr-Version: www-1.0

>Number:         32807
>Category:       pkg
>Synopsis:       tkdesk segfaults on startup
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 12 17:05:00 +0000 2006
>Closed-Date:    Tue Jun 07 10:17:44 +0000 2022
>Last-Modified:  Tue Jun 07 10:17:44 +0000 2022
>Originator:     Riccardo
>Release:        3.0
>Organization:
>Environment:
>Description:
tkdesk-2.0nb1 segfaults after showing the splash screen.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: port-i386-maintainer->minskim
Responsible-Changed-By: ghen@netbsd.org
Responsible-Changed-When: Sun, 12 Feb 2006 17:11:34 +0000
Responsible-Changed-Why:
This pkg has no maintainer, but minskim upgraded it last.
http://mail-index.netbsd.org/pkgsrc-changes/2005/10/26/0006.html


Responsible-Changed-From-To: minskim->perry
Responsible-Changed-By: minskim@netbsd.org
Responsible-Changed-When: Mon, 13 Feb 2006 19:07:22 +0000
Responsible-Changed-Why:
perry volunteered to work on debgging this package.


Responsible-Changed-From-To: perry->pkg-manager
Responsible-Changed-By: perry@netbsd.org
Responsible-Changed-When: Sat, 10 Feb 2007 02:29:59 +0000
Responsible-Changed-Why:
I can't deal with this any more.


From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/32807 CVS commit: pkgsrc/x11/blt
Date: Mon, 6 Jun 2022 04:27:14 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Mon Jun  6 04:27:14 UTC 2022

 Modified Files:
 	pkgsrc/x11/blt: Makefile distinfo
 	pkgsrc/x11/blt/patches: patch-ae patch-src_bltNsUtil.h
 Added Files:
 	pkgsrc/x11/blt/patches: patch-src_bltArrayObj.c patch-src_bltBgexec.c
 	    patch-src_bltConfig.c patch-src_bltInit.c patch-src_bltList.c
 	    patch-src_bltList.h patch-src_bltObjConfig.c
 	    patch-src_bltScrollbar.c patch-src_bltSwitch.c patch-src_bltTable.c
 	    patch-src_bltTree.c patch-src_bltTreeCmd.c patch-src_bltUnixPipe.c
 	    patch-src_bltVecObjCmd.c

 Log Message:
 Patch up x11/blt some.

 Most importantly, fix up what it passes to the TCL package handling
 functions, since as it was the library won't initialize. I can't
 remember when this changed in TCL but I've seen the same issue
 before... years ago. This library has likely been inoperable all that
 time.

 Patch up a whole bunch of build warnings, some significant.

 However, it probably still doesn't work and in addition to a lot more
 routine build issues it needs attention from someone who knows more
 tcl than me.

 Bump PKGREVISION (to 13). I'm not going to bump the handful of
 dependent packages since I don't think I've done anything to change
 the interface, plus they're all likely inoperable anyway given how
 broken this thing looks.

 Prerequisite for checking PR 32807 for currency, since it depends on
 blt and blt won't load. But I rather imagine the problem seen at the
 time was blt dumping core.


 To generate a diff of this commit:
 cvs rdiff -u -r1.37 -r1.38 pkgsrc/x11/blt/Makefile
 cvs rdiff -u -r1.18 -r1.19 pkgsrc/x11/blt/distinfo
 cvs rdiff -u -r1.8 -r1.9 pkgsrc/x11/blt/patches/patch-ae
 cvs rdiff -u -r0 -r1.1 pkgsrc/x11/blt/patches/patch-src_bltArrayObj.c \
     pkgsrc/x11/blt/patches/patch-src_bltBgexec.c \
     pkgsrc/x11/blt/patches/patch-src_bltConfig.c \
     pkgsrc/x11/blt/patches/patch-src_bltInit.c \
     pkgsrc/x11/blt/patches/patch-src_bltList.c \
     pkgsrc/x11/blt/patches/patch-src_bltList.h \
     pkgsrc/x11/blt/patches/patch-src_bltObjConfig.c \
     pkgsrc/x11/blt/patches/patch-src_bltScrollbar.c \
     pkgsrc/x11/blt/patches/patch-src_bltSwitch.c \
     pkgsrc/x11/blt/patches/patch-src_bltTable.c \
     pkgsrc/x11/blt/patches/patch-src_bltTree.c \
     pkgsrc/x11/blt/patches/patch-src_bltTreeCmd.c \
     pkgsrc/x11/blt/patches/patch-src_bltUnixPipe.c \
     pkgsrc/x11/blt/patches/patch-src_bltVecObjCmd.c
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/x11/blt/patches/patch-src_bltNsUtil.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/32807 CVS commit: pkgsrc/sysutils/tkdesk
Date: Mon, 6 Jun 2022 05:11:59 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Mon Jun  6 05:11:59 UTC 2022

 Modified Files:
 	pkgsrc/sysutils/tkdesk: Makefile distinfo
 	pkgsrc/sysutils/tkdesk/patches: patch-aa patch-aj patch-al
 Added Files:
 	pkgsrc/sysutils/tkdesk/patches: patch-libdesk_dsk__ls.c
 	    patch-libdesk_misc.c patch-libdesk_o__FileListbox.c
 	    patch-libdesk_ot.c patch-netscape-remote_netscape-remote.c

 Log Message:
 Fix up sysutils/tkdesk, some.

  - Fix up the TCL interpreter result handling so we don't need to use
    USE_INTERP_RESULT.

  - Fix the first startup segfault (probably the one seen in PR 32807
    but not necessarily) by using Tcl_Free instead of trying to bypass
    it. Unfortunately, there's at least one more segfault at startup
    with no obvious cause.

  - Don't run off the end of string buffers.

  - Remove some uses of sprintf. Use standard headers. Other minor
    tidyups.

  - Correct glitch in the configury patches that made it link
    statically to blt.

  - Avoid passing empty variable names to test(1) during configure.

  - Fix some pkglint.

 Bump PKGREVISION to 4, because even though it didn't run and still
 doesn't, it does build. :-|


 To generate a diff of this commit:
 cvs rdiff -u -r1.30 -r1.31 pkgsrc/sysutils/tkdesk/Makefile
 cvs rdiff -u -r1.11 -r1.12 pkgsrc/sysutils/tkdesk/distinfo
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/sysutils/tkdesk/patches/patch-aa
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/sysutils/tkdesk/patches/patch-aj
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/sysutils/tkdesk/patches/patch-al
 cvs rdiff -u -r0 -r1.1 pkgsrc/sysutils/tkdesk/patches/patch-libdesk_dsk__ls.c \
     pkgsrc/sysutils/tkdesk/patches/patch-libdesk_misc.c \
     pkgsrc/sysutils/tkdesk/patches/patch-libdesk_o__FileListbox.c \
     pkgsrc/sysutils/tkdesk/patches/patch-libdesk_ot.c \
     pkgsrc/sysutils/tkdesk/patches/patch-netscape-remote_netscape-remote.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/32807: tkdesk segfaults on startup
Date: Mon, 6 Jun 2022 05:33:23 +0000

 On Mon, Jun 06, 2022 at 05:15:02AM +0000, David A. Holland wrote:
  >  Fix up sysutils/tkdesk, some.
  >  
  >   - Fix up the TCL interpreter result handling so we don't need to use
  >     USE_INTERP_RESULT.
  >  
  >   - Fix the first startup segfault (probably the one seen in PR 32807
  >     but not necessarily) by using Tcl_Free instead of trying to bypass
  >     it. Unfortunately, there's at least one more segfault at startup
  >     with no obvious cause.

 That is: even with these fixes, it still segfaults on startup. The
 current crash is in XPM handling and has no obvious cause, but might
 be found with a debug build and more knowledge of what's supposed to
 be happening.

 Other avenues of attack: x11/blt still generates a ton of build
 warnings and does a bunch of unsafe things (hidden by floods of noise
 messages because it likes to stuff integers in pointers) -- cleaning
 it up to pass -Wall may help.

 tkdesk also probably doesn't pass -Wall, and sometimes the warnings
 that come up that way are real problems.

 Given that this package has apparently been inoperable for 16 years,
 and blt has been inoperable for some years too (even though other
 things use it) probably nobody's using any of this stuff and maybe it
 should be cleared out? It isn't obvious that it's useless or
 hopelessly dated though.

 -- 
 David A. Holland
 dholland@netbsd.org

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Tue, 07 Jun 2022 10:17:44 +0000
State-Changed-Why:
tkdesk was removed from pkgsrc


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: gnats-precook-prs,v 1.4 2018/12/21 14:20:20 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.