NetBSD Problem Report #33107

From seebs@vash.cel.plethora.net  Mon Mar 20 15:38:47 2006
Return-Path: <seebs@vash.cel.plethora.net>
Received: from vash.cel.plethora.net (216-243-131-210.static.iphouse.net [216.243.131.210])
	by narn.netbsd.org (Postfix) with ESMTP id AB46A63B8F3
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 20 Mar 2006 15:38:46 +0000 (UTC)
Message-Id: <200603201535.k2KFZbX8028330@vash.cel.plethora.net>
Date: Mon, 20 Mar 2006 09:35:37 -0600 (CST)
From: seebs <seebs@vash.cel.plethora.net>
Reply-To: seebs@vash.cel.plethora.net
To: gnats-bugs@netbsd.org
Subject: probable typo in reset code
X-Send-Pr-Version: 3.95

>Number:         33107
>Category:       port-powerpc
>Synopsis:       probable typo in reset code
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    port-powerpc-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 20 15:40:00 +0000 2006
>Closed-Date:    Sat Oct 07 15:02:19 +0000 2006
>Last-Modified:  Sat Oct 07 15:02:19 +0000 2006
>Originator:     seebs
>Release:        NetBSD 3.99.15
>Organization:
>Environment:
Architecture: powerpc
Machine: powerpc
>Description:
	The reset code in /sys/arch/powerpc/ibm4xx/4xx_locore.S has a typo.
>How-To-Repeat:
	Read code, compare with other systems
>Fix:
	It seems most likely that the intent of this code is to set the reset
	bits without touching the rest of the register, but in fact, it adds
	them to whatever random noise is in r13.  This shouldn't matter,
	because the reset bits dominate everything else, but cleanliness is
	next to having some clue why my 4xx box won't reset.

	Index: 4xx_locore.S
	===================================================================
	RCS file: /cvsroot/src/sys/arch/powerpc/ibm4xx/4xx_locore.S,v
	retrieving revision 1.5
	diff -r1.5 4xx_locore.S
	92,94c92,94
	<       mfspr   %r3,SPR_DBCR0
	<       oris    %r3,%r13,DBCR0_RST_SYSTEM@h
	<       mtspr   SPR_DBCR0,%r3
	---
	>       mfspr   %r3,SPR_DBCR0
	>       oris    %r3,%r3,DBCR0_RST_SYSTEM@h
	>       mtspr   SPR_DBCR0,%r3

>Release-Note:

>Audit-Trail:
From: Izumi Tsutsui <tsutsui@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/33107 CVS commit: src/sys/arch/powerpc/ibm4xx
Date: Sat,  7 Oct 2006 14:44:22 +0000 (UTC)

 Module Name:	src
 Committed By:	tsutsui
 Date:		Sat Oct  7 14:44:22 UTC 2006

 Modified Files:
 	src/sys/arch/powerpc/ibm4xx: 4xx_locore.S

 Log Message:
 Fix an obvious typo. Patch from seebs in PR port-powerpc/33107.


 To generate a diff of this commit:
 cvs rdiff -r1.5 -r1.6 src/sys/arch/powerpc/ibm4xx/4xx_locore.S

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: tsutsui@netbsd.org
State-Changed-When: Sun, 08 Oct 2006 00:02:19 +0900
State-Changed-Why:
Fix committed. Thanks.


>Unformatted:

Home	PR Database Search