NetBSD Problem Report #33374
From www@netbsd.org Thu Apr 27 04:34:00 2006
Return-Path: <www@netbsd.org>
Received: by narn.netbsd.org (Postfix, from userid 31301)
id 85CDF63B913; Thu, 27 Apr 2006 04:34:00 +0000 (UTC)
Message-Id: <20060427043400.85CDF63B913@narn.netbsd.org>
Date: Thu, 27 Apr 2006 04:34:00 +0000 (UTC)
From: chap@NetBSD.org
Reply-To: chap@NetBSD.org
To: gnats-bugs@netbsd.org
Subject: mount_null with mount_union panic: vref used where vget required
X-Send-Pr-Version: www-1.0
>Number: 33374
>Category: kern
>Synopsis: mount_null with mount_union panic: vref used where vget required
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: chs
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Thu Apr 27 04:35:00 +0000 2006
>Closed-Date: Sat Dec 09 16:21:04 +0000 2006
>Last-Modified: Sat Dec 09 16:21:04 +0000 2006
>Originator: Chapman Flack
>Release: 3.99.18
>Organization:
>Environment:
NetBSD 3.99.18 NetBSD 3.99.18 (olaf) #4: Mon Apr 24 17:00:37 EDT 2006 xxx@xxx:/usr/src/sys/arch/i386/compile/olaf i386
>Description:
A simple combination of a null mount and a union mount incurs a
repeatable panic on the third attempt to 'ls' it.
vref used where vget required
at netbsd:vflush
at netbsd:layerfs_root+0x21
at netbsd:union_lookup1+0xa6
at netbsd:union_lookup+0x410
at netbsd:VOP_LOOKUP+0x2e
at netbsd:lookup+0x215
at netbsd:namei+0x110
at netbsd:sys___lstat30+0x58
at netbsd:syscall_plain+0x7e
--- syscall (number 389) ---
>How-To-Repeat:
boot -s
# mount /tmp
# cd /tmp
# mkdir t0 t0/t1 t1 t2
# mount_null t1 t0/t1
# mount_union t2 t0
# ls -R t0
t1
t0/t1:
# ls -R t0
t1
t0/t1:
# ls -R t0
panic: vref used where vget required, vp 0xcb82c7ec
>Fix:
not known
>Release-Note:
>Audit-Trail:
From: Chuck Silvers <chs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: PR/33374 CVS commit: src
Date: Sat, 9 Dec 2006 16:11:53 +0000 (UTC)
Module Name: src
Committed By: chs
Date: Sat Dec 9 16:11:52 UTC 2006
Modified Files:
src/share/man/man9: namei.9 vnodeops.9
src/sys/coda: coda_vfsops.c coda_vnops.c
src/sys/fs/adosfs: adlookup.c
src/sys/fs/cd9660: cd9660_lookup.c
src/sys/fs/filecorefs: filecore_lookup.c filecore_vfsops.c
src/sys/fs/msdosfs: msdosfs_lookup.c msdosfs_vnops.c
src/sys/fs/ntfs: ntfs.h ntfs_vnops.c
src/sys/fs/ptyfs: ptyfs_vfsops.c ptyfs_vnops.c
src/sys/fs/puffs: puffs_vfsops.c puffs_vnops.c
src/sys/fs/smbfs: smbfs_vfsops.c smbfs_vnops.c
src/sys/fs/sysvbfs: sysvbfs.c sysvbfs_vnops.c
src/sys/fs/tmpfs: tmpfs_vnops.c
src/sys/fs/udf: udf_vnops.c
src/sys/fs/union: union_subr.c union_vfsops.c union_vnops.c
src/sys/kern: vfs_cache.c vfs_getcwd.c vfs_lookup.c vfs_syscalls.c
src/sys/miscfs/deadfs: dead_vnops.c
src/sys/miscfs/fdesc: fdesc_vfsops.c fdesc_vnops.c
src/sys/miscfs/genfs: layer_subr.c layer_vnops.c
src/sys/miscfs/kernfs: kernfs_vfsops.c kernfs_vnops.c
src/sys/miscfs/portal: portal_vfsops.c portal_vnops.c
src/sys/miscfs/procfs: procfs_vfsops.c procfs_vnops.c
src/sys/miscfs/umapfs: umap_vnops.c
src/sys/nfs: nfs_export.c nfs_serv.c nfs_subs.c nfs_vnops.c
src/sys/sys: namei.h
src/sys/ufs/ext2fs: ext2fs_lookup.c ext2fs_vnops.c
src/sys/ufs/lfs: lfs_vnops.c
src/sys/ufs/ufs: ufs_extattr.c ufs_lookup.c ufs_vnops.c
src/sys/uvm: uvm_vnode.c
Log Message:
a smorgasbord of improvements to vnode locking and path lookup:
- LOCKPARENT is no longer relevant for lookup(), relookup() or VOP_LOOKUP().
these now always return the parent vnode locked. namei() works as before.
lookup() and various other paths no longer acquire vnode locks in the
wrong order via vrele(). fixes PR 32535.
as a nice side effect, path lookup is also up to 25% faster.
- the above allows us to get rid of PDIRUNLOCK.
- also get rid of WANTPARENT (just use LOCKPARENT and unlock it).
- remove an assumption in layer_node_find() that all file systems implement
a recursive VOP_LOCK() (unionfs doesn't).
- require that all file systems supply vfs_vptofh and vfs_fhtovp routines.
fill in eopnotsupp() for file systems that don't support being exported
and remove the checks for NULL. (layerfs calls these without checking.)
- in union_lookup1(), don't change refcounts in the ISDOTDOT case, just
adjust which vnode is locked. fixes PR 33374.
- apply fixes for ufs_rename() from ufs_vnops.c rev. 1.61 to ext2fs_rename().
To generate a diff of this commit:
cvs rdiff -r1.12 -r1.13 src/share/man/man9/namei.9
cvs rdiff -r1.58 -r1.59 src/share/man/man9/vnodeops.9
cvs rdiff -r1.52 -r1.53 src/sys/coda/coda_vfsops.c
cvs rdiff -r1.50 -r1.51 src/sys/coda/coda_vnops.c
cvs rdiff -r1.8 -r1.9 src/sys/fs/adosfs/adlookup.c
cvs rdiff -r1.11 -r1.12 src/sys/fs/cd9660/cd9660_lookup.c
cvs rdiff -r1.7 -r1.8 src/sys/fs/filecorefs/filecore_lookup.c
cvs rdiff -r1.28 -r1.29 src/sys/fs/filecorefs/filecore_vfsops.c
cvs rdiff -r1.10 -r1.11 src/sys/fs/msdosfs/msdosfs_lookup.c
cvs rdiff -r1.34 -r1.35 src/sys/fs/msdosfs/msdosfs_vnops.c
cvs rdiff -r1.14 -r1.15 src/sys/fs/ntfs/ntfs.h
cvs rdiff -r1.30 -r1.31 src/sys/fs/ntfs/ntfs_vnops.c
cvs rdiff -r1.21 -r1.22 src/sys/fs/ptyfs/ptyfs_vfsops.c
cvs rdiff -r1.18 -r1.19 src/sys/fs/ptyfs/ptyfs_vnops.c
cvs rdiff -r1.14 -r1.15 src/sys/fs/puffs/puffs_vfsops.c
cvs rdiff -r1.21 -r1.22 src/sys/fs/puffs/puffs_vnops.c
cvs rdiff -r1.60 -r1.61 src/sys/fs/smbfs/smbfs_vfsops.c
cvs rdiff -r1.56 -r1.57 src/sys/fs/smbfs/smbfs_vnops.c
cvs rdiff -r1.2 -r1.3 src/sys/fs/sysvbfs/sysvbfs.c
cvs rdiff -r1.5 -r1.6 src/sys/fs/sysvbfs/sysvbfs_vnops.c
cvs rdiff -r1.32 -r1.33 src/sys/fs/tmpfs/tmpfs_vnops.c
cvs rdiff -r1.7 -r1.8 src/sys/fs/udf/udf_vnops.c
cvs rdiff -r1.21 -r1.22 src/sys/fs/union/union_subr.c
cvs rdiff -r1.40 -r1.41 src/sys/fs/union/union_vfsops.c
cvs rdiff -r1.17 -r1.18 src/sys/fs/union/union_vnops.c
cvs rdiff -r1.66 -r1.67 src/sys/kern/vfs_cache.c
cvs rdiff -r1.33 -r1.34 src/sys/kern/vfs_getcwd.c
cvs rdiff -r1.72 -r1.73 src/sys/kern/vfs_lookup.c
cvs rdiff -r1.279 -r1.280 src/sys/kern/vfs_syscalls.c
cvs rdiff -r1.41 -r1.42 src/sys/miscfs/deadfs/dead_vnops.c
cvs rdiff -r1.62 -r1.63 src/sys/miscfs/fdesc/fdesc_vfsops.c
cvs rdiff -r1.94 -r1.95 src/sys/miscfs/fdesc/fdesc_vnops.c
cvs rdiff -r1.20 -r1.21 src/sys/miscfs/genfs/layer_subr.c
cvs rdiff -r1.28 -r1.29 src/sys/miscfs/genfs/layer_vnops.c
cvs rdiff -r1.74 -r1.75 src/sys/miscfs/kernfs/kernfs_vfsops.c
cvs rdiff -r1.128 -r1.129 src/sys/miscfs/kernfs/kernfs_vnops.c
cvs rdiff -r1.58 -r1.59 src/sys/miscfs/portal/portal_vfsops.c
cvs rdiff -r1.68 -r1.69 src/sys/miscfs/portal/portal_vnops.c
cvs rdiff -r1.67 -r1.68 src/sys/miscfs/procfs/procfs_vfsops.c
cvs rdiff -r1.142 -r1.143 src/sys/miscfs/procfs/procfs_vnops.c
cvs rdiff -r1.42 -r1.43 src/sys/miscfs/umapfs/umap_vnops.c
cvs rdiff -r1.22 -r1.23 src/sys/nfs/nfs_export.c
cvs rdiff -r1.119 -r1.120 src/sys/nfs/nfs_serv.c
cvs rdiff -r1.177 -r1.178 src/sys/nfs/nfs_subs.c
cvs rdiff -r1.245 -r1.246 src/sys/nfs/nfs_vnops.c
cvs rdiff -r1.45 -r1.46 src/sys/sys/namei.h
cvs rdiff -r1.46 -r1.47 src/sys/ufs/ext2fs/ext2fs_lookup.c
cvs rdiff -r1.69 -r1.70 src/sys/ufs/ext2fs/ext2fs_vnops.c
cvs rdiff -r1.193 -r1.194 src/sys/ufs/lfs/lfs_vnops.c
cvs rdiff -r1.10 -r1.11 src/sys/ufs/ufs/ufs_extattr.c
cvs rdiff -r1.80 -r1.81 src/sys/ufs/ufs/ufs_lookup.c
cvs rdiff -r1.143 -r1.144 src/sys/ufs/ufs/ufs_vnops.c
cvs rdiff -r1.77 -r1.78 src/sys/uvm/uvm_vnode.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Responsible-Changed-From-To: kern-bug-people->chs
Responsible-Changed-By: chs@netbsd.org
Responsible-Changed-When: Sat, 09 Dec 2006 16:21:04 +0000
Responsible-Changed-Why:
I fixed it.
State-Changed-From-To: open->closed
State-Changed-By: chs@netbsd.org
State-Changed-When: Sat, 09 Dec 2006 16:21:04 +0000
State-Changed-Why:
fixed by the check-in listed in the PR log.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.