NetBSD Problem Report #33571

From dieter@bsdusr.net  Sat May 27 15:09:38 2006
Return-Path: <dieter@bsdusr.net>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 0DC4E63BA5F
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 27 May 2006 15:09:38 +0000 (UTC)
Message-Id: <20060527135302.6A82255B7@mail.bsdusr.net>
Date: Sat, 27 May 2006 13:53:02 +0000 (UTC)
From: dieter.NetBSD@pandora.be
Reply-To: dieter.NetBSD@pandora.be
To: gnats-bugs@NetBSD.org
Subject: extraction doesn't know about distfiles with -tar.gz suffix
X-Send-Pr-Version: 3.95

>Number:         33571
>Category:       pkg
>Synopsis:       extraction doesn't know about distfiles with -tar.gz suffix
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat May 27 15:10:00 +0000 2006
>Closed-Date:    Tue May 30 23:52:54 +0000 2006
>Last-Modified:  Tue May 30 23:55:00 +0000 2006
>Originator:     Dieter Roelants
>Release:        NetBSD 3.99.20
>Organization:
>Environment:
System: NetBSD origin.amelgem.be 3.99.20 NetBSD 3.99.20 (ORIGIN) #63: Thu May 18 07:00:58 CEST 2006  dieter@origin.amelgem.be:/usr/build/obj/sys/arch/i386/compile/ORIGIN i386
Architecture: i386
Machine: i386
>Description:
	Some tarballs, notably from the OpenH323 Project have a
	suffix of -tar.gz, instead of more common ones.
	mk/bsd.pkg.extract.mk and the mk/scripts/extract don't
	recognise this suffix as being gzipped tar (they already
	have _tar.gz though).

	devel/pwlib and net/openh323 currently work around this
	with a post-extract target, I'd rather not repeat it for
	wip/opal.
>How-To-Repeat:
>Fix:

Index: bsd.pkg.extract.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.extract.mk,v
retrieving revision 1.21
diff -u -r1.21 bsd.pkg.extract.mk
--- bsd.pkg.extract.mk	23 Jan 2006 14:43:50 -0000	1.21
+++ bsd.pkg.extract.mk	27 May 2006 13:48:54 -0000
@@ -72,7 +72,8 @@
     !empty(_EXTRACT_PATTERNS:M*.tbz) || \
     !empty(_EXTRACT_PATTERNS:M*.tbz2) || \
     !empty(_EXTRACT_PATTERNS:M*.tgz) || \
-    !empty(_EXTRACT_PATTERNS:M*_tar.gz)
+    !empty(_EXTRACT_PATTERNS:M*_tar.gz) || \
+    !empty(_EXTRACT_PATTERNS:M*-tar.gz)
 .  if !empty(EXTRACT_USING:Mgtar)
 USE_TOOLS+=	gtar
 .  elif !empty(EXTRACT_USING:Mnbtar)
Index: scripts/extract
===================================================================
RCS file: /cvsroot/pkgsrc/mk/scripts/extract,v
retrieving revision 1.20
diff -u -r1.20 extract
--- scripts/extract	19 Feb 2006 15:38:23 -0000	1.20
+++ scripts/extract	27 May 2006 13:48:59 -0000
@@ -178,7 +178,7 @@

 # Derive the format of the archive based on the file extension.
 case "$distfile" in
-*.tar.gz|*.tgz|*_tar.gz|*.tar.bz2|*.tbz|*.tbz2|*.tar.Z|*.tar.z|*.tar|*.tar.bz)
+*.tar.gz|*.tgz|*_tar.gz|*-tar.gz|*.tar.bz2|*.tbz|*.tbz2|*.tar.Z|*.tar.z|*.tar|*.tar.bz)
 		_format=tar ;;
 *.shar.gz|*.shar.bz2|*.shar.Z|*.shar|*.shr.gz|*.shr.bz2|*.shr.Z|*.shr)
 		_format=shar ;;

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@netbsd.org
State-Changed-When: Tue, 30 May 2006 23:52:54 +0000
State-Changed-Why:
Fixed, thanks!


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/33571 CVS commit: pkgsrc/mk
Date: Tue, 30 May 2006 23:51:38 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Tue May 30 23:51:38 UTC 2006

 Modified Files:
 	pkgsrc/mk: bsd.pkg.extract.mk
 	pkgsrc/mk/scripts: extract

 Log Message:
 Recognize -tar.gz as tar.gz files. PR 33571 by Dieter Roelants.


 To generate a diff of this commit:
 cvs rdiff -r1.21 -r1.22 pkgsrc/mk/bsd.pkg.extract.mk
 cvs rdiff -r1.20 -r1.21 pkgsrc/mk/scripts/extract

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.