NetBSD Problem Report #33806

From dauphin@enst.fr  Fri Jun 23 13:15:29 2006
Return-Path: <dauphin@enst.fr>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id D04F463B8EA
	for <gnats-bugs@gnats.netbsd.org>; Fri, 23 Jun 2006 13:15:29 +0000 (UTC)
Message-Id: <1151068528.23005@bi.enst.fr>
Date: Fri, 23 Jun 2006 15:15:28 +0200
From: "Gilles Dauphin" <dauphin@enst.fr>
To: "gnats bugs" <gnats-bugs@NetBSD.org>
Subject: net/nmap inet_aton patch-ad
X-Send-Pr-Version: gtk-send-pr 0.4.5 
X-GNATS-Notify:

>Number:         33806
>Category:       pkg
>Synopsis:       net/nmap inet_aton patch-ad
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    salo
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 23 13:20:00 +0000 2006
>Closed-Date:    Tue Jun 27 14:52:09 +0000 2006
>Last-Modified:  Tue Jun 27 14:52:09 +0000 2006
>Originator:     Gilles Dauphin
>Release:        SunOS 5.10 i86pc
>Organization:
ENST 
>Environment:


System: SunOS bi.enst.fr 5.10 Generic_Patch_118844-30 i86pc


>Description:


Compiling libnbase
cd nbase && /usr/pkg/bin/bmake
bmake: don't know how to make inet_aton.o. Stop

bmake: stopped in /pkg/obj/net/nmap/work/nmap-4.10/nbase
*** Error code 2

Stop.

According to the CHANGELOG that say:
o Changed all instances of inet_aton() into calls to inet_pton()
  instead.  This allowed us to remove inet_aton.c from nbase.

configure MUST not test inet_aton!!!


>How-To-Repeat:


bmake


>Fix:


new patch-ad
------------------------------------------------------------------
--- nbase/configure.orig        Tue Mar 28 12:15:03 2006
+++ nbase/configure     Fri Jun 23 15:06:40 2006
@@ -9,6 +9,8 @@
 ## M4sh Initialization.  ##
 ## --------------------- ##

+LIBS=
+
 # Be Bourne compatible
 if test -n "${ZSH_VERSION+set}" && (emulate sh) >/dev/null 2>&1; then
   emulate sh
@@ -5944,118 +5946,8 @@
 done


-for ac_func in inet_aton
-do
-as_ac_var=`echo "ac_cv_func_$ac_func" | $as_tr_sh`
-echo "$as_me:$LINENO: checking for $ac_func" >&5
-echo $ECHO_N "checking for $ac_func... $ECHO_C" >&6
-if eval "test \"\${$as_ac_var+set}\" = set"; then
-  echo $ECHO_N "(cached) $ECHO_C" >&6
-else
-  cat >conftest.$ac_ext <<_ACEOF
-/* confdefs.h.  */
-_ACEOF
-cat confdefs.h >>conftest.$ac_ext
-cat >>conftest.$ac_ext <<_ACEOF
-/* end confdefs.h.  */
-/* Define $ac_func to an innocuous variant, in case <limits.h> declares $ac_func.
-   For example, HP-UX 11i <limits.h> declares gettimeofday.  */
-#define $ac_func innocuous_$ac_func

-/* System header to define __stub macros and hopefully few prototypes,
-    which can conflict with char $ac_func (); below.
-    Prefer <limits.h> to <assert.h> if __STDC__ is defined, since
-    <limits.h> exists even on freestanding compilers.  */

-#ifdef __STDC__
-# include <limits.h>
-#else
-# include <assert.h>
-#endif
-
-#undef $ac_func
-
-/* Override any gcc2 internal prototype to avoid an error.  */
-#ifdef __cplusplus
-extern "C"
-{
-#endif
-/* We use char because int might match the return type of a gcc2
-   builtin and then its argument prototype would still apply.  */
-char $ac_func ();
-/* The GNU C library defines this for functions which it implements
-    to always fail with ENOSYS.  Some functions are actually named
-    something starting with __ and the normal name is an alias.  */
-#if defined (__stub_$ac_func) || defined (__stub___$ac_func)
-choke me
-#else
-char (*f) () = $ac_func;
-#endif
-#ifdef __cplusplus
-}
-#endif
-
-int
-main ()
-{
-return f != $ac_func;
-  ;
-  return 0;
-}
-_ACEOF
-rm -f conftest.$ac_objext conftest$ac_exeext
-if { (eval echo "$as_me:$LINENO: \"$ac_link\"") >&5
-  (eval $ac_link) 2>conftest.er1
-  ac_status=$?
-  grep -v '^ *+' conftest.er1 >conftest.err
-  rm -f conftest.er1
-  cat conftest.err >&5
-  echo "$as_me:$LINENO: \$? = $ac_status" >&5
-  (exit $ac_status); } &&
-        { ac_try='test -z "$ac_c_werror_flag"
-                        || test ! -s conftest.err'
-  { (eval echo "$as_me:$LINENO: \"$ac_try\"") >&5
-  (eval $ac_try) 2>&5
-  ac_status=$?
-  echo "$as_me:$LINENO: \$? = $ac_status" >&5
-  (exit $ac_status); }; } &&
-        { ac_try='test -s conftest$ac_exeext'
-  { (eval echo "$as_me:$LINENO: \"$ac_try\"") >&5
-  (eval $ac_try) 2>&5
-  ac_status=$?
-  echo "$as_me:$LINENO: \$? = $ac_status" >&5
-  (exit $ac_status); }; }; then
-  eval "$as_ac_var=yes"
-else
-  echo "$as_me: failed program was:" >&5
-sed 's/^/| /' conftest.$ac_ext >&5
-
-eval "$as_ac_var=no"
-fi
-rm -f conftest.err conftest.$ac_objext \
-      conftest$ac_exeext conftest.$ac_ext
-fi
-echo "$as_me:$LINENO: result: `eval echo '${'$as_ac_var'}'`" >&5
-echo "${ECHO_T}`eval echo '${'$as_ac_var'}'`" >&6
-if test `eval echo '${'$as_ac_var'}'` = yes; then
-  cat >>confdefs.h <<_ACEOF
-#define `echo "HAVE_$ac_func" | $as_tr_cpp` 1
-_ACEOF
-
-else
-  case $LIBOBJS in
-    "$ac_func.$ac_objext"   | \
-  *" $ac_func.$ac_objext"   | \
-    "$ac_func.$ac_objext "* | \
-  *" $ac_func.$ac_objext "* ) ;;
-  *) LIBOBJS="$LIBOBJS $ac_func.$ac_objext" ;;
-esac
-
-fi
-done
-
-
-
 needsnprintf=no


@@ -7081,7 +6973,7 @@
   echo $ECHO_N "(cached) $ECHO_C" >&6
 else
   ac_check_lib_save_LIBS=$LIBS
-LIBS="-lssl  $LIBS"
+LIBS="-lssl -lcrypto $LIBS"
 cat >conftest.$ac_ext <<_ACEOF
 /* confdefs.h.  */
 _ACEOF
@@ -7144,7 +7036,7 @@
 #define HAVE_LIBSSL 1
 _ACEOF

-  LIBS="-lssl $LIBS"
+  LIBS="-lssl -lcrypto $LIBS"

 else
    use_openssl="no"
@@ -8753,6 +8645,10 @@
 _ACEOF
 cat >>$CONFIG_STATUS <<\_ACEOF
   -recheck | --recheck | --rechec | --reche | --rech | --rec | --re | --r)
+    # Avoid regenerating for rechecks on pkgsrc
+    exit 0
+    # Avoid regenerating for rechecks on pkgsrc
+    exit 0
     ac_cs_recheck=: ;;
   --version | --vers* | -V )
     echo "$ac_cs_version"; exit 0 ;;



>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->salo
Responsible-Changed-By: snj@netbsd.org
Responsible-Changed-When: Sun, 25 Jun 2006 07:58:10 +0000
Responsible-Changed-Why:
Assign to maintainer.


From: Lubomir Sedlacik <salo@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/33806 CVS commit: pkgsrc/net/nmap
Date: Sun, 25 Jun 2006 14:29:14 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	salo
 Date:		Sun Jun 25 14:29:14 UTC 2006

 Modified Files:
 	pkgsrc/net/nmap: Makefile distinfo
 	pkgsrc/net/nmap/patches: patch-aa
 Removed Files:
 	pkgsrc/net/nmap/patches: patch-ad patch-ae patch-af

 Log Message:
 Update to version 4.11

 - bite the bullet and use GNU make, it's increasingly annoying to try
   avoiding it

 Changes:

 - Added a dozens of more detailed SSH version detection signatures,
   thanks to a SSH huge survey and integration effort by Doug Hoyte.
   The results of his large-scale SSH scan are posted at
    http://seclists.org/nmap-dev/2006/Apr-Jun/0393.html .

 - Fixed the Nmap Makefile (actually Makefile.in) to correctly handle
   include file dependencies.  So if a .h file is changed, all of the
   .cc files which depend on it will be recompiled.  Thanks to Diman
   Todorov (diman(a)xover.mud.at) for the patch.

 - Fixed a compilation problem on solaris and possibly other platforms.
   The error message looked like "No rule to make target `inet_aton.o',
   needed by `libnbase.a'".  Thanks to Matt Selsky
   (selsky(a)columbia.edu) for the patch.

   Fixes PR pkg/33806 from Gilles Dauphin.

 - Applied a patch which helps with HP-UX compilation by linking in the
   nm library (-lnm).  Thanks to Zakharov Mikhail (zmey20000(a)yahoo.com)
   for the patch.

 - Added version detection probes for detecting the Nessus daemon.
   Thanks to Adam Vartanian (flooey(a)gmail.com) for sending the patch.


 To generate a diff of this commit:
 cvs rdiff -r1.51 -r1.52 pkgsrc/net/nmap/Makefile
 cvs rdiff -r1.32 -r1.33 pkgsrc/net/nmap/distinfo
 cvs rdiff -r1.18 -r1.19 pkgsrc/net/nmap/patches/patch-aa
 cvs rdiff -r1.11 -r0 pkgsrc/net/nmap/patches/patch-ad
 cvs rdiff -r1.6 -r0 pkgsrc/net/nmap/patches/patch-ae \
     pkgsrc/net/nmap/patches/patch-af

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: salo@netbsd.org
State-Changed-When: Sun, 25 Jun 2006 14:31:05 +0000
State-Changed-Why:
should be fixed in 4.11, could you please try it?


From: Gilles Dauphin <Gilles.Dauphin@enst.fr>
To: salo@NetBSD.org, gnats-admin@NetBSD.org, gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/33806 (net/nmap inet_aton patch-ad)
Date: Mon, 26 Jun 2006 09:30:48 +0200 (CEST)

 > Delivered-To: dauphin@enst.fr
 > X-Virus-Scanned: amavisd-new at enst.fr
 > From: salo@NetBSD.org
 > 
 > Synopsis: net/nmap inet_aton patch-ad
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: salo@netbsd.org
 > State-Changed-When: Sun, 25 Jun 2006 14:31:05 +0000
 > State-Changed-Why:
 > should be fixed in 4.11, could you please try it?
 > 
 > 

 I try and That's fine for me:)
  Thanks
 Gilles

From: Lubomir Sedlacik <salo@Xtrmntr.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/33806 (net/nmap inet_aton patch-ad)
Date: Tue, 27 Jun 2006 15:44:18 +0200

 --44EoV7tf2AX9r8hV
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable

 On Mon, Jun 26, 2006 at 07:35:01AM +0000, Gilles Dauphin wrote:
 >  > State-Changed-From-To: open->feedback
 >  > State-Changed-By: salo@netbsd.org
 >  > State-Changed-When: Sun, 25 Jun 2006 14:31:05 +0000
 >  > State-Changed-Why:
 >  > should be fixed in 4.11, could you please try it?
 > =20
 >  I try and That's fine for me:)

 i am afraid i don't understand.  do you mean that you tried, it worked
 fine and it's ok to close the PR or that you are just about to try it?=20

 regards,

 --=20
 -- Lubomir Sedlacik <salo@{NetBSD,Xtrmntr,silcnet}.org>   --

 --44EoV7tf2AX9r8hV
 Content-Type: application/pgp-signature
 Content-Disposition: inline

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.2.2 (NetBSD)

 iD8DBQFEoTYyiwjDDlS8cmMRApJpAJ0XExB/pcwstthR5fhx2TgFPUT2fwCeIYdq
 MDDBKoDHnpPJodfCVZDQgy4=
 =IKQU
 -----END PGP SIGNATURE-----

 --44EoV7tf2AX9r8hV--

From: Gilles Dauphin <Gilles.Dauphin@enst.fr>
To: salo@NetBSD.org, gnats-admin@NetBSD.org, gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/33806 (net/nmap inet_aton patch-ad)
Date: Tue, 27 Jun 2006 16:23:03 +0200 (CEST)

 >  On Mon, Jun 26, 2006 at 07:35:01AM +0000, Gilles Dauphin wrote:
 >  >  > State-Changed-From-To: open->feedback
 >  >  > State-Changed-By: salo@netbsd.org
 >  >  > State-Changed-When: Sun, 25 Jun 2006 14:31:05 +0000
 >  >  > State-Changed-Why:
 >  >  > should be fixed in 4.11, could you please try it?
 >  > =20
 >  >  I try and That's fine for me:)
 >  
 >  i am afraid i don't understand.  do you mean that you tried, it worked
 >  fine and it's ok to close the PR or that you are just about to try it?=20
 >  

 Yes it worked fine for me, it's ok to close the PR.
 I am afraid too, because of my poor english!

 Cheers
 Gilles

State-Changed-From-To: feedback->closed
State-Changed-By: salo@netbsd.org
State-Changed-When: Tue, 27 Jun 2006 14:52:09 +0000
State-Changed-Why:
confirmed fixed.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.