NetBSD Problem Report #34185
From dauphin@enst.fr Fri Aug 11 14:15:06 2006
Return-Path: <dauphin@enst.fr>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by narn.NetBSD.org (Postfix) with ESMTP id A9E3563B964
for <gnats-bugs@gnats.netbsd.org>; Fri, 11 Aug 2006 14:15:06 +0000 (UTC)
Message-Id: <1155305699.29077@bi.enst.fr>
Date: Fri, 11 Aug 2006 16:14:59 +0200
From: "Gilles Dauphin" <dauphin@enst.fr>
To: "gnats bugs" <gnats-bugs@NetBSD.org>
Subject: games/kdegames3 3.5.4 Solaris10
X-Send-Pr-Version: gtk-send-pr 0.4.5
X-GNATS-Notify:
>Number: 34185
>Category: pkg
>Synopsis: games/kdegames3 3.5.4 Solaris10
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: solaris-pkg-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Aug 11 14:20:00 +0000 2006
>Closed-Date: Thu Feb 07 14:43:06 +0000 2013
>Last-Modified: Thu Feb 07 14:43:06 +0000 2013
>Originator: Gilles Dauphin
>Release: SunOS 5.10 i86pc
>Organization:
ENST
>Environment:
System: SunOS bi.enst.fr 5.10 Generic_Patch_118844-30 i86pc
>Description:
gmake[2]: Leaving directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines/solver'
gmake[2]: Entering directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
gmake[3]: Entering directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
test -z "/usr/pkg/bin" || /bin/bash ../admin/mkinstalldirs "/usr/pkg/bin"
/bin/bash ../libtool --silent --mode=install /usr/ucb/install -c -s -o root -g root -m 555 'kmines' '/usr/pkg/bin/kmines'
/usr/pkg/bin/gmake install-exec-hook
gmake[4]: Entering directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
/bin/bash: -c: line 2: syntax error near unexpected token `'
/bin/bash: -c: line 2: `|| echo "Error: Could not install the game with correct permissions !!" \'
gmake[4]: *** [install-exec-hook] Error 2
gmake[4]: Leaving directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
gmake[3]: *** [install-exec-am] Error 2
gmake[3]: Leaving directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
gmake[2]: *** [install-am] Error 2
gmake[2]: Leaving directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
gmake[1]: *** [install-recursive] Error 1
gmake[1]: Leaving directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
gmake: *** [install-recursive] Error 1
*** Error code 2
Stop.
>How-To-Repeat:
bmake install
>Fix:
in Makefile.in look at install-exec-hook:
Problem is the nested '((' and '))' for some SHELL
and the '!!' in the echo message
impacted games:
kdegames-3.5.4/kmines
kdegames-3.5.4/klickety
kdegames-3.5.4/kfouleggs
kdegames-3.5.4/ksirtet/ksirtet
------------patch example-------------------
--- kdegames-3.5.4/ksirtet/ksirtet/Makefile.in.orig Mon Jul 24 17:08:56 2006
+++ kdegames-3.5.4/ksirtet/ksirtet/Makefile.in Fri Aug 11 16:10:23 2006
@@ -871,31 +871,31 @@
install-exec-hook:
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
- && chmod 750 $(DESTHIGHSCORES)) \
+ && ( (mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
+ && chmod 750 $(DESTHIGHSCORES) ) \
|| echo "Error: Could not create the highscore directory with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test ${setgid} = true \
- && ((chmod 2755 $(DESTBIN)) \
+ && ( (chmod 2755 $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
- && chmod 0660 $(DESTSCORES)) \
+ && ( (touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
+ && chmod 0660 $(DESTSCORES) ) \
|| echo "Error: Could not create system-wide highscore file with correct permissions !!" \
- )) || true
+ ) ) || true
# Tell versions [3.59,3.63) of GNU make to not export all variables.
# Otherwise a system limit (for SysV at least) may be exceeded.
.NOEXPORT:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: pkg-manager->markd
Responsible-Changed-By: ben@netbsd.org
Responsible-Changed-When: Fri, 11 Aug 2006 15:32:18 +0000
Responsible-Changed-Why:
Assigned to package maintainer, markd.
Responsible-Changed-From-To: markd->solaris-pkg-people
Responsible-Changed-By: ben@netbsd.org
Responsible-Changed-When: Fri, 11 Aug 2006 15:32:59 +0000
Responsible-Changed-Why:
Assigned to solaris-pkg-people because this is a solaris PR.
From: Gilles Dauphin <Gilles.Dauphin@enst.fr>
To: solaris-pkg-people@NetBSD.org, markd@NetBSD.org,
gnats-admin@NetBSD.org, ben@NetBSD.org, gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/34185 (games/kdegames3 3.5.4 Solaris10)
Date: Wed, 16 Aug 2006 11:29:43 +0200 (CEST)
--Charm_of_Finches_390_000
Content-Type: TEXT/plain; charset=us-ascii
Content-MD5: Eknn1CCGxoVwmP1VX9mv1A==
> Synopsis: games/kdegames3 3.5.4 Solaris10
>
> Responsible-Changed-From-To: markd->solaris-pkg-people
> Responsible-Changed-By: ben@netbsd.org
> Responsible-Changed-When: Fri, 11 Aug 2006 15:32:59 +0000
> Responsible-Changed-Why:
> Assigned to solaris-pkg-people because this is a solaris PR.
I think it is also a SHELL problem, anyway for easy work
i attach the patch I wish. I think thoses patchs have no impact
on any build (except Solaris ;)
--Charm_of_Finches_390_000
Content-Type: TEXT/plain; name=patch-aa; charset=us-ascii; x-unix-mode=0644
Content-Description: patch-aa
Content-MD5: IBg+AraWg+4abgL9jdlJDg==
--- kmines/Makefile.in.orig Mon Jul 24 17:08:54 2006
+++ kmines/Makefile.in Fri Aug 11 15:53:18 2006
@@ -902,31 +902,31 @@
install-exec-hook:
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
- && chmod 750 $(DESTHIGHSCORES)) \
+ && ( (mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
+ && chmod 750 $(DESTHIGHSCORES) ) \
|| echo "Error: Could not create the highscore directory with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test ${setgid} = true \
- && ((chmod 2755 $(DESTBIN)) \
+ && ( (chmod 2755 $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
- && chmod 0660 $(DESTSCORES)) \
+ && ( (touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
+ && chmod 0660 $(DESTSCORES) ) \
|| echo "Error: Could not create system-wide highscore file with correct permissions !!" \
- )) || true
+ ) ) || true
# Tell versions [3.59,3.63) of GNU make to not export all variables.
# Otherwise a system limit (for SysV at least) may be exceeded.
.NOEXPORT:
--Charm_of_Finches_390_000
Content-Type: TEXT/plain; name=patch-ab; charset=us-ascii; x-unix-mode=0644
Content-Description: patch-ab
Content-MD5: /LGpvdR9w31F98IXt5ttLw==
--- kdegames-3.5.4/klickety/Makefile.in.orig Mon Jul 24 17:08:54 2006
+++ kdegames-3.5.4/klickety/Makefile.in Fri Aug 11 16:01:10 2006
@@ -935,31 +935,31 @@
install-exec-hook:
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
- && chmod 750 $(DESTHIGHSCORES)) \
+ && ( (mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
+ && chmod 750 $(DESTHIGHSCORES) ) \
|| echo "Error: Could not create the highscore directory with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test ${setgid} = true \
- && ((chmod 2755 $(DESTBIN)) \
+ && ( (chmod 2755 $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
- && chmod 0660 $(DESTSCORES)) \
+ && ( (touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
+ && chmod 0660 $(DESTSCORES) ) \
|| echo "Error: Could not create system-wide highscore file with correct permissions !!" \
- )) || true
+ ) ) || true
# Tell versions [3.59,3.63) of GNU make to not export all variables.
# Otherwise a system limit (for SysV at least) may be exceeded.
.NOEXPORT:
--Charm_of_Finches_390_000
Content-Type: TEXT/plain; name=patch-ac; charset=us-ascii; x-unix-mode=0644
Content-Description: patch-ac
Content-MD5: TamcUL+0FMApt6GnXdXcNg==
--- kdegames-3.5.4/kfouleggs/Makefile.in.orig Mon Jul 24 17:08:54 2006
+++ kdegames-3.5.4/kfouleggs/Makefile.in Fri Aug 11 16:04:33 2006
@@ -959,31 +959,31 @@
install-exec-hook:
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
- && chmod 750 $(DESTHIGHSCORES)) \
+ && ( (mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
+ && chmod 750 $(DESTHIGHSCORES) ) \
|| echo "Error: Could not create the highscore directory with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test ${setgid} = true \
- && ((chmod 2755 $(DESTBIN)) \
+ && ( (chmod 2755 $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
- && chmod 0660 $(DESTSCORES)) \
+ && ( (touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
+ && chmod 0660 $(DESTSCORES) ) \
|| echo "Error: Could not create system-wide highscore file with correct permissions !!" \
- )) || true
+ ) ) || true
# Tell versions [3.59,3.63) of GNU make to not export all variables.
# Otherwise a system limit (for SysV at least) may be exceeded.
.NOEXPORT:
--Charm_of_Finches_390_000
Content-Type: TEXT/plain; name=patch-ad; charset=us-ascii; x-unix-mode=0644
Content-Description: patch-ad
Content-MD5: FyA4lIdtk7/EYV9OIHmwlA==
--- kdegames-3.5.4/ksirtet/ksirtet/Makefile.in.orig Mon Jul 24 17:08:56 2006
+++ kdegames-3.5.4/ksirtet/ksirtet/Makefile.in Fri Aug 11 16:10:23 2006
@@ -871,31 +871,31 @@
install-exec-hook:
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
- && chmod 750 $(DESTHIGHSCORES)) \
+ && ( (mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
+ && chmod 750 $(DESTHIGHSCORES) ) \
|| echo "Error: Could not create the highscore directory with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test ${setgid} = true \
- && ((chmod 2755 $(DESTBIN)) \
+ && ( (chmod 2755 $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
- && chmod 0660 $(DESTSCORES)) \
+ && ( (touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
+ && chmod 0660 $(DESTSCORES) ) \
|| echo "Error: Could not create system-wide highscore file with correct permissions !!" \
- )) || true
+ ) ) || true
# Tell versions [3.59,3.63) of GNU make to not export all variables.
# Otherwise a system limit (for SysV at least) may be exceeded.
.NOEXPORT:
--Charm_of_Finches_390_000--
State-Changed-From-To: open->closed
State-Changed-By: jperkin@NetBSD.org
State-Changed-When: Thu, 07 Feb 2013 14:43:06 +0000
State-Changed-Why:
This does not appear to still be an issue.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.36 2007/11/24 03:27:39 kano Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.