NetBSD Problem Report #3421

Received: (qmail-queue invoked from smtpd); 31 Mar 1997 11:05:56 -0000
Message-Id: <199703311007.CAA21794@brig.com>
Date: Mon, 31 Mar 1997 02:07:13 -0800 (PST)
From: Brian Baird <brb@brig.com>
To: gnats-bugs@gnats.netbsd.org
Subject: pchb missing Triton II host bridge
X-Send-Pr-Version: 3.95

>Number:         3421
>Category:       port-i386
>Synopsis:       pchb missing Triton II host bridge
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-i386-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 31 03:20:02 +0000 1997
>Closed-Date:    Sat Feb 06 21:04:13 +0000 1999
>Last-Modified:  Sat Feb 06 21:04:37 +0000 1999
>Originator:     Brian Baird
>Release:        1.2D 970326
>Organization:
Brian Baird				Brig Systems, Pleasanton CA
brb@brig.com				+1 510 484 1342
>Environment:
System: NetBSD tardis.brig.com 1.2D NetBSD 1.2D (BRIG) #0: Wed Mar 26 22:13:12 PST 1997 root@tardis.brig.com:/mnt2/NetBSD-current/src/sys/arch/i386/compile/BRIG i386


>Description:
	The pchb driver in arch/i386/pci has a list of host bridges
	that it supports.  It's missing the entry for the Intel
	82439, the host bridge on Triton II based motherboards.

	A more general solution is to change pchb and pcib to work for
	all matching bridge devices (much as the ppb driver works).

	Fixes for both solutions are provided.
>How-To-Repeat:
	Boot a Triton II based motherboard
>Fix:
	fix 1: just add the entry for the 82439

--- pchb.c.dist	Thu Nov 28 04:17:44 1996
+++ pchb.c	Sat Mar 29 19:17:24 1997
@@ -77,6 +77,7 @@
 		case PCI_PRODUCT_INTEL_82454GX:
 		case PCI_PRODUCT_INTEL_CDC:
 		case PCI_PRODUCT_INTEL_82450KX:
+		case PCI_PRODUCT_INTEL_82439:
 			return (1);
 		}
 	}


	fix 2: make pchb and pcib match all appropriate bridge devices

--- pchb.c.dist	Thu Nov 28 04:17:44 1996
+++ pchb.c	Sat Mar 29 19:50:25 1997
@@ -67,26 +67,12 @@
 	struct pci_attach_args *pa = aux;

 	/*
-	 * Match all known PCI host chipsets.
+	 * Match all PCI-Host bridge devices.  The BIOS should have
+	 * set things up so that they all look alike to us.
 	 */
-	if (PCI_VENDOR(pa->pa_id) == PCI_VENDOR_INTEL) {
-		switch (PCI_PRODUCT(pa->pa_id)) {
-		case PCI_PRODUCT_INTEL_PCMC:
-		case PCI_PRODUCT_INTEL_82437:
-		case PCI_PRODUCT_INTEL_82440FX:
-		case PCI_PRODUCT_INTEL_82454GX:
-		case PCI_PRODUCT_INTEL_CDC:
-		case PCI_PRODUCT_INTEL_82450KX:
-			return (1);
-		}
-	}
-
-	if (PCI_VENDOR(pa->pa_id) == PCI_VENDOR_UMC) {
-		switch (PCI_PRODUCT(pa->pa_id)) {
-		case PCI_PRODUCT_UMC_UM8881F:
-			return (1);
-		}
-	}
+	if (PCI_CLASS(pa->pa_class) == PCI_CLASS_BRIDGE &&
+	    PCI_SUBCLASS(pa->pa_class) == PCI_SUBCLASS_BRIDGE_HOST)
+		return (1);

 	return (0);
 }
@@ -99,8 +85,6 @@
 	struct pci_attach_args *pa = aux;
 	char devinfo[256];

-	printf("\n");
-
 	/*
 	 * All we do is print out a description.  Eventually, we
 	 * might want to add code that does something that's
@@ -108,6 +92,5 @@
 	 */

 	pci_devinfo(pa->pa_id, pa->pa_class, 0, devinfo);
-	printf("%s: %s (rev. 0x%02x)\n", self->dv_xname, devinfo,
-	    PCI_REVISION(pa->pa_class));
+	printf(": %s (rev. 0x%02x)\n", devinfo, PCI_REVISION(pa->pa_class));
 }

--- pcib.c.dist	Thu Nov 28 04:17:44 1996
+++ pcib.c	Sat Mar 29 19:50:16 1997
@@ -72,24 +72,12 @@
 	struct pci_attach_args *pa = aux;

 	/*
-	 * Match all known PCI-ISA bridges.
+	 * Match all PCI-ISA bridge devices.  The BIOS should have
+	 * set things up so that they all look alike to us.
 	 */
-	if (PCI_VENDOR(pa->pa_id) == PCI_VENDOR_INTEL) {
-		switch (PCI_PRODUCT(pa->pa_id)) {
-		case PCI_PRODUCT_INTEL_SIO:
-		case PCI_PRODUCT_INTEL_PCIB:
-		case PCI_PRODUCT_INTEL_82471:
-		case PCI_PRODUCT_INTEL_82371SB:
-			return (1);
-		}
-	}
-
-	if (PCI_VENDOR(pa->pa_id) == PCI_VENDOR_UMC) {
-		switch (PCI_PRODUCT(pa->pa_id)) {
-		case PCI_PRODUCT_UMC_UM8886F:
-			return (1);
-		}
-	}
+	if (PCI_CLASS(pa->pa_class) == PCI_CLASS_BRIDGE &&
+	    PCI_SUBCLASS(pa->pa_class) == PCI_SUBCLASS_BRIDGE_ISA)
+		return (1);

 	return (0);
 }
@@ -102,15 +90,12 @@
 	struct pci_attach_args *pa = aux;
 	char devinfo[256];

-	printf("\n");
-
 	/*
 	 * Just print out a description and set the ISA bus
 	 * callback.
 	 */
 	pci_devinfo(pa->pa_id, pa->pa_class, 0, devinfo);
-	printf("%s: %s (rev. 0x%02x)\n", self->dv_xname, devinfo,
-	    PCI_REVISION(pa->pa_class));
+	printf(": %s (rev. 0x%02x)\n", devinfo, PCI_REVISION(pa->pa_class));

 	set_pci_isa_bridge_callback(pcib_callback, self);
 }
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->port-i386-maintainer 
Responsible-Changed-By: fair 
Responsible-Changed-When: Mon Dec 28 09:51:37 PST 1998 
Responsible-Changed-Why:  
This PR is the responsibility of the portmaster, 
not the GNATS database administrator. 
State-Changed-From-To: open->closed 
State-Changed-By: fvdl 
State-Changed-When: Sat Feb 6 13:04:13 PST 1999 
State-Changed-Why:  
Was fixed a while ago, through the simple solution. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.