NetBSD Problem Report #34215
From dauphin@enst.fr Wed Aug 16 17:12:37 2006
Return-Path: <dauphin@enst.fr>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by narn.NetBSD.org (Postfix) with ESMTP id 7546163B964
for <gnats-bugs@gnats.netbsd.org>; Wed, 16 Aug 2006 17:12:37 +0000 (UTC)
Message-Id: <1155748349.12881@bi.enst.fr>
Date: Wed, 16 Aug 2006 19:12:29 +0200
From: "Gilles Dauphin" <dauphin@enst.fr>
To: "gnats bugs" <gnats-bugs@NetBSD.org>
Subject: games/grhino
X-Send-Pr-Version: gtk-send-pr 0.4.5
X-GNATS-Notify:
>Number: 34215
>Category: pkg
>Synopsis: games/grhino
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: prlw1
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Aug 16 17:15:00 +0000 2006
>Closed-Date: Sat Jun 01 22:57:10 +0000 2013
>Last-Modified: Sat Jun 01 22:57:10 +0000 2013
>Originator: Gilles Dauphin
>Release: SunOS 5.10 i86pc
>Organization:
ENST
>Environment:
System: SunOS bi.enst.fr 5.10 Generic_Patch_118844-30 i86pc
>Description:
bmake install fail because of Solaris /bin/sh does not support test -e
here is the fault fragment of Makefile
if [ ! -e "/usr/pkg/bin" ]; then \
mkdir -p "/usr/pkg/bin"; \
chmod 755 "/usr/pkg/bin"; \
fi
See the fix
>How-To-Repeat:
bmake install
>Fix:
in games/grhino/Makefile add:
USE_TOOLS+= gmake
and a logical patch:
--- Makefile.in.orig Sat Aug 5 13:30:22 2006
+++ Makefile.in Wed Aug 16 19:06:01 2006
@@ -24,7 +24,7 @@
PACKAGE = @PACKAGE@
VERSION = @VERSION@
-SHELL = /bin/sh
+SHELL = @SHELL@
@SET_MAKE@
srcdir = @srcdir@
>Release-Note:
>Audit-Trail:
From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/34215: games/grhino
Date: Wed, 16 Aug 2006 19:31:38 +0200
On Wed, Aug 16, 2006 at 05:15:01PM +0000, Gilles Dauphin wrote:
> bmake install fail because of Solaris /bin/sh does not support test -e
>
> here is the fault fragment of Makefile
>
> if [ ! -e "/usr/pkg/bin" ]; then \
> mkdir -p "/usr/pkg/bin"; \
> chmod 755 "/usr/pkg/bin"; \
> fi
Whoever wants to fix this, please just kill that check.
Joerg
From: Gilles Dauphin <Gilles.Dauphin@enst.fr>
To: pkg-manager@NetBSD.org, gnats-admin@NetBSD.org,
gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/34215: games/grhino
Date: Wed, 16 Aug 2006 19:49:17 +0200 (CEST)
> Delivered-To: dauphin@enst.fr
> X-Virus-Scanned: amavisd-new at enst.fr
> From: Joerg Sonnenberger <joerg@britannica.bec.de>
> To: pkg-manager@NetBSD.org, gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org,
"Gilles Dauphin" <dauphin@enst.fr>
> Subject: Re: pkg/34215: games/grhino
> X-Gnats-Was-Stupid: no
> Cc:
>
> The following reply was made to PR pkg/34215; it has been noted by GNATS.
>
> From: Joerg Sonnenberger <joerg@britannica.bec.de>
> To: gnats-bugs@NetBSD.org
> Cc:
> Subject: Re: pkg/34215: games/grhino
> Date: Wed, 16 Aug 2006 19:31:38 +0200
>
> On Wed, Aug 16, 2006 at 05:15:01PM +0000, Gilles Dauphin wrote:
> > bmake install fail because of Solaris /bin/sh does not support test -e
> >
> > here is the fault fragment of Makefile
> >
> > if [ ! -e "/usr/pkg/bin" ]; then \
> > mkdir -p "/usr/pkg/bin"; \
> > chmod 755 "/usr/pkg/bin"; \
> > fi
>
> Whoever wants to fix this, please just kill that check.
I think the patch i send is correct. (gmake + Makefile.in) because i show
you just a peace of Makefile.in:
install_mkdir :
if [ ! -e "$(bindir)" ]; then \
mkdir -p "$(bindir)"; \
chmod 755 "$(bindir)"; \
fi
if [ ! -e "$(pattern_dir)" ]; then \
mkdir -p "$(pattern_dir)"; \
chmod 755 "$(pattern_dir)"; \
fi
if [ ! -e "$(book_dir)" ]; then \
mkdir -p "$(book_dir)"; \
chmod 755 "$(book_dir)"; \
fi
if [ ! -e "$(theme_dir)" ]; then \
mkdir -p "$(theme_dir)"; \
chmod 755 "$(theme_dir)"; \
fi
if [ ! -e "$(theme_dir)/small" ]; then \
mkdir -p "$(theme_dir)/small"; \
chmod 755 "$(theme_dir)/small"; \
fi
if [ ! -e "$(helpdir)" ]; then \
mkdir -p "$(helpdir)"; \
chmod 755 "$(helpdir)"; \
fi
if [ ! -e "$(helpdir)/C" ]; then \
mkdir -p "$(helpdir)/C"; \
chmod 755 "$(helpdir)/C"; \
fi
if [ ! -e "$(helpdir)/C/figures" ]; then \
mkdir -p "$(helpdir)/C/figures"; \
chmod 755 "$(helpdir)/C/figures"; \
fi
Gilles
From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/34215: games/grhino
Date: Wed, 16 Aug 2006 20:09:47 +0200
On Wed, Aug 16, 2006 at 05:50:01PM +0000, Gilles Dauphin wrote:
> > > if [ ! -e "/usr/pkg/bin" ]; then \
> > > mkdir -p "/usr/pkg/bin"; \
> > > chmod 755 "/usr/pkg/bin"; \
> > > fi
> >
> > Whoever wants to fix this, please just kill that check.
>
> I think the patch i send is correct. (gmake + Makefile.in) because i show
> you just a peace of Makefile.in:
I didn't say it is wrong, just that this complete target should be
killed and INSTALLATION_DIRS be set appropiately.
Joerg
From: Gilles Dauphin <Gilles.Dauphin@enst.fr>
To: pkg-manager@NetBSD.org, gnats-admin@NetBSD.org,
gnats-bugs@NetBSD.org
Cc: joerg@britannica.bec.de
Subject: Re: pkg/34215: games/grhino
Date: Thu, 17 Aug 2006 10:06:21 +0200 (CEST)
--Tiding_of_Magpies_861_000
Content-Type: TEXT/plain; charset=us-ascii
Content-MD5: Bz4rqwDJjO/aFrNOPuitZQ==
> I didn't say it is wrong, just that this complete target should be
> killed and INSTALLATION_DIRS be set appropiately.
That's ok now , I hope,
Makefile and patch in attachment
(patch is not needed now, but... )
Cheers
Gilles
--Tiding_of_Magpies_861_000
Content-Type: TEXT/x-sun-Makefile; name=Makefile; charset=us-ascii; x-unix-mode=0644
Content-Description: Makefile
Content-MD5: cZfueGeE7mI3KPvh+6VSHA==
# $NetBSD: Makefile,v 1.27 2006/08/06 10:27:57 ghen Exp $
#
DISTNAME= grhino-0.15.1
CATEGORIES= games
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=rhino/}
MAINTAINER= pkgsrc-users@NetBSD.org
HOMEPAGE= http://rhino.sourceforge.net/
COMMENT= Othello (Reversi) engine
USE_LANGUAGES= c c++
USE_TOOLS+= pkg-config msgfmt gmake
GNU_CONFIGURE= yes
USE_DIRS+= gnome2-1.5
USE_PKGLOCALEDIR= yes
INSTALLATION_DIRS+= bin
INSTALLATION_DIRS+= share/${DISTNAME}/pattern
INSTALLATION_DIRS+= share/${DISTNAME}/book
INSTALLATION_DIRS+= share/${DISTNAME}/theme
INSTALLATION_DIRS+= share/${DISTNAME}/theme/small
INSTALLATION_DIRS+= share/gnome/help/grhino
INSTALLATION_DIRS+= share/gnome/help/grhino/C
INSTALLATION_DIRS+= share/gnome/help/grhino/C/figures
.include "../../devel/libgnomeui/buildlink3.mk"
.include "../../textproc/scrollkeeper/omf.mk"
.include "../../mk/pthread.buildlink3.mk"
.include "../../mk/bsd.pkg.mk"
--Tiding_of_Magpies_861_000
Content-Type: TEXT/plain; name=patch-da; charset=us-ascii; x-unix-mode=0644
Content-Description: patch-da
Content-MD5: zUsFdjfxzUzcv/b9okMtgg==
--- Makefile.in.orig Sat Aug 5 13:30:22 2006
+++ Makefile.in Thu Aug 17 09:44:09 2006
@@ -24,7 +24,7 @@
PACKAGE = @PACKAGE@
VERSION = @VERSION@
-SHELL = /bin/sh
+SHELL = @SHELL@
@SET_MAKE@
srcdir = @srcdir@
@@ -477,7 +477,7 @@
chmod 755 "$(helpdir)/C/figures"; \
fi
-install : install_mkdir
+install :
-$(INSTALL_PROGRAM) grhino "$(bindir)/grhino"
-$(INSTALL_PROGRAM) gtp-rhino "$(bindir)/gtp-rhino"
$(INSTALL_DATA) "$(srcdir)/row1.bin" "$(pattern_dir)/row1.bin"
--Tiding_of_Magpies_861_000--
Responsible-Changed-From-To: pkg-manager->prlw1
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Tue, 26 Mar 2013 21:56:08 +0000
Responsible-Changed-Why:
Patch looks good. Patrick, you do GNOME stuff, want to take this?
From: Patrick Welche <prlw1@cam.ac.uk>
To: gnats-bugs@NetBSD.org
Cc: prlw1@NetBSD.org, pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org,
gnats-admin@netbsd.org, bsiegert@NetBSD.org,
Gilles Dauphin <dauphin@enst.fr>
Subject: Re: pkg/34215 (games/grhino)
Date: Sun, 7 Apr 2013 09:39:42 +0100
--Dxnq1zWXvFF0Q93v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
This isn't actually a GNOME program but I'll take a look anyway ;-)
Agreed that the patches look good - the thing that bothers me is that it
doesn't lead to an upstream fix.
The underlying problem is that -e doesn't exist (pun?) in Solaris' sh.
However, -d does, and all the tests are against directories.
Does the attached work for you? (here be tabs)
--Dxnq1zWXvFF0Q93v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="patch-Makefile.in"
$NetBSD$
--- Makefile.in.orig 2013-04-07 08:31:30.000000000 +0000
+++ Makefile.in
@@ -452,43 +452,43 @@ distclean : distclean_curdir
$(adBeginSubdir) $@ $(adEndSubdir)
install_mkdir :
- if [ ! -e "$(DESTDIR)$(bindir)" ]; then \
+ if [ ! -d "$(DESTDIR)$(bindir)" ]; then \
mkdir -p "$(DESTDIR)$(bindir)"; \
chmod 755 "$(DESTDIR)$(bindir)"; \
fi
- if [ ! -e "$(DESTDIR)$(icon_dir)" ]; then \
+ if [ ! -d "$(DESTDIR)$(icon_dir)" ]; then \
mkdir -p "$(DESTDIR)$(icon_dir)"; \
chmod 755 "$(DESTDIR)$(icon_dir)"; \
fi
- if [ ! -e "$(DESTDIR)$(pattern_dir)" ]; then \
+ if [ ! -d "$(DESTDIR)$(pattern_dir)" ]; then \
mkdir -p "$(DESTDIR)$(pattern_dir)"; \
chmod 755 "$(DESTDIR)$(pattern_dir)"; \
fi
- if [ ! -e "$(DESTDIR)$(book_dir)" ]; then \
+ if [ ! -d "$(DESTDIR)$(book_dir)" ]; then \
mkdir -p "$(DESTDIR)$(book_dir)"; \
chmod 755 "$(DESTDIR)$(book_dir)"; \
fi
- if [ ! -e "$(DESTDIR)$(theme_dir)" ]; then \
+ if [ ! -d "$(DESTDIR)$(theme_dir)" ]; then \
mkdir -p "$(DESTDIR)$(theme_dir)"; \
chmod 755 "$(DESTDIR)$(theme_dir)"; \
fi
- if [ ! -e "$(DESTDIR)$(theme_dir)/small" ]; then \
+ if [ ! -d "$(DESTDIR)$(theme_dir)/small" ]; then \
mkdir -p "$(DESTDIR)$(theme_dir)/small"; \
chmod 755 "$(DESTDIR)$(theme_dir)/small"; \
fi
- if [ ! -e "$(DESTDIR)$(omfdir)" ]; then \
+ if [ ! -d "$(DESTDIR)$(omfdir)" ]; then \
mkdir -p "$(DESTDIR)$(omfdir)"; \
chmod 755 "$(DESTDIR)$(omfdir)"; \
fi
- if [ ! -e "$(DESTDIR)$(helpdir)" ]; then \
+ if [ ! -d "$(DESTDIR)$(helpdir)" ]; then \
mkdir -p "$(DESTDIR)$(helpdir)"; \
chmod 755 "$(DESTDIR)$(helpdir)"; \
fi
- if [ ! -e "$(DESTDIR)$(helpdir)/C" ]; then \
+ if [ ! -d "$(DESTDIR)$(helpdir)/C" ]; then \
mkdir -p "$(DESTDIR)$(helpdir)/C"; \
chmod 755 "$(DESTDIR)$(helpdir)/C"; \
fi
- if [ ! -e "$(DESTDIR)$(helpdir)/C/figures" ]; then \
+ if [ ! -d "$(DESTDIR)$(helpdir)/C/figures" ]; then \
mkdir -p "$(DESTDIR)$(helpdir)/C/figures"; \
chmod 755 "$(DESTDIR)$(helpdir)/C/figures"; \
fi
--Dxnq1zWXvFF0Q93v--
From: Benny Siegert <bsiegert@gmail.com>
To: Patrick Welche <prlw1@cam.ac.uk>
Cc: gnats-bugs@netbsd.org, prlw1@netbsd.org, pkg-manager@netbsd.org,
pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org,
Benny Siegert <bsiegert@netbsd.org>, Gilles Dauphin <dauphin@enst.fr>
Subject: Re: pkg/34215 (games/grhino)
Date: Sun, 7 Apr 2013 12:49:58 +0200
Did not test it but it looks good.
--Benny.
From: "Patrick Welche" <prlw1@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/34215 CVS commit: pkgsrc/games/grhino
Date: Mon, 8 Apr 2013 22:10:59 +0000
Module Name: pkgsrc
Committed By: prlw1
Date: Mon Apr 8 22:10:59 UTC 2013
Modified Files:
pkgsrc/games/grhino: Makefile distinfo
Added Files:
pkgsrc/games/grhino/patches: patch-Makefile.in
Removed Files:
pkgsrc/games/grhino/patches: patch-book.cc patch-game.cc
patch-log__proc.h
Log Message:
Update grhino to 0.16.1:
- Fix compilation error with newer GCC versions.
- Backport changes from Debian by Vincent Legout, Martin Michlmayr.
- Fix bad interaction between edit board and preference dialog box.
- Fix bad interaction between edit board and toolbar.
- Fix midgame search when the game finishes without filling the board.
Add patch-Makefile.in to fix PR pkg/34215
Remove patch-book.cc patch-game.cc patch-log__proc.h as:
Change from Debian port by Martin Michlmayr <tbm@cyrius.com>
* book.cc, game.cc, log_proc.h: Include <cstdlib>.
To generate a diff of this commit:
cvs rdiff -u -r1.59 -r1.60 pkgsrc/games/grhino/Makefile
cvs rdiff -u -r1.13 -r1.14 pkgsrc/games/grhino/distinfo
cvs rdiff -u -r0 -r1.1 pkgsrc/games/grhino/patches/patch-Makefile.in
cvs rdiff -u -r1.1 -r0 pkgsrc/games/grhino/patches/patch-book.cc \
pkgsrc/games/grhino/patches/patch-game.cc \
pkgsrc/games/grhino/patches/patch-log__proc.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 01 Jun 2013 22:57:10 +0000
State-Changed-Why:
committed in April
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home