NetBSD Problem Report #34444

From www@NetBSD.org  Fri Sep  1 02:22:40 2006
Return-Path: <www@NetBSD.org>
Received: by narn.NetBSD.org (Postfix, from userid 31301)
	id 6236163B973; Fri,  1 Sep 2006 02:22:40 +0000 (UTC)
Message-Id: <20060901022240.6236163B973@narn.NetBSD.org>
Date: Fri,  1 Sep 2006 02:22:40 +0000 (UTC)
From: jason@lucid.net.au
Reply-To: jason@lucid.net.au
To: gnats-bugs@NetBSD.org
Subject: samba build fails at smbd/server.c
X-Send-Pr-Version: www-1.0

>Number:         34444
>Category:       pkg
>Synopsis:       samba build fails at smbd/server.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    jlam
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 01 02:25:00 +0000 2006
>Closed-Date:    Sat Aug 01 19:36:14 +0000 2009
>Last-Modified:  Wed Sep 09 15:20:02 +0000 2009
>Originator:     Jason Lingohr
>Release:        pkgsrc -current
>Organization:
>Environment:
Linux fully 2.4.31 #7 Wed Jul 20 16:40:54 EST 2005 i686 i686 i386 GNU/Linux

>Description:
When trying to build samba-3.0.22nb2, the compilation fails with not being able to find popt stuff:

Compiling smbd/server.c
smbd/server.c: In function `main':
smbd/server.c:710: `POPT_ARG_VAL' undeclared (first use in this function)
smbd/server.c:710: (Each undeclared identifier is reported only once
smbd/server.c:710: for each function it appears in.)
smbd/server.c:726: warning: passing arg 3 of `poptGetContext' from incompatible pointer type
*** Error code 1

Stop.
bmake: stopped in /data1/netbsd/pkgbuild/net/samba/work/samba-3.0.22/source
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/net/samba
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/net/samba

>How-To-Repeat:
bmake, the build fails.

>Fix:
samba requires popt:

Index: Makefile
===================================================================
RCS file: /netbsd/cvsroot/pkgsrc/net/samba/Makefile,v
retrieving revision 1.162
diff -u -r1.162 Makefile
--- Makefile    11 Jul 2006 07:34:35 -0000      1.162
+++ Makefile    31 Aug 2006 22:56:40 -0000
@@ -65,6 +65,8 @@
 .include "../../devel/readline/buildlink3.mk"
 CONFIGURE_ARGS+=       --with-readline=${BUILDLINK_PREFIX.readline}

+.include "../../devel/popt/buildlink3.mk"
+
 .include "options.mk"

 # Only Linux supports smbmount for mounting a Samba share into the

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->jlam
Responsible-Changed-By: snj@netbsd.org
Responsible-Changed-When: Fri, 01 Sep 2006 02:51:00 +0000
Responsible-Changed-Why:
Over to maintainer.


From: Jason Lingohr <jason@lucid.net.au>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/34444
Date: Mon, 21 Jan 2008 17:33:10 +1100

 Further to the original bug report, this is still an outstanding issue 
 with samba-3.0.26anb4.

From: "Johnny C. Lam" <jlam@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/34444 CVS commit: pkgsrc/net/samba
Date: Thu,  3 Apr 2008 20:19:42 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	jlam
 Date:		Thu Apr  3 20:19:42 UTC 2008

 Modified Files:
 	pkgsrc/net/samba: Makefile Makefile.mirrors Makefile.patches PLIST
 	    distinfo options.mk
 	pkgsrc/net/samba/patches: patch-aa patch-ae patch-at patch-au patch-ax
 	    patch-ay patch-ba patch-be patch-bo patch-br patch-bs patch-ca
 Added Files:
 	pkgsrc/net/samba/patches: patch-db
 Removed Files:
 	pkgsrc/net/samba/patches: patch-ab patch-ah

 Log Message:
 Update samba to version 3.0.28a.

 CHANGES FOR PKGSRC:
 ==================

 Makefile:
   + Modify section that manually handles the ELF symlinks for samba
     shared libraries -- add additional libraries that are built (addns,
     smbsharemodes) and reorganize so we don't need two loops where one
     will do.

   + Pass --with-included-popt to the configure script to force using
     the popt distribution included with samba to avoid any library
     mismatch errors between samba and any installed popt.  This fixes
     PR pkg/34444 by Jason Lingohr.

   + Don't build the smbmount programs on Linux -- they're deprecated in
     favor of the mount.cifs programs.

   + Remove some pkgviews-related settings -- I'm not supporting pkgviews
     installation of samba.

 Makefile.patches:
   + Empty out PATCHFILES because we are updating to the latest release
     of samba, which has all previous patches for security advisories
     already rolled into the main sources.

 Makefile.mirrors:
   + Update SAMBA_MIRRORS in Makefile.mirrors to the latest list of FTP
     mirrors.

 options.mk:
   + Only show the ``acl'' option on platforms that actually support
     POSIX ACLs.

   + Add a new ``fam'' option to enable building the notify_fam VFS
     module.

 patch-ab, patch-ax:
   + Remove patch-ab and update patch-ax -- there's nothing for the
     scripts to back up so we don't need to patch the install* scripts
     to avoid this.

 patch-ae, patch-ah:
   + Update patch-ae and remove patch-ah -- we should definitely check
     that PAM_AUTHTOK_RECOVERY_ERR is defined before using its value to
     define PAM_AUTHTOK_RECOVER_ERR.

 patch-at, patch-au:
   + Fix patch-at and patch-au -- in configure.in, we need to "escape"
     left and right brackets or else m4 will strip them away in the
     resulting configure script.  This should fix the detection of FreeBSD
     and NetBSD systems capable of using nss_winbind noted in PR pkg/38076
     by Ingo Meyer.

 patch-ay:
   + Remove some unnecessary changes -- we can safely just do "mkdir" in
     some places because we know the parent and any intermediate directories
     exist.

 patch-be:
   + Fix a bug in locating WINS_LIST -- nmbd/nmbd_winsserver.c was
     referring to WINS_LIST under the state directory in one place and
     under the lock directory in another; change all references to be
     under the state directory.

 patch-db:
   + Add patch to fix the build of samba on older BSDs.  Patch supplied
     in PR pkg/37487 by John Frear.

 All remaining changes to patches/patch-* are simply to remove fuzz.

 MAJOR CHANGES FROM VERSION 3.0.26a:

 * Fix failure to join Windows 2008 domains.

 * Fix Windows Vista (including SP1 RC) inter-op issues.

 * Add a new ``administrative share'' service parameter for defining
   hidden shares that cannot be managed from Windows.

 * Fix for CVS-2007-6015 (already fixed in 3.0.26anb4 in pkgsrc).

 * Fix for CVS-2007-5398 (already fixed in 3.0.26anb4 in pkgsrc).

 * Fix for CVS-2007-4572 (already fixed in 3.0.26anb4 in pkgsrc).  Also
   subsequent fix for regression experienced by smbfs clients caused by
   the fix for CVS-2007-4572, noted in PR pkg/38300 by Dave Barnes.

 * Many other bugs fixed and memory leaks plugged.


 To generate a diff of this commit:
 cvs rdiff -r1.179 -r1.180 pkgsrc/net/samba/Makefile
 cvs rdiff -r1.4 -r1.5 pkgsrc/net/samba/Makefile.mirrors
 cvs rdiff -r1.7 -r1.8 pkgsrc/net/samba/Makefile.patches
 cvs rdiff -r1.37 -r1.38 pkgsrc/net/samba/PLIST
 cvs rdiff -r1.60 -r1.61 pkgsrc/net/samba/distinfo
 cvs rdiff -r1.22 -r1.23 pkgsrc/net/samba/options.mk
 cvs rdiff -r1.31 -r1.32 pkgsrc/net/samba/patches/patch-aa
 cvs rdiff -r1.26 -r0 pkgsrc/net/samba/patches/patch-ab
 cvs rdiff -r1.8 -r1.9 pkgsrc/net/samba/patches/patch-ae \
     pkgsrc/net/samba/patches/patch-at pkgsrc/net/samba/patches/patch-au
 cvs rdiff -r1.3 -r0 pkgsrc/net/samba/patches/patch-ah
 cvs rdiff -r1.2 -r1.3 pkgsrc/net/samba/patches/patch-ax
 cvs rdiff -r1.3 -r1.4 pkgsrc/net/samba/patches/patch-ay \
     pkgsrc/net/samba/patches/patch-be pkgsrc/net/samba/patches/patch-br
 cvs rdiff -r1.6 -r1.7 pkgsrc/net/samba/patches/patch-ba
 cvs rdiff -r1.4 -r1.5 pkgsrc/net/samba/patches/patch-bo \
     pkgsrc/net/samba/patches/patch-bs pkgsrc/net/samba/patches/patch-ca
 cvs rdiff -r0 -r1.1 pkgsrc/net/samba/patches/patch-db

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: jlam@NetBSD.org
State-Changed-When: Fri, 04 Apr 2008 01:13:12 +0000
State-Changed-Why:
The net/samba was updated to version 3.0.28a along with the following
change to the package Makefile:

   + Pass --with-included-popt to the configure script to force using
     the popt distribution included with samba to avoid any library
     mismatch errors between samba and any installed popt.  This fixes
     PR pkg/34444 by Jason Lingohr.

This should fix the problem noted in this PR.  Please let me know if the
problem still exists.  Thanks!


From: Jason Lingohr <jason@lucid.net.au>
To: gnats-bugs@gnats.netbsd.org
Cc: 
Subject: Re: pkg/34444
Date: Thu, 08 May 2008 22:04:00 +1000

 I'm happy that this issue is resolved, thanks.

From: Jason Lingohr <jason@lucid.net.au>
To: gnats-bugs@gnats.netbsd.org
Cc: 
Subject: Re: pkg/34444
Date: Thu, 08 May 2008 22:25:18 +1000

 Actually, scratch that -- I'm wondering why --with-included-popt was 
 used instead of my patch?

 I'd have thought my patch was a better solution?  pkgsrc's popt is fine 
 for the build, it just needed to .include popt's buildlink info.

 (I'm attempting a build with your fix right now for feedback, but am 
 interested to know why you chose this way.)


State-Changed-From-To: feedback->analyzed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 21 Sep 2008 05:18:29 +0000
State-Changed-Why:
Feedback was received in May, and the problem was resolved, but the submitter
asked what seems a valid question - why use the included popt?


State-Changed-From-To: analyzed->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 01 Aug 2009 19:36:14 +0000
State-Changed-Why:
Guess we aren't going to hear back from jlam. I don't really want to tinker
with this since it works, but I've left myself a note to get it changed
next time there's an update.


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/34444 CVS commit: pkgsrc/net/samba
Date: Wed, 9 Sep 2009 15:15:17 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Wed Sep  9 15:15:17 UTC 2009

 Modified Files:
 	pkgsrc/net/samba: Makefile

 Log Message:
 Switch to using popt from pkgsrc instead of internal version.
 Requested in PR 34444 and by David A. Holland.

 Bump PKGREVISION.


 To generate a diff of this commit:
 cvs rdiff -u -r1.194 -r1.195 pkgsrc/net/samba/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.