NetBSD Problem Report #34942

From eric@egsner.cirr.com  Sun Oct 29 22:09:43 2006
Return-Path: <eric@egsner.cirr.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id ADF9463B8CA
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 29 Oct 2006 22:09:43 +0000 (UTC)
Message-Id: <200610292209.k9TM9OA3027105@egsner.cirr.com>
Date: Sun, 29 Oct 2006 16:09:24 -0600 (CST)
From: Eric Schnoebelen <eric@cirr.com>
Reply-To: eric@cirr.com
To: gnats-bugs@NetBSD.org
Subject: removing compiler warnings in pkgsrc/pkgtools/mtree
X-Send-Pr-Version: 3.95

>Number:         34942
>Category:       pkg
>Synopsis:       remove compiler warnings in pkgsrc/pkgtools/mtree
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Oct 29 22:10:02 +0000 2006
>Closed-Date:    Sun Mar 21 16:33:19 +0000 2010
>Last-Modified:  Sun Mar 21 16:35:06 +0000 2010
>Originator:     Eric Schnoebelen
>Release:        HP-UX B.11.11
>Organization:
Eric Schnoebelen		eric@cirr.com		http://www.cirr.com
  "The nice thing about Windows is - It does not just crash, it 
   displays a dialog box and lets you press 'OK' first." - Arno Schaefer
>Environment:
HP-UX peake B.11.11 A 9000/785 2006709503 two-user license
  B3899BA       B.11.11.06      HP C/ANSI C Developer's Bundle for HP-UX 11.i (S700) 
  B3911DB       C.03.37.01      HP aC++ Compiler (S700)
  FEATURE11-11  B.11.11.0209.5  Feature Enablement Patches for HP-UX 11i, Sept 2002  
  HPUX11i-TCOE  B.11.11.0306    HP-UX Technical Computing OE Component
  HPUXBase64    B.11.11         HP-UX 64-bit Base OS
  HPUXBaseAux   B.11.11.0312    HP-UX Base OS Auxiliary
  HWEnable11i   B.11.11.0312.4  Hardware Enablement Patches for HP-UX 11i v1, December 2003

[ok, the above is only really useful/interesting to an HP-UX weenie, or
the HP WTEC.]

>Description:
        Several source files declare function prototypes as static
at the top, and then fail to repeat the static keyword when declaring
the actual function.
>How-To-Repeat:
        compile with a very picky compiler, such as HP ANSI C.
>Fix:
Index: files/create.c
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/mtree/files/create.c,v
retrieving revision 1.4
diff -b -u -w -r1.4 create.c
--- files/create.c	21 Aug 2004 04:10:45 -0000	1.4
+++ files/create.c	29 Oct 2006 22:08:57 -0000
@@ -400,7 +400,7 @@
 	return (strcmp((*a)->fts_name, (*b)->fts_name));
 }

-void
+static void
 output(int *offset, const char *fmt, ...)
 {
 	va_list ap;

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->grant
Responsible-Changed-By: snj@netbsd.org
Responsible-Changed-When: Mon, 30 Oct 2006 17:43:55 +0000
Responsible-Changed-Why:
Over to maintainer.


Responsible-Changed-From-To: grant->pkg-manager
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Sun, 21 Mar 2010 15:57:45 +0000
Responsible-Changed-Why:
Back to role account, grant lost his commit bit.


State-Changed-From-To: open->closed
State-Changed-By: joerg@NetBSD.org
State-Changed-When: Sun, 21 Mar 2010 16:33:19 +0000
State-Changed-Why:
Applied. Thanks.


From: Joerg Sonnenberger <joerg@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/34942 CVS commit: pkgsrc/pkgtools/mtree/files
Date: Sun, 21 Mar 2010 16:32:06 +0000

 Module Name:	pkgsrc
 Committed By:	joerg
 Date:		Sun Mar 21 16:32:06 UTC 2010

 Modified Files:
 	pkgsrc/pkgtools/mtree/files: create.c

 Log Message:
 Apply patch from PR 34942: Match prototype and body in staticness.


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 pkgsrc/pkgtools/mtree/files/create.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.