NetBSD Problem Report #35092
From www@NetBSD.org Wed Nov 22 04:54:38 2006
Return-Path: <www@NetBSD.org>
Received: by narn.NetBSD.org (Postfix, from userid 31301)
id BF17D63B400; Wed, 22 Nov 2006 04:54:38 +0000 (UTC)
Message-Id: <20061122045438.BF17D63B400@narn.NetBSD.org>
Date: Wed, 22 Nov 2006 04:54:38 +0000 (UTC)
From: naoto@morishima.net
Reply-To: naoto@morishima.net
To: gnats-bugs@NetBSD.org
Subject: proftpd-1.3.0nb1 causes segfaults
X-Send-Pr-Version: www-1.0
>Number: 35092
>Category: pkg
>Synopsis: proftpd-1.3.0nb1 causes segfaults
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: adrianp
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Nov 22 04:55:00 +0000 2006
>Closed-Date: Thu Nov 23 12:04:23 +0000 2006
>Last-Modified: Thu Nov 23 12:35:01 +0000 2006
>Originator: Naoto Morishima
>Release: NetBSD 3.1-STABLE
>Organization:
NAIST
>Environment:
NetBSD XX 3.1_STABLE NetBSD 3.1_STABLE (GENERIC 1.661.2.14/XX 1.3) #0: Wed Nov 8 12:33:52 JST 2006 naoto@xx:/usr/obj/sys/arch/i386/compile/XX.MP i386
>Description:
proftpd causes segfaults by the problem specified in http://sourceforge.net/mailarchive/forum.php?thread_id=30948684&forum_id=33082.
>How-To-Repeat:
>Fix:
Replace patches/patch-ac with something base on following:
http://proftp.cvs.sourceforge.net/proftp/proftpd/src/main.c?r1=1.292&r2=1.294&view=patch&sortby=date
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: pkg-manager->adrianp
Responsible-Changed-By: adrianp@netbsd.org
Responsible-Changed-When: Wed, 22 Nov 2006 06:53:44 +0000
Responsible-Changed-Why:
I'm responsible for patch-ac so I'll grab this.
From: Adrian Portelli <adrianp@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: naoto@morishima.net
Subject: Re: pkg/35092 (proftpd-1.3.0nb1 causes segfaults)
Date: Wed, 22 Nov 2006 20:07:53 +0000
This is a multi-part message in MIME format.
--------------000607070206020203070607
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Hi,
Could you please try the attached patch and let me know how you get on.
thanks,
adrian.
--------------000607070206020203070607
Content-Type: text/plain;
name="proftpd.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="proftpd.diff"
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/net/proftpd/Makefile,v
retrieving revision 1.36
diff -u -r1.36 Makefile
--- Makefile 18 Nov 2006 14:32:58 -0000 1.36
+++ Makefile 22 Nov 2006 20:04:03 -0000
@@ -1,7 +1,7 @@
# $NetBSD: Makefile,v 1.36 2006/11/18 14:32:58 adrianp Exp $
DISTNAME= proftpd-1.3.0
-PKGREVISION= 1
+PKGREVISION= 2
CATEGORIES= net
MASTER_SITES= ftp://ftp.proftpd.org/distrib/source/ \
ftp://ftp.servus.at/ProFTPD/distrib/source/ \
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/net/proftpd/distinfo,v
retrieving revision 1.19
diff -u -r1.19 distinfo
--- distinfo 18 Nov 2006 14:32:58 -0000 1.19
+++ distinfo 22 Nov 2006 20:04:03 -0000
@@ -5,4 +5,4 @@
Size (proftpd-1.3.0.tar.bz2) = 1386086 bytes
SHA1 (patch-aa) = 5ebfe97a0edb8ecee7495fd5d487eff3cf32d1fe
SHA1 (patch-ab) = 8886177b90089c8a2fa580aceb7a0514fe0ea6a7
-SHA1 (patch-ac) = 25a0b27773e5e025096cf08ad33243aaf143fbb8
+SHA1 (patch-ac) = 4cdfd0cff027524c38785a5a45bae747e3b151f7
Index: patches/patch-ac
===================================================================
RCS file: /cvsroot/pkgsrc/net/proftpd/patches/patch-ac,v
retrieving revision 1.5
diff -u -r1.5 patch-ac
--- patches/patch-ac 18 Nov 2006 14:32:58 -0000 1.5
+++ patches/patch-ac 22 Nov 2006 20:04:03 -0000
@@ -1,47 +1,49 @@
-$NetBSD: patch-ac,v 1.5 2006/11/18 14:32:58 adrianp Exp $
+$NetBSD$
---- src/main.c.orig 2006-11-18 14:24:35.000000000 +0000
+--- src/main.c.orig 2006-03-15 19:41:01.000000000 +0000
+++ src/main.c
@@ -116,6 +116,8 @@ static unsigned char have_dead_child = F
static char sbuf[PR_TUNABLE_BUFFER_SIZE] = {'\0'};
-+#define PR_DEFAULT_CMD_BUFSZ 512
++#define PR_DEFAULT_CMD_BUFSZ 512
+
static char **Argv = NULL;
static char *LastArgv = NULL;
static const char *PidPath = PR_PID_FILE_PATH;
-@@ -820,16 +822,25 @@ static void cmd_loop(server_rec *server,
+@@ -820,17 +822,24 @@ static void cmd_loop(server_rec *server,
pr_timer_reset(TIMER_IDLE, NULL);
if (cmd_buf_size == -1) {
- long *buf_size = get_param_ptr(main_server->conf,
- "CommandBufferSize", FALSE);
-+ int *bufsz = get_param_ptr(main_server->conf, "CommandBufferSize",
-+ FALSE);
-
+-
- if (buf_size == NULL || *buf_size <= 0)
- cmd_buf_size = 512;
-+ if (bufsz == NULL ||
-+ *bufsz <= 0) {
-+ pr_log_pri(PR_LOG_WARNING, "invalid CommandBufferSize size (%d) "
-+ "given, resetting to default buffer size (%u)",
-+ *bufsz, (unsigned int) PR_DEFAULT_CMD_BUFSZ);
-+ cmd_buf_size = PR_DEFAULT_CMD_BUFSZ;
-+
-+ } else if (*bufsz + 1 > sizeof(buf)) {
-+ pr_log_pri(PR_LOG_WARNING, "invalid CommandBufferSize size (%d) "
-+ "given, resetting to default buffer size (%u)",
-+ *bufsz, (unsigned int) PR_DEFAULT_CMD_BUFSZ);
-+ cmd_buf_size = PR_DEFAULT_CMD_BUFSZ;
-
+-
- else if (*buf_size + 1 > sizeof(buf)) {
- pr_log_pri(PR_LOG_WARNING, "Invalid CommandBufferSize size given. "
- "Resetting to 512.");
- cmd_buf_size = 512;
-+ } else {
-+ pr_log_debug(DEBUG1, "setting CommandBufferSize to %d", *bufsz);
-+ cmd_buf_size = (long) *bufsz;
- }
+- }
++ int *bufsz = get_param_ptr(main_server->conf, "CommandBufferSize", FALSE);
++ if (bufsz == NULL) {
++ cmd_buf_size = PR_DEFAULT_CMD_BUFSZ;
++ }
++ else if ( bufsz <= 0 ) {
++ pr_log_pri(PR_LOG_WARNING, "invalid CommandBufferSize size (%d) "
++ "given, resetting to default buffer size (%u)",
++ *bufsz, (unsigned int) PR_DEFAULT_CMD_BUFSZ);
++ cmd_buf_size = PR_DEFAULT_CMD_BUFSZ;
++ } else if (*bufsz + 1 > sizeof(buf)) {
++ pr_log_pri(PR_LOG_WARNING, "invalid CommandBufferSize size (%d) "
++ "given, using default buffer size (%u) instead",
++ *bufsz, (unsigned int) PR_DEFAULT_CMD_BUFSZ);
++ cmd_buf_size = PR_DEFAULT_CMD_BUFSZ;
++ } else {
++ pr_log_debug(DEBUG1, "setting CommandBufferSize to %d", *bufsz);
++ cmd_buf_size = (long) *bufsz;
++ }
}
+ buf[cmd_buf_size - 1] = '\0';
--------------000607070206020203070607--
From: Naoto Morishima <naoto@morishima.net>
To: Adrian Portelli <adrianp@NetBSD.org>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/35092 (proftpd-1.3.0nb1 causes segfaults)
Date: Thu, 23 Nov 2006 12:13:24 +0900
>>>>> On Wed, 22 Nov 2006 20:07:53 +0000, Adrian Portelli <adrianp@NetBSD.org> said:
adrianp> Could you please try the attached patch and let me know how you get on.
This patch seems good; now it works well. Thanks!
-- Naoto Morishima
From: Adrian Portelli <adrianp@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: PR/35092 CVS commit: pkgsrc/net/proftpd
Date: Thu, 23 Nov 2006 11:57:07 +0000 (UTC)
Module Name: pkgsrc
Committed By: adrianp
Date: Thu Nov 23 11:57:07 UTC 2006
Modified Files:
pkgsrc/net/proftpd: Makefile distinfo
pkgsrc/net/proftpd/patches: patch-ac
Log Message:
Updated patch-ac via Debian to fix PR #35092
To generate a diff of this commit:
cvs rdiff -r1.36 -r1.37 pkgsrc/net/proftpd/Makefile
cvs rdiff -r1.19 -r1.20 pkgsrc/net/proftpd/distinfo
cvs rdiff -r1.5 -r1.6 pkgsrc/net/proftpd/patches/patch-ac
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: adrianp@netbsd.org
State-Changed-When: Thu, 23 Nov 2006 12:04:23 +0000
State-Changed-Why:
Submitter confirmed fix and requested pullup into -stable. Thanks for the PR !
From: Geert Hendrickx <ghen@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: PR/35092 CVS commit: [pkgsrc-2006Q3] pkgsrc/net/proftpd
Date: Thu, 23 Nov 2006 12:30:28 +0000 (UTC)
Module Name: pkgsrc
Committed By: ghen
Date: Thu Nov 23 12:30:27 UTC 2006
Modified Files:
pkgsrc/net/proftpd [pkgsrc-2006Q3]: Makefile distinfo
pkgsrc/net/proftpd/patches [pkgsrc-2006Q3]: patch-ac
Log Message:
Pullup ticket 1920 - requested by adrianp
fix security fix for proftpd
- pkgsrc/net/proftpd/Makefile 1.37
- pkgsrc/net/proftpd/distinfo 1.20
- pkgsrc/net/proftpd/patches/patch-ac 1.6
Module Name: pkgsrc
Committed By: adrianp
Date: Thu Nov 23 11:57:07 UTC 2006
Modified Files:
pkgsrc/net/proftpd: Makefile distinfo
pkgsrc/net/proftpd/patches: patch-ac
Log Message:
Updated patch-ac via Debian to fix PR #35092
To generate a diff of this commit:
cvs rdiff -r1.35.4.1 -r1.35.4.2 pkgsrc/net/proftpd/Makefile
cvs rdiff -r1.18.4.1 -r1.18.4.2 pkgsrc/net/proftpd/distinfo
cvs rdiff -r1.4.6.1 -r1.4.6.2 pkgsrc/net/proftpd/patches/patch-ac
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.