NetBSD Problem Report #35113

From khym@azeotrope.org  Fri Nov 24 20:44:07 2006
Return-Path: <khym@azeotrope.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 7CF3F63B400
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 24 Nov 2006 20:44:07 +0000 (UTC)
Message-Id: <20061124192213.736261C7CB1@yerfable.azeotrope.org>
Date: Fri, 24 Nov 2006 13:22:13 -0600 (CST)
From: khym@azeotrope.org
Reply-To: khym@azeotrope.org
To: gnats-bugs@NetBSD.org
Subject: Minor rum(4) fixes
X-Send-Pr-Version: 3.95

>Number:         35113
>Category:       kern
>Synopsis:       Minor rum(4) fixes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 24 20:45:00 +0000 2006
>Closed-Date:    Mon May 07 05:45:45 +0000 2007
>Last-Modified:  Sat May 12 17:10:01 +0000 2007
>Originator:     Dave Huang
>Release:        NetBSD 4.99.3
>Organization:
Name: Dave Huang         |  Mammal, mammal / their names are called /
INet: khym@azeotrope.org |  they raise a paw / the bat, the cat /
FurryMUCK: Dahan         |  dolphin and dog / koala bear and hog -- TMBG
Dahan: Hani G Y+C 30 Y++ L+++ W- C++ T++ A+ E+ S++ V++ F- Q+++ P+ B+ PA+ PL++
>Environment:


System: NetBSD ia.azeotrope.org 4.99.4 NetBSD 4.99.4 (IA1) #1: Fri Nov 24 13:13:02 CST 2006  khym@vmbsd.azeotrope.org:/usr/obj.i386/sys/arch/i386/compile/IA1 i386
Architecture: i386
Machine: i386
>Description:
	The rum(4) manpage says that the driver supports the ASUS
WL-167g version 2, but mine has a USB vendor/product ID that's not
listed in the driver.

	Also, the driver autoconf definition doesn't pull in firmload,
so kernels without any other devices that need firmload won't link.

	And finally, the rum(4) manpage gives the wrong path to the
firmware file.

>How-To-Repeat:

>Fix:
Index: share/man/man4/rum.4
===================================================================
RCS file: /cvsroot/src/share/man/man4/rum.4,v
retrieving revision 1.2
diff -u -r1.2 rum.4
--- share/man/man4/rum.4	31 Oct 2006 22:49:01 -0000	1.2
+++ share/man/man4/rum.4	24 Nov 2006 19:08:41 -0000
@@ -215,7 +215,7 @@
 The following firmware file is loaded when an interface is brought up:
 .Pp
 .Bl -tag -width Ds -offset indent -compact
-.It /etc/firmware/rum-rt2573
+.It /libdata/firmware/rum/rum-rt2573
 .El
 .Sh HARDWARE
 The following adapters should work:
Index: sys/dev/usb/files.usb
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/files.usb,v
retrieving revision 1.72
diff -u -r1.72 files.usb
--- sys/dev/usb/files.usb	31 Oct 2006 22:21:17 -0000	1.72
+++ sys/dev/usb/files.usb	24 Nov 2006 19:11:14 -0000
@@ -259,7 +259,7 @@
 attach	ral at usbdevif with ural
 file	dev/usb/if_ural.c		ural

-device	rum: ether, ifnet, arp, wlan
+device	rum: ether, ifnet, arp, wlan, firmload
 attach	rum at usbdevif
 file	dev/usb/if_rum.c		rum

Index: sys/dev/usb/if_rum.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/if_rum.c,v
retrieving revision 1.2
diff -u -r1.2 if_rum.c
--- sys/dev/usb/if_rum.c	1 Nov 2006 08:39:25 -0000	1.2
+++ sys/dev/usb/if_rum.c	24 Nov 2006 19:11:16 -0000
@@ -89,6 +89,7 @@
 /* various supported device vendors/products */
 static const struct usb_devno rum_devs[] = {
 	{ USB_VENDOR_ABOCOM,		USB_PRODUCT_ABOCOM_RT2573 },
+	{ USB_VENDOR_ASUSTEK,		USB_PRODUCT_ASUSTEK_WL167G_2 },
 	{ USB_VENDOR_BELKIN,		USB_PRODUCT_BELKIN_F5D7050A },
 	{ USB_VENDOR_BELKIN,		USB_PRODUCT_BELKIN_F5D9050V3 },
 	{ USB_VENDOR_CISCOLINKSYS,	USB_PRODUCT_CISCOLINKSYS_WUSB54GC },
Index: sys/dev/usb/usbdevs
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs,v
retrieving revision 1.442
diff -u -r1.442 usbdevs
--- sys/dev/usb/usbdevs	22 Nov 2006 17:57:40 -0000	1.442
+++ sys/dev/usb/usbdevs	24 Nov 2006 19:11:19 -0000
@@ -626,6 +626,7 @@

 /* ASUSTeK computer products */
 product ASUSTEK WL167G		0x1707	WL-167g USB2.0 WLAN Adapter
+product ASUSTEK WL167G_2	0x1723	WL-167g USB2.0 WLAN Adapter (version 2)

 /* ATen products */
 product ATEN UC1284		0x2001	Parallel printer adapter

>Release-Note:

>Audit-Trail:
From: Juan Romero Pardines <xtraeme@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/35113 CVS commit: src/sys/dev/usb
Date: Mon,  7 May 2007 05:44:00 +0000 (UTC)

 Module Name:	src
 Committed By:	xtraeme
 Date:		Mon May  7 05:44:00 UTC 2007

 Modified Files:
 	src/sys/dev/usb: if_rum.c usbdevs

 Log Message:
 Add support for ASUS WL-167g ver 2, from PR kern/35113 (Dave Huang).


 To generate a diff of this commit:
 cvs rdiff -r1.9 -r1.10 src/sys/dev/usb/if_rum.c
 cvs rdiff -r1.462 -r1.463 src/sys/dev/usb/usbdevs

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: xtraeme@netbsd.org
State-Changed-When: Mon, 07 May 2007 05:45:45 +0000
State-Changed-Why:
Patch applied, I will request a pull up for netbsd-4.
Thanks.


From: Soren Jacobsen <snj@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/35113 CVS commit: [netbsd-4] src/sys/dev/usb
Date: Sat, 12 May 2007 17:08:13 +0000 (UTC)

 Module Name:	src
 Committed By:	snj
 Date:		Sat May 12 17:08:13 UTC 2007

 Modified Files:
 	src/sys/dev/usb [netbsd-4]: files.usb if_rum.c usbdevs

 Log Message:
 Pull up following revision(s) (requested by xtraeme in ticket #617):
 	sys/dev/usb/usbdevs: revision 1.463
 	sys/dev/usb/if_rum.c: revision 1.10
 	sys/dev/usb/files.usb: revision 1.75
 Add support for ASUS WL-167g ver 2, from PR kern/35113 (Dave Huang).

 add firmload attribute to rum, thanks to Paul Goyette on current-users


 To generate a diff of this commit:
 cvs rdiff -r1.72 -r1.72.2.1 src/sys/dev/usb/files.usb
 cvs rdiff -r1.3.2.2 -r1.3.2.3 src/sys/dev/usb/if_rum.c
 cvs rdiff -r1.443.2.3 -r1.443.2.4 src/sys/dev/usb/usbdevs

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.