NetBSD Problem Report #35218

From dholland@eecs.harvard.edu  Sat Dec  9 07:10:45 2006
Return-Path: <dholland@eecs.harvard.edu>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id AC18963BA6F
	for <gnats-bugs@gnats.NetBSD.org>; Sat,  9 Dec 2006 07:10:45 +0000 (UTC)
Message-Id: <20061209071041.0495EF8B2@tanaqui.eecs.harvard.edu>
Date: Sat,  9 Dec 2006 02:10:40 -0500 (EST)
From: dholland@eecs.harvard.edu
Reply-To: dholland@eecs.harvard.edu
To: gnats-bugs@NetBSD.org
Subject: bad make syntax in mk/apache.mk
X-Send-Pr-Version: 3.95

>Number:         35218
>Category:       pkg
>Synopsis:       bad make syntax in mk/apache.mk
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 09 07:15:00 +0000 2006
>Closed-Date:    Sat Dec 09 08:24:22 +0000 2006
>Last-Modified:  Sat Dec 09 08:25:00 +0000 2006
>Originator:     David A. Holland <dholland@eecs.harvard.edu>
>Release:        NetBSD 4.99.3 (pkgsrc of 20061208)
>Organization:
   Harvard EECS
>Environment:
System: NetBSD tanaqui 4.99.3 NetBSD 4.99.3 (TANAQUI) #6: Tue Oct 10 19:32:37 EDT 2006 dholland@tanaqui:/usr/src/sys/arch/i386/compile/TANAQUI i386
Architecture: i386
Machine: i386
>Description:

mk/apache.mk contains a conditional with C syntax, which make appears
to interpret as always true, and so the wrong thing happens.

>How-To-Repeat:

Try building ap-php for apache-1.3 and watch it go and try to install
the apr package for apache 2.2.

I'm not sure if this ends up being harmful or not, because it was
happening on a production machine.

>Fix:

Index: mk/apache.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/apache.mk,v
retrieving revision 1.17
diff -u -r1.17 apache.mk
--- mk/apache.mk	8 Dec 2006 23:58:46 -0000	1.17
+++ mk/apache.mk	9 Dec 2006 07:05:40 -0000
@@ -125,8 +125,8 @@

 .if (${PKG_APACHE} == "apache2") && !empty(USE_APR:M[yY][eE][sS])
 .  include "../../devel/apr/buildlink3.mk"
-.else if (${PKG_APACHE} == "apache22") && !empty(USE_APR:M[Yy][Ee][Ss])
+.elif (${PKG_APACHE} == "apache22") && !empty(USE_APR:M[Yy][Ee][Ss])
 .  include "../../devel/apr1/buildlink3.mk"
 .endif

 .endif	# APACHE_MK

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@netbsd.org
State-Changed-When: Sat, 09 Dec 2006 08:24:22 +0000
State-Changed-Why:
Committed, thank you!


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/35218 CVS commit: pkgsrc/mk
Date: Sat,  9 Dec 2006 08:24:10 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Sat Dec  9 08:24:10 UTC 2006

 Modified Files:
 	pkgsrc/mk: apache.mk

 Log Message:
 ".else if" -> ".elif", from David A. Holland in PR 35218.


 To generate a diff of this commit:
 cvs rdiff -r1.17 -r1.18 pkgsrc/mk/apache.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.