From www@NetBSD.org Tue Feb 20 11:32:00 2007
Return-Path: <www@NetBSD.org>
Received: by narn.NetBSD.org (Postfix, from userid 31301)
id A5E8863B879; Tue, 20 Feb 2007 11:32:00 +0000 (UTC)
Message-Id: <20070220113200.A5E8863B879@narn.NetBSD.org>
Date: Tue, 20 Feb 2007 11:32:00 +0000 (UTC)
From: srcshelton@gmail.com
Reply-To: srcshelton@gmail.com
To: gnats-bugs@NetBSD.org
Subject: Recent wrapper/transform updates break MIPSpro compilers
X-Send-Pr-Version: www-1.0
>Number: 35729
>Category: pkg
>Synopsis: Recent wrapper/transform updates break MIPSpro compilers
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: rillig
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Feb 20 11:35:00 +0000 2007
>Closed-Date: Wed Mar 07 04:55:05 +0000 2007
>Last-Modified: Wed Mar 07 04:55:05 +0000 2007
>Originator: Stuart Shelton
>Release: n/a
>Organization:
>Environment:
IRIX64 octane 6.5 07202013 IP30
(MIPSpro 7.4.4m on IRIX 6.5.30)
>Description:
According to the mk/defaults/mk.conf file, the correct values for 'ABI' are "64 (64 bit ABI), 32 (SGI's N32 ABI), undefined (SGI's old o32 ABI)"
However, the update transform-mipspro-cc has:
"
-32 |\
-n32 |\
-64 ) if [ $arg = "-$wrapper_abi" ]; then
transform_pass
else
transform_fail "Wrong ABI argument $arg for ABI $wrapper_abi."
fi ;;
"
... which will fail for the most common configuration - n32 (since '-n32' != '-32').
There is a mismatch here between what mk.conf expects (ABI='32' for n32) and what transform-mipspro-cc expects (ABI='n32' for n32).
Additionally, also in transform-mipspro-cc, when filtering -O options, '-OPT:*' should also be allowed.
>How-To-Repeat:
Attempt to build any software with ABI=32 (to enable n32 ABI) on IRIX.
>Fix:
With the mk.conf documentation needs to be updated to state ABI="n32" for n32 (which would be more obvious, but could lead to regressions), or alter the logic in transform-mipspro-cc to treat '-n32' differently from '-32' and '-64'.
(Background: -n32 enables the canonical default ABI for IRIX 6.x; -32 is the "old" 32bit ABI which is only used to IRIX 5.x compatibility)
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: pkg-manager->rillig
Responsible-Changed-By: rillig@netbsd.org
Responsible-Changed-When: Tue, 20 Feb 2007 16:13:51 +0000
Responsible-Changed-Why:
I've broken it, so I'll fix it.
State-Changed-From-To: open->feedback
State-Changed-By: rillig@netbsd.org
State-Changed-When: Tue, 20 Feb 2007 16:13:51 +0000
State-Changed-Why:
Please try transform-mipspro-cc revision 1.9.
I hope I've got the details right.
From: Roland Illig <rillig@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: PR/35729 CVS commit: pkgsrc/mk/wrapper
Date: Tue, 20 Feb 2007 16:12:43 +0000 (UTC)
Module Name: pkgsrc
Committed By: rillig
Date: Tue Feb 20 16:12:42 UTC 2007
Modified Files:
pkgsrc/mk/wrapper: transform-mipspro-cc
Log Message:
Mapping command line options to the ABI is not as simple as I thought:
-32 does _not_ belong to ABI 32. Instead, the mapping is:
ABI Options
(undef) -o32 -32
32 -n32
64 -64
While here, allowing -OPT:* to pass through to the compiler, since it
will understand it.
This should fix PR 35729.
To generate a diff of this commit:
cvs rdiff -r1.8 -r1.9 pkgsrc/mk/wrapper/transform-mipspro-cc
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: feedback->closed
State-Changed-By: rillig@netbsd.org
State-Changed-When: Wed, 07 Mar 2007 04:55:05 +0000
State-Changed-Why:
It works for me, so I regard it as fixed.
>Unformatted:
|
|