NetBSD Problem Report #35739
From ad@razor.hairylemon.org Tue Feb 20 17:07:56 2007
Return-Path: <ad@razor.hairylemon.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by narn.NetBSD.org (Postfix) with ESMTP id 3E88863B879
for <gnats-bugs@gnats.NetBSD.org>; Tue, 20 Feb 2007 17:07:56 +0000 (UTC)
Message-Id: <200702201707.l1KH7ndA000304@razor.hairylemon.org>
Date: Tue, 20 Feb 2007 17:07:49 GMT
From: ad@netbsd.org
Reply-To: ad@netbsd.org
To: gnats-bugs@NetBSD.org
Subject: recent addition of RASOPS_ROTATION breaks wsfont
X-Send-Pr-Version: 3.95
>Number: 35739
>Category: kern
>Synopsis: recent addition of RASOPS_ROTATION breaks wsfont
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Feb 20 17:10:04 +0000 2007
>Originator: Andrew Doran
>Release: NetBSD 4.99.10
>Organization:
The NetBSD Project
>Environment:
N/A
>Description:
The RASOPS_ROTATION stuff breaks the wsfont abstraction, since callers now
mess with the font data on their own. If I recall, this means fonts in use
by other displays can have their glyphs changed.
>How-To-Repeat:
Code inspection
>Fix:
rasops shouldn't mess with the font data. The 'rotation' should be another
attribute encoded in the cookie returned by wsfont_find(), and if the font
needs to be rotated it should be done by wsfont_lock(), not the caller. Once
that's done, the rotation code in wsfont shouldn't be conditionalized - it's
small enough.
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.