NetBSD Problem Report #35964

From root@intrepid.dnsalias.com  Fri Mar  9 23:07:12 2007
Return-Path: <root@intrepid.dnsalias.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 7708F63BBF3
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  9 Mar 2007 23:07:12 +0000 (UTC)
Message-Id: <E1HPoB0-0002bi-OD@intrepid.warped.com>
Date: Fri, 09 Mar 2007 15:07:06 -0800
From: scotte@warped.com
Reply-To: scotte@warped.com
To: gnats-bugs@NetBSD.org
Subject: SHAREDSTRINGS breaks build
X-Send-Pr-Version: 3.95

>Number:         35964
>Category:       toolchain
>Synopsis:       Setting SHAREDSTRINGS=yes causes build to fail
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lukem
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 09 23:10:03 +0000 2007
>Closed-Date:    Wed May 24 13:12:35 +0000 2023
>Last-Modified:  Wed May 24 16:45:01 +0000 2023
>Originator:     Scott Ellis
>Release:        NetBSD 4.99.13
>Organization:

>Environment:


System: NetBSD intrepid 4.99.13 NetBSD 4.99.13 (INTREPID.AMD64) #3: Wed Feb 28 18:37:37 PST 2007 scotte@intrepid:/nbu/source/netbsd/src/obj.amd64/nbu/source/netbsd/src/sys/arch/amd64/compile/INTREPID.AMD64 amd64
Architecture: x86_64
Machine: amd64
>Description:

Setting SHAREDSTRINGS=yes in mk.conf, and building using build.sh fails when
building 'dc' with:

/data/scotte/netbsd_build/amd64/tooldir/bin/x86_64--netbsd-gcc -E  -D_POSIX_SOUR
CE -I. -I/nbu/source/netbsd/src/gnu/usr.bin/bc  -I/nbu/source/netbsd/src/gnu/dis
t/bc/dc -I/nbu/source/netbsd/src/gnu/dist/bc/h   -nostdinc -isystem /data/scotte
/netbsd_build/amd64/destdir/usr/include -O2 -pipe  -Werror -march=k8 -fstack-pro
tector -Wstack-protector --param ssp-buffer-size=1  /nbu/source/netbsd/src/gnu/d
ist/bc/lib/number.c | xstr -c -
/nbu/source/netbsd/src/gnu/dist/bc/lib/number.c:1424: error: invalid initializer

This has happened for quite some time, and I never got around to filing a bug
report about it till now (occuring with -current as of March 9, 2007).

Removing SHAREDSTRINGS=yes from mk.conf allows the build to proceed just fine.

>How-To-Repeat:

Build using build.sh and SHAREDSTRINGS=yes .

>Fix:


>Release-Note:

>Audit-Trail:
From: David Laight <david@l8s.co.uk>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: toolchain/35964: SHAREDSTRINGS breaks build
Date: Sat, 10 Mar 2007 08:33:16 +0000

 On Fri, Mar 09, 2007 at 11:10:03PM +0000, scotte@warped.com wrote:
 > >Number:         35964
 > >Category:       toolchain
 > >Synopsis:       Setting SHAREDSTRINGS=yes causes build to fail

 The whole operation is rather pointless.
 Recent versions of gcc and gld consprire to merge strings at the link
 phase, and without making parts of the C source painful to read.

 	David

 -- 
 David Laight: david@l8s.co.uk

From: Scott Ellis <scotte@warped.com>
To: gnats-bugs@NetBSD.org
Cc: toolchain-manager@NetBSD.org, gnats-admin@NetBSD.org,
	netbsd-bugs@NetBSD.org
Subject: Re: toolchain/35964: SHAREDSTRINGS breaks build
Date: Sat, 10 Mar 2007 11:24:12 -0800

 David Laight wrote:
 >  The whole operation is rather pointless.
 >  Recent versions of gcc and gld consprire to merge strings at the link
 >  phase, and without making parts of the C source painful to read.

 I tend to agree, however it is documented in /usr/share/mk/bsd.README
 (which is referenced from mk.conf(5)).

 We should probably either remove it from bsd.README, or make it work.

Responsible-Changed-From-To: toolchain-manager->lukem
Responsible-Changed-By: lukem@NetBSD.org
Responsible-Changed-When: Sun, 21 May 2023 18:16:53 +0000
Responsible-Changed-Why:
I'll take this.

I don't think that SHAREDSTRINGS has worked for even longer than this PR,
probably not since 2003, or even earlier.

I've proposed to deprecate the non-functional feature on tech-toolchain:
  https://mail-index.netbsd.org/tech-toolchain/2023/05/21/msg004273.html


From: "Luke Mewburn" <lukem@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/35964 CVS commit: src/share/mk
Date: Wed, 24 May 2023 10:07:17 +0000

 Module Name:	src
 Committed By:	lukem
 Date:		Wed May 24 10:07:16 UTC 2023

 Modified Files:
 	src/share/mk: bsd.README bsd.prog.mk

 Log Message:
 deprecate SHAREDSTRINGS build option

 Hasn't worked for at least 20 years (and never in the cross-build environment,
 nor did it work with parallel make), and has never been needed in NetBSD as we
 don't have the older BSD programs (pascal, pre-nvi ex) that needed mkstr/xstr
 on PDP-11.

 PR toolchain/35964


 To generate a diff of this commit:
 cvs rdiff -u -r1.442 -r1.443 src/share/mk/bsd.README
 cvs rdiff -u -r1.343 -r1.344 src/share/mk/bsd.prog.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Luke Mewburn" <lukem@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/35964 CVS commit: src
Date: Wed, 24 May 2023 13:00:16 +0000

 Module Name:	src
 Committed By:	lukem
 Date:		Wed May 24 13:00:16 UTC 2023

 Modified Files:
 	src/distrib/evbsh3/rom/ramdiskcommon: ramdiskbin.conf
 	src/distrib/sets/lists/comp: mi
 	src/distrib/sets/lists/debug: mi
 	src/usr.bin: Makefile
 	src/usr.bin/crunch/examples: really-big.conf
 	src/usr.sbin/makemandb: nostem.txt
 Removed Files:
 	src/usr.bin/mkstr: Makefile mkstr.1 mkstr.c
 	src/usr.bin/xstr: Makefile pathnames.h xstr.1 xstr.c

 Log Message:
 obsolete mkstr(1) and xstr(1)

 These were only used on PDP-11 for two programs we don't ship,
 and have been obsolete since the VAX days.

 xstr never worked in the build.sh cross-build environment (22 years), or
 parallel make environment (nearly 28 years), didn't work in the orignal 386bsd
 import, and has never been needed in NetBSD as we don't have the older BSD
 programs (pascal, pre-nvi ex) that needed mkstr/xstr on PDP-11.

 PR toolchain/35964


 To generate a diff of this commit:
 cvs rdiff -u -r1.10 -r1.11 \
     src/distrib/evbsh3/rom/ramdiskcommon/ramdiskbin.conf
 cvs rdiff -u -r1.2428 -r1.2429 src/distrib/sets/lists/comp/mi
 cvs rdiff -u -r1.398 -r1.399 src/distrib/sets/lists/debug/mi
 cvs rdiff -u -r1.238 -r1.239 src/usr.bin/Makefile
 cvs rdiff -u -r1.5 -r1.6 src/usr.bin/crunch/examples/really-big.conf
 cvs rdiff -u -r1.3 -r0 src/usr.bin/mkstr/Makefile
 cvs rdiff -u -r1.14 -r0 src/usr.bin/mkstr/mkstr.1
 cvs rdiff -u -r1.17 -r0 src/usr.bin/mkstr/mkstr.c
 cvs rdiff -u -r1.3 -r0 src/usr.bin/xstr/Makefile
 cvs rdiff -u -r1.4 -r0 src/usr.bin/xstr/pathnames.h
 cvs rdiff -u -r1.20 -r0 src/usr.bin/xstr/xstr.1
 cvs rdiff -u -r1.26 -r0 src/usr.bin/xstr/xstr.c
 cvs rdiff -u -r1.7 -r1.8 src/usr.sbin/makemandb/nostem.txt

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: lukem@NetBSD.org
State-Changed-When: Wed, 24 May 2023 13:12:35 +0000
State-Changed-Why:

I've removed SHAREDSTRINGS from share/mk.
AFAICT, it never worked, even back to the 386bsd 0.1 import,
and nothing used it even then.
It didn't work in parallel make (1995) nor build.sh cross-build
(USE_NEW_TOOLCHAIN) (2001).

I also removed xstr and mkstr, since they only made sense for PDP-11
and weren't relevant even for VAX, and again, nothing in tree used them.



From: Robert Elz <kre@munnari.OZ.AU>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: toolchain/35964 (Setting SHAREDSTRINGS=yes causes build to fail)
Date: Wed, 24 May 2023 23:42:28 +0700

     Date:        Wed, 24 May 2023 13:12:35 +0000 (UTC)
     From:        lukem@NetBSD.org
     Message-ID:  <20230524131235.D6DD81A9239@mollari.NetBSD.org>

   | I also removed xstr and mkstr, since they only made sense for PDP-11
   | and weren't relevant even for VAX, and again, nothing in tree used them.

 For xstr that's wrong - xstr wasn't added until 3BSD, which was the VAX
 (first VAX) version of BSD.   While it might perhaps have had minor
 benefits for pdp-11's, it was still loading strings into memory, which
 is what they were short of (that is, address space, not necessarily
 actual RAM).

 kre


>Unformatted:

Home	PR Database Search