NetBSD Problem Report #36
From gnats Sun Dec 5 12:45:10 1993
Received: from forte (forte.mathematik.uni-Bremen.de [134.102.232.1]) by sun-lamp.cs.berkeley.edu (8.6.4/8.6.4) with ESMTP id MAA05370 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Sun, 5 Dec 1993 12:44:54 -0800
Message-Id: <199312052044.VAA04044@forte>
Date: Sun, 5 Dec 1993 21:44:12 +0100
From: thomas@mathematik.uni-Bremen.de
Reply-To: thomas@mathematik.uni-Bremen.de
To: gnats-bugs@sun-lamp.cs.berkeley.edu
Subject: crond doesn't log executed commands
X-Send-Pr-Version: 3.01.6
>Number: 36
>Category: bin
>Synopsis: crond doesn't log executed commands
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: gnats-admin
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun Dec 05 12:50:02 +0000 1993
>Closed-Date: Thu Dec 09 09:33:55 +0000 1993
>Last-Modified:
>Originator: Thomas Eberhardt
>Release:
>Organization:
CeVis, University of Bremen, Germany
>Environment:
System: NetBSD ed209 0.9a ED209#0 i386
Machine: i386
>Description:
crond doesn't log executed commands since the conditional around
the log_it call is only based on the definition of LOG_FILE instead
of LOG_FILE or SYSLOG. Also, if there is neither LOG_FILE nor SYSLOG
defined calls to log_it are still issued but there is no log_it
function defined (This doesn't affect us, since SYSLOG is defined
in config.h).
>How-To-Repeat:
>Fix:
*** do_command.c- Sun Nov 7 09:38:26 1993
--- do_command.c Sun Dec 5 21:18:06 1993
***************
*** 168,174 ****
* the actual user command shell was going to get and the
* PID is part of the log message.
*/
! #ifdef LOG_FILE
{
extern char *mkprints();
char *x = mkprints(cmd, strlen(cmd));
--- 168,174 ----
* the actual user command shell was going to get and the
* PID is part of the log message.
*/
! #if defined(LOG_FILE) || defined(SYSLOG)
{
extern char *mkprints();
char *x = mkprints(cmd, strlen(cmd));
*** misc.c- Sun Nov 7 09:38:28 1993
--- misc.c Sun Dec 5 21:22:00 1993
***************
*** 526,532 ****
}
- #if defined(LOG_FILE) || defined(SYSLOG)
void
log_it(username, pid, event, detail)
char *username;
--- 526,531 ----
***************
*** 621,627 ****
}
#endif
}
- #endif /*LOG_FILE || SYSLOG */
/* two warnings:
--- 620,625 ----
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback
State-Changed-By: jtc
State-Changed-When: Mon Dec 6 11:32:45 1993
State-Changed-Why:
Fix checked in by cgd.
State-Changed-From-To: feedback->closed
State-Changed-By: jtc
State-Changed-When: Thu Dec 9 09:33:55 1993
State-Changed-Why:
Cgd has tested change and it works.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.