NetBSD Problem Report #36036
From www@NetBSD.org Mon Mar 19 10:58:29 2007
Return-Path: <www@NetBSD.org>
Received: by narn.NetBSD.org (Postfix, from userid 31301)
id 7672F63BA73; Mon, 19 Mar 2007 10:58:29 +0000 (UTC)
Message-Id: <20070319105829.7672F63BA73@narn.NetBSD.org>
Date: Mon, 19 Mar 2007 10:58:29 +0000 (UTC)
From: lkundrak@redhat.com
Reply-To: lkundrak@redhat.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] uhub(4) 1.85 -> 1.86 breaks build of DEBUG kernel
X-Send-Pr-Version: www-1.0
>Number: 36036
>Category: kern
>Synopsis: [PATCH] uhub(4) 1.85 -> 1.86 breaks build of DEBUG kernel
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: kern-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Mar 19 11:00:00 +0000 2007
>Closed-Date: Mon Mar 19 14:03:44 +0000 2007
>Last-Modified: Mon Mar 19 14:05:01 +0000 2007
>Originator: Lubomir Kundrak
>Release:
>Organization:
>Environment:
>Description:
DPRINTF() statement in USB_MATCH() still contains a reference to usb_device_descriptor_t *dd, which was removed in revision 1.86. As it looks that the structure in question got merged with uaa, I suggest using it in the statement instead.
>How-To-Repeat:
Try to build -current DEBUG kernel with uhub(4) driver.
>Fix:
Index: sys/dev/usb/uhub.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/uhub.c,v
retrieving revision 1.87
diff -p -u -r1.87 uhub.c
--- sys/dev/usb/uhub.c 15 Mar 2007 15:29:09 -0000 1.87
+++ sys/dev/usb/uhub.c 19 Mar 2007 10:48:34 -0000
@@ -133,7 +133,7 @@ USB_MATCH(uhub)
{
USB_MATCH_START(uhub, uaa);
- DPRINTFN(5,("uhub_match, dd=%p\n", dd));
+ DPRINTFN(5,("uhub_match, uaa=%p\n", uaa));
/*
* The subclass for hubs seems to be 0 for some and 1 for others,
* so we just ignore the subclass.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: drochner@netbsd.org
State-Changed-When: Mon, 19 Mar 2007 14:03:44 +0000
State-Changed-Why:
patch applied, thanks
sorry for the breakage
From: Matthias Drochner <drochner@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: PR/36036 CVS commit: src/sys/dev/usb
Date: Mon, 19 Mar 2007 14:03:00 +0000 (UTC)
Module Name: src
Committed By: drochner
Date: Mon Mar 19 14:03:00 UTC 2007
Modified Files:
src/sys/dev/usb: uhub.c
Log Message:
fix variable in DEBUG code, from Lubomir Kundrak per PR kern/36036
To generate a diff of this commit:
cvs rdiff -r1.87 -r1.88 src/sys/dev/usb/uhub.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.