NetBSD Problem Report #36186

From martin@duskware.de  Sat Apr 21 11:47:14 2007
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 2904F63B964
	for <gnats-bugs@gnats.netbsd.org>; Sat, 21 Apr 2007 11:47:14 +0000 (UTC)
Message-Id: <20070421013311.CD21B63B964@narn.NetBSD.org>
Date: Sat, 21 Apr 2007 01:33:11 +0000 (UTC)
From: naoto@morishima.net
Reply-To: naoto@morishima.net
To: netbsd-bugs-owner@NetBSD.org
Subject: net/freeradius cannot be compiled on Solaris 10
X-Send-Pr-Version: www-1.0

>Number:         36186
>Category:       pkg
>Synopsis:       net/freeradius cannot be compiled on Solaris 10
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    adrianp
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 21 11:50:00 +0000 2007
>Closed-Date:    Sat Jan 05 12:47:28 +0000 2008
>Last-Modified:  Sat Jan 05 12:47:28 +0000 2008
>Originator:     Naoto Morishima
>Release:        NetBSD 3.1_STABLE
>Organization:
>Environment:
SunOS XXX 5.8 Generic_117350-46 sun4u sparc SUNW,Sun-Fire-V210

>Description:
There seem to be several problems at compiling freeradius on Solaris.  At least src/modules/rlm_preprocess/rlm_preprocess.c needs a patch to add some casts to strvalue. 

>How-To-Repeat:
Compile net/freeradius on Solaris 10 with PKGSRC_COMPILER=sunpro.
>Fix:
Following patch will resolve one of these problems... (but we still cannot compile it).

--- src/modules/rlm_preprocess/rlm_preprocess.c.orig	2007-04-21 10:13:32.445189000 +0900
+++ src/modules/rlm_preprocess/rlm_preprocess.c	2007-04-21 10:13:34.105233000 +0900
@@ -126,7 +126,7 @@
 		/*
 		 *  No weird packing.  Ignore it.
 		 */
-		ptr = strchr(vp->strvalue, '='); /* find an '=' */
+		ptr = strchr((char *)vp->strvalue, '='); /* find an '=' */
 		if (!ptr) continue;

 		/*
@@ -144,7 +144,7 @@
 			char *p;
 			DICT_ATTR	*dattr;

-			p = vp->strvalue;
+			p = (char *)vp->strvalue;
 			gettoken(&p, newattr, sizeof(newattr));

 			if (((dattr = dict_attrbyname(newattr)) != NULL) &&
@@ -223,10 +223,10 @@
 		 *
 		 *	FIXME: should we handle this as a REALM ?
 		 */
-		if ((ptr = strchr(namepair->strvalue, '\\')) != NULL) {
+		if ((ptr = strchr((char *)namepair->strvalue, '\\')) != NULL) {
 			strNcpy(newname, ptr + 1, sizeof(newname));
 			/* Same size */
-			strcpy(namepair->strvalue, newname);
+			strcpy((char *)namepair->strvalue, newname);
 			namepair->length = strlen(newname);
 		}
 	}
@@ -395,9 +395,9 @@
 					break;
 				}

-				strNcpy(vp->strvalue, i->name,
+				strNcpy((char *)vp->strvalue, i->name,
 					sizeof(vp->strvalue));
-				vp->length = strlen(vp->strvalue);
+				vp->length = strlen((char *)vp->strvalue);

 				pairadd(&request_pairs, vp);
 			}
@@ -425,7 +425,7 @@
 			return -1;
 		}
 		nas->lvalue = request->packet->src_ipaddr;
-		ip_hostname(nas->strvalue, sizeof(nas->strvalue), nas->lvalue);
+		ip_hostname((char *)nas->strvalue, sizeof(nas->strvalue), nas->lvalue);
 		pairadd(&request->packet->vps, nas);
 	}

@@ -446,7 +446,7 @@
 	  return -1;
 	}
 	nas->lvalue = request->packet->src_ipaddr;
-	ip_hostname(nas->strvalue, sizeof(nas->strvalue), nas->lvalue);
+	ip_hostname((char *)nas->strvalue, sizeof(nas->strvalue), nas->lvalue);
 	pairadd(&request->packet->vps, nas);
 	return 0;
 }
@@ -580,7 +580,7 @@
 	if ((r = huntgroup_access(request, data->huntgroups,
 			     request->packet->vps)) != RLM_MODULE_OK) {
 		radlog(L_AUTH, "No huntgroup access: [%s] (%s)",
-		       request->username ? request->username->strvalue : "<No User-Name>",
+		       request->username ? (char *)request->username->strvalue : "<No User-Name>",
 		       auth_name(buf, sizeof(buf), request, 1));
 		return r;
 	}

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->adrianp
Responsible-Changed-By: reed@netbsd.org
Responsible-Changed-When: Thu, 26 Apr 2007 13:40:29 +0000
Responsible-Changed-Why:
Assigned to maintainer.


State-Changed-From-To: open->feedback
State-Changed-By: adrianp@netbsd.org
State-Changed-When: Mon, 12 Nov 2007 09:33:57 +0000
State-Changed-Why:
I've successfully compiled freeradius 1.1.7 on Solaris 10 from pkgsrc-HEAD.  Could you please confirm if this is still a problem for you ?


From: Naoto Morishima <naoto@morishima.net>
To: gnats-bugs@NetBSD.org
Cc: adrianp@NetBSD.org, pkgsrc-bugs@netbsd.org,
	gnats-admin@netbsd.org, adrianp@netbsd.org
Subject: Re: pkg/36186 (net/freeradius cannot be compiled on Solaris 10)
Date: Mon, 12 Nov 2007 18:53:39 +0900

 >>>>> On Mon, 12 Nov 2007 09:33:59 +0000 (UTC),  <adrianp@netbsd.org> said:

 adrianp> I've successfully compiled freeradius 1.1.7 on Solaris 10
 adrianp> from pkgsrc-HEAD.  Could you please confirm if this is still
 adrianp> a problem for you ? 

  I've just tried to compile it on Solaris 10 with PKGSRC_COMPILER=
  sunpro, and found that this problem still remains as follows:

 "rlm_preprocess.c", line 129: warning: argument #1 is incompatible with prototype:
         prototype: pointer to const char : "/usr/include/iso/string_iso.h", line 130
         argument : pointer to unsigned char
 "rlm_preprocess.c", line 147: warning: assignment type mismatch:
         pointer to char "=" pointer to unsigned char
 "rlm_preprocess.c", line 226: warning: argument #1 is incompatible with prototype:
         prototype: pointer to const char : "/usr/include/iso/string_iso.h", line 130
         argument : pointer to unsigned char

  (... snip)

 Regards,
 Naoto Morishima





From: Uwe Klaus <uklaus@hgb-leipzig.de>
To: gnats-bugs@NetBSD.org
Cc: adrianp@NetBSD.org, gnats-admin@NetBSD.org,
	pkgsrc-bugs@NetBSD.org, naoto@morishima.net
Subject: Re: pkg/36186 (net/freeradius cannot be compiled on Solaris 10)
Date: Mon, 12 Nov 2007 18:06:42 +0100 (CET)

 On Mon, 12 Nov 2007, Naoto Morishima wrote:

 > adrianp> I've successfully compiled freeradius 1.1.7 on Solaris 10
 > adrianp> from pkgsrc-HEAD.  Could you please confirm if this is still
 > adrianp> a problem for you ?
 >
 >  I've just tried to compile it on Solaris 10 with PKGSRC_COMPILER=
 >  sunpro, and found that this problem still remains as follows:
 >
 > "rlm_preprocess.c", line 129: warning: argument #1 is incompatible with prototype:
 >         prototype: pointer to const char : "/usr/include/iso/string_iso.h", line 130
 >         argument : pointer to unsigned char
 > "rlm_preprocess.c", line 147: warning: assignment type mismatch:
 >         pointer to char "=" pointer to unsigned char
 > "rlm_preprocess.c", line 226: warning: argument #1 is incompatible with prototype:
 >         prototype: pointer to const char : "/usr/include/iso/string_iso.h", line 130
 >         argument : pointer to unsigned char

 Below is my list of solaris sparc packages I cannot compile using sunpro 
 studio 11 (btw. gcc3-c-3.3.6/gcc3-c++-3.3.6 does the job).

 /usr/pkgsrc/converters/p5-Convert-UUlib
 /usr/pkgsrc/textproc/sablotron
 /usr/pkgsrc/textproc/gsed
 /usr/pkgsrc/mail/sendmail
 /usr/pkgsrc/mail/libmilter
 /usr/pkgsrc/lang/kaffe
 /usr/pkgsrc/graphics/netpbm
 /usr/pkgsrc/graphics/gocr
 /usr/pkgsrc/devel/libevent
 /usr/pkgsrc/devel/librsync
 /usr/pkgsrc/devel/gmp
 /usr/pkgsrc/net/freeradius
 /usr/pkgsrc/misc/dpkg
 /usr/pkgsrc/misc/rpm
 /usr/pkgsrc/net/mDNSResponder
 /usr/pkgsrc/security/mhash
 /usr/pkgsrc/security/php-mhash
 /usr/pkgsrc/security/opencdk

 Best regrads,
 Uwe

From: Adrian Portelli <adrianp@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: uklaus@hgb-leipzig.de
Subject: Re: pkg/36186 (net/freeradius cannot be compiled on Solaris 10)
Date: Mon, 12 Nov 2007 19:33:01 +0000

 Uwe Klaus wrote:
 > The following reply was made to PR pkg/36186; it has been noted by GNATS.
 > 
 > From: Uwe Klaus <uklaus@hgb-leipzig.de>
 > To: gnats-bugs@NetBSD.org
 > Cc: adrianp@NetBSD.org, gnats-admin@NetBSD.org,
 > 	pkgsrc-bugs@NetBSD.org, naoto@morishima.net
 > Subject: Re: pkg/36186 (net/freeradius cannot be compiled on Solaris 10)
 > Date: Mon, 12 Nov 2007 18:06:42 +0100 (CET)
 > 
 >  On Mon, 12 Nov 2007, Naoto Morishima wrote:
 >  
 >  > adrianp> I've successfully compiled freeradius 1.1.7 on Solaris 10
 >  > adrianp> from pkgsrc-HEAD.  Could you please confirm if this is still
 >  > adrianp> a problem for you ?
 >  >
 >  >  I've just tried to compile it on Solaris 10 with PKGSRC_COMPILER=
 >  >  sunpro, and found that this problem still remains as follows:
 >  >
 >  > "rlm_preprocess.c", line 129: warning: argument #1 is incompatible with prototype:
 >  >         prototype: pointer to const char : "/usr/include/iso/string_iso.h", line 130
 >  >         argument : pointer to unsigned char
 >  > "rlm_preprocess.c", line 147: warning: assignment type mismatch:
 >  >         pointer to char "=" pointer to unsigned char
 >  > "rlm_preprocess.c", line 226: warning: argument #1 is incompatible with prototype:
 >  >         prototype: pointer to const char : "/usr/include/iso/string_iso.h", line 130
 >  >         argument : pointer to unsigned char
 >  
 >  Below is my list of solaris sparc packages I cannot compile using sunpro 
 >  studio 11 (btw. gcc3-c-3.3.6/gcc3-c++-3.3.6 does the job).
 >  
 >  /usr/pkgsrc/converters/p5-Convert-UUlib
 >  /usr/pkgsrc/textproc/sablotron
 >  /usr/pkgsrc/textproc/gsed
 >  /usr/pkgsrc/mail/sendmail
 >  /usr/pkgsrc/mail/libmilter
 >  /usr/pkgsrc/lang/kaffe
 >  /usr/pkgsrc/graphics/netpbm
 >  /usr/pkgsrc/graphics/gocr
 >  /usr/pkgsrc/devel/libevent
 >  /usr/pkgsrc/devel/librsync
 >  /usr/pkgsrc/devel/gmp
 >  /usr/pkgsrc/net/freeradius
 >  /usr/pkgsrc/misc/dpkg
 >  /usr/pkgsrc/misc/rpm
 >  /usr/pkgsrc/net/mDNSResponder
 >  /usr/pkgsrc/security/mhash
 >  /usr/pkgsrc/security/php-mhash
 >  /usr/pkgsrc/security/opencdk
 >  
 >  Best regrads,
 >  Uwe
 >  

 net/snort is missing from that list too and it compiles fine using the
 compiler from SUNwgcc as well.

 adrian.

From: Adrian Portelli <adrianp@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/36186 CVS commit: pkgsrc/net/freeradius
Date: Sat, 24 Nov 2007 17:40:36 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	adrianp
 Date:		Sat Nov 24 17:40:36 UTC 2007

 Modified Files:
 	pkgsrc/net/freeradius: Makefile distinfo
 Added Files:
 	pkgsrc/net/freeradius/patches: patch-al

 Log Message:
 Fix builds on Solaris using the SunPRO compiler.  This should fix PR# 36186.
 Also do some pkglintification while we are here.


 To generate a diff of this commit:
 cvs rdiff -r1.61 -r1.62 pkgsrc/net/freeradius/Makefile
 cvs rdiff -r1.27 -r1.28 pkgsrc/net/freeradius/distinfo
 cvs rdiff -r0 -r1.1 pkgsrc/net/freeradius/patches/patch-al

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Naoto Morishima <naoto@morishima.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/36186
Date: Sat, 05 Jan 2008 19:33:45 +0900

 The patches for this PR has been already committed, but it still
 remains in feedback state.  Would you please close it?

 Regards,
 Naoto Morishima

State-Changed-From-To: feedback->closed
State-Changed-By: adrianp@netbsd.org
State-Changed-When: Sat, 05 Jan 2008 12:47:28 +0000
State-Changed-Why:
Patches committed


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.