NetBSD Problem Report #36306

From martin@duskware.de  Fri May 11 13:53:53 2007
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 0129263B853
	for <gnats-bugs@gnats.netbsd.org>; Fri, 11 May 2007 13:53:52 +0000 (UTC)
Message-Id: <20070511011117.1E13763B853@narn.NetBSD.org>
Date: Fri, 11 May 2007 01:11:17 +0000 (UTC)
From: candy-netbsd@kgc.co.jp
Reply-To: candy-netbsd@kgc.co.jp
To: netbsd-bugs-owner@NetBSD.org
Subject: Console driver outputs \n\r sequence at end-of-line
X-Send-Pr-Version: www-1.0

>Number:         36306
>Category:       kern
>Synopsis:       Console driver outputs \n\r sequence at end-of-line
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    nakayama
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 11 13:55:00 +0000 2007
>Closed-Date:    Tue Mar 24 11:35:14 +0000 2015
>Last-Modified:  Tue Mar 24 11:35:14 +0000 2015
>Originator:     KANDA Toshihiro
>Release:        any version
>Organization:
-
>Environment:
>Description:
Console driver outputs \n\r sequence at end-of-line.

>How-To-Repeat:
Log serial console output.

# od -c serial-console-log
0000000    C   o   p   y   r   i   g   h   t       (   c   )       1   9
0000020    9   6   ,       1   9   9   7   ,       1   9   9   8   ,    
0000040    1   9   9   9   ,       2   0   0   0   ,       2   0   0   1
0000060    ,       2   0   0   2   ,       2   0   0   3  \n  \r        


>Fix:
/sys/dev/cons.c


--- cons.c.orig Fri May 11 10:07:52 2007
+++ cons.c      Fri May 11 10:08:23 2007
@@ -366,9 +366,9 @@
                return;

        if (c) {
-               (*cn_tab->cn_putc)(cn_tab->cn_dev, c);
                if (c == '\n')
                        (*cn_tab->cn_putc)(cn_tab->cn_dev, '\r');
+               (*cn_tab->cn_putc)(cn_tab->cn_dev, c);
        }
 }

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->nakayama
Responsible-Changed-By: nakayama@NetBSD.org
Responsible-Changed-When: Sat, 07 Mar 2015 06:40:30 +0000
Responsible-Changed-Why:
I didn't know the PR, but I commited the same fix.


State-Changed-From-To: open->pending-pullups
State-Changed-By: nakayama@NetBSD.org
State-Changed-When: Sat, 07 Mar 2015 06:40:30 +0000
State-Changed-Why:
pullup-7 #574
pullup-6 #1267
pullup-5 #1952


State-Changed-From-To: pending-pullups->closed
State-Changed-By: nakayama@NetBSD.org
State-Changed-When: Tue, 24 Mar 2015 11:35:14 +0000
State-Changed-Why:
pulled up.


>Unformatted:

Home	PR Database Search