NetBSD Problem Report #36462

From martin@duskware.de  Sat Jun  9 09:49:45 2007
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id A6F6663B946
	for <gnats-bugs@gnats.netbsd.org>; Sat,  9 Jun 2007 09:49:44 +0000 (UTC)
Message-Id: <20070609015842.AE8E663B946@narn.NetBSD.org>
Date: Sat,  9 Jun 2007 01:58:42 +0000 (UTC)
From: brickviking@gmail.com
Reply-To: brickviking@gmail.com
To: netbsd-bugs-owner@NetBSD.org
Subject: initial test for non-existence of pre-processor symbol MALLOC_EXTRA_SANITY
X-Send-Pr-Version: www-1.0

>Number:         36462
>Category:       lib
>Synopsis:       initial test for non-existence of pre-processor symbol MALLOC_EXTRA_SANITY
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 09 09:50:00 +0000 2007
>Originator:     Eric Gillespie
>Release:        3.0
>Organization:
none
>Environment:
>Description:
In source code file src/lib/libc/stdlib/malloc.c:22-24, this test doesn't do anything.
22:#ifndef MALLOC_EXTRA_SANITY
23:#undef MALLOC_EXTRA_SANITY
24:#endif

If the symbol isn't defined, the preprocessor will attempt to undefine
it anyhow. If the symbol IS defined, these lines will be skipped. Hence
these lines don't do anything useful. These lines were removed in 2005 
from the original FreeBSD source from which this file was derived.
That's nine years after initial inclusion. phk (phk@freebsd.org) had this
to say:
:They used to control some very paranoid consistency check code that
:was removed pretty early on, unfortunately, those three lines got 
:missed somehow.

>How-To-Repeat:
list the source code to the above file.
>Fix:
Remove the three lines.

Home	PR Database Search